Move MissingRegistrationDataHandler to NavigationHandler
ClosedPublic
Actions

Authored by marcin on Apr 25 2024, 8:20 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM2c232c7e3138: Move MissingRegistrationDataHandler to NavigationHandler

Summary

This differential solves the following Linear issue: https://linear.app/comm/issue/ENG-7967/navigation-error.

Test Plan

Repeat reproduction steps without this diff. Ensure error occurs.
Repeat reproduction steps with this diff. Ensure everything works.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-7964

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Apr 25 2024, 8:20 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 25 2024, 8:20 AM

Harbormaster completed remote builds in B28468: Diff 39491.Apr 25 2024, 8:37 AM

marcin requested review of this revision.Apr 25 2024, 8:37 AM

marcin added a child revision: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.Apr 26 2024, 1:19 AM

marcin edited child revisions, added: D11782: Let the user skip backup message generation and record it in alert store; removed: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.

marcin added a parent revision: D11645: Force already logged in ETH users to create and sign backup message.

marcin removed a parent revision: D11645: Force already logged in ETH users to create and sign backup message.

marcin added a parent revision: D11794: [native] Don't refetch nonce after SIWE is complete.

tomek accepted this revision.Apr 26 2024, 5:19 AM

This revision is now accepted and ready to land.Apr 26 2024, 5:19 AM

Rebase before landing

Harbormaster completed remote builds in B28565: Diff 39638.Apr 29 2024, 3:51 AM

Rebase before landing

Harbormaster completed remote builds in B28569: Diff 39643.Apr 29 2024, 4:32 AM

Closed by commit rCOMM2c232c7e3138: Move MissingRegistrationDataHandler to NavigationHandler (authored by marcin). · Explain WhyApr 29 2024, 4:55 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM2c232c7e3138: Move MissingRegistrationDataHandler to NavigationHandler.

Revision Contents
Changeset List

Path

Size

native/

navigation/

navigation-handler.react.js

2 lines

root.react.js

2 lines

Diff 39491

View Options

native/navigation/navigation-handler.react.js