Page MenuHomePhabricator
Differential D11785

[native] introduce TagFarcasterChannelParams
ClosedPublic
Actions

Authored by ginsu on Apr 25 2024, 1:40 PM.
Tags
None
Referenced Files
F2020925: D11785.id39675.diff
Sun, Jun 16, 5:57 PM
Unknown Object (File)
Fri, Jun 14, 1:15 AM
Unknown Object (File)
Wed, Jun 12, 4:46 PM
Unknown Object (File)
Sat, May 25, 7:55 PM
Unknown Object (File)
Sun, May 19, 9:42 AM
Unknown Object (File)
Sun, May 19, 9:42 AM
Unknown Object (File)
Sun, May 19, 9:41 AM
Unknown Object (File)
Sun, May 19, 9:41 AM
View All 21 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams
Summary

The TagFarcasterChannel screen needs to have context on which community is being tagged. To give TagFarcasterChannel this context we need to introduce TagFarcasterChannelParams which contains a communityID field

Depends on D11784

Test Plan

flow + was able to log out the correct communityID

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 25 2024, 1:40 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 25 2024, 1:40 PM
ginsu edited the summary of this revision. (Show Details)Apr 25 2024, 1:42 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11784: [native] update selectedChannel state to be a FarcasterChannel type.
Harbormaster completed remote builds in B28481: Diff 39511.Apr 25 2024, 1:56 PM
ginsu requested review of this revision.Apr 25 2024, 1:56 PM
ginsu added a child revision: D11793: [native] introduce tag farcaster button.Apr 25 2024, 4:17 PM
inka accepted this revision.Apr 26 2024, 8:32 AM
This revision is now accepted and ready to land.Apr 26 2024, 8:32 AM
ginsu updated this revision to Diff 39668.Apr 29 2024, 11:52 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 29 2024, 11:57 AM
Closed by commit rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams.
Harbormaster completed remote builds in B28588: Diff 39668.Apr 29 2024, 12:17 PM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
4 lines
components/
5 lines
navigation/
3 lines

Diff 39511

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...
View Options

native/components/community-actions-button.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...