Page MenuHomePhabricator
Differential D11815

[lib] introduce deleteFarcasterChannelTagActionTypes
ClosedPublic
Actions

Authored by ginsu on Apr 26 2024, 12:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 8:58 AM
Unknown Object (File)
Wed, Mar 12, 4:31 AM
Unknown Object (File)
Tue, Mar 11, 7:42 PM
Unknown Object (File)
Sun, Mar 9, 12:27 PM
Unknown Object (File)
Mar 1 2025, 9:32 AM
Unknown Object (File)
Feb 24 2025, 6:42 PM
Unknown Object (File)
Feb 14 2025, 3:09 PM
Unknown Object (File)
Jan 23 2025, 5:17 AM
View All 78 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
bartek
tomek
Commits
rCOMMdd631917b6ec: [lib] introduce deleteFarcasterChannelTagActionTypes
Summary

This diff introduces the deleteFarcasterChannelTagActionTypes so that we can dispatch this action from the client and is another necessary piece we need to properly call the delete_farcaster_channel_tag endpoint

Depends on D11814

Test Plan

Locally I was able to confirm that when I dispatched this new action I would call the delete_farcaster_channel_tag endpoint

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 26 2024, 12:47 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 26 2024, 12:47 PM
ginsu edited the summary of this revision. (Show Details)Apr 26 2024, 12:48 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, bartek, tomek.
ginsu added a parent revision: D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.
ginsu added a child revision: D11821: [lib] introduce useDeleteFarcasterChannelTag.Apr 26 2024, 12:58 PM
Harbormaster completed remote builds in B28538: Diff 39594.Apr 26 2024, 1:03 PM
ginsu requested review of this revision.Apr 26 2024, 1:03 PM
tomek accepted this revision.Apr 29 2024, 1:28 AM
tomek added inline comments.
lib/types/redux-types.js
1419

Are you sure we don't need any payload here?

This revision is now accepted and ready to land.Apr 29 2024, 1:28 AM
ginsu added inline comments.May 1 2024, 10:44 PM
lib/types/redux-types.js
1419

Yes, I haven't needed the payload in my local stack so far. If I do realize later that we actually do, I will create a follow up diff for this

ginsu updated this revision to Diff 39731.May 1 2024, 10:45 PM

rebase before landing

This revision was landed with ongoing or failed builds.May 1 2024, 10:52 PM
Closed by commit rCOMMdd631917b6ec: [lib] introduce deleteFarcasterChannelTagActionTypes (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdd631917b6ec: [lib] introduce deleteFarcasterChannelTagActionTypes.
Harbormaster completed remote builds in B28624: Diff 39731.May 1 2024, 11:01 PM

Revision Contents
Changeset List

PathSize
lib/
actions/
7 lines
types/
4 lines
17 lines

Diff 39594

View Options

lib/actions/community-actions.js

Show First 20 Lines • Show All 218 Lines • ▼ Show 20 Linesfunction generateOpsForUserUpdates(payload: {
return payload.updatesResult.newUpdates return payload.updatesResult.newUpdates
.map(update => .map(update =>
updateSpecs[update.type].generateOpsForUserInfoUpdates?.(update), updateSpecs[update.type].generateOpsForUserInfoUpdates?.(update),
) )
.filter(Boolean) .filter(Boolean)
.flat(); .flat();
} }
function discardKeyserverUsernames(
newUserInfos: UserInfos,
stateUserInfos: UserInfos,
): UserInfos {
let result: UserInfos = {};
for (const id in newUserInfos) {
const username = stateUserInfos[id] ? stateUserInfos[id].username : null;
result = {
...result,
[id]: {
...newUserInfos[id],
username,
},
};
}
return result;
}
type ReduceUserInfosResult = [ type ReduceUserInfosResult = [
UserStore, UserStore,
$ReadOnlyArray<ClientUserInconsistencyReportCreationRequest>, $ReadOnlyArray<ClientUserInconsistencyReportCreationRequest>,
$ReadOnlyArray<UserStoreOperation>, $ReadOnlyArray<UserStoreOperation>,
]; ];
function handleUserInfoUpdates( function handleUserInfoUpdates(
state: UserStore, state: UserStore,
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Lines ) {
if (action.type === joinThreadActionTypes.success) { if (action.type === joinThreadActionTypes.success) {
keyserverID = action.payload.keyserverID; keyserverID = action.payload.keyserverID;
} else { } else {
keyserverID = extractKeyserverIDFromID(action.payload.newThreadID); keyserverID = extractKeyserverIDFromID(action.payload.newThreadID);
} }
if (keyserverID !== authoritativeKeyserverID()) { if (keyserverID !== authoritativeKeyserverID()) {
return [state, [], []]; return [state, [], []];
} }
const newUserInfos: UserInfos = _keyBy(userInfo => userInfo.id)( const keyserverUserInfos: UserInfos = _keyBy(userInfo => userInfo.id)(
action.payload.userInfos, action.payload.userInfos,
); );
const newUserInfos = discardKeyserverUsernames(
keyserverUserInfos,
state.userInfos,
);
const userStoreOps: $ReadOnlyArray<UserStoreOperation> = const userStoreOps: $ReadOnlyArray<UserStoreOperation> =
convertUserInfosToReplaceUserOps(newUserInfos); convertUserInfosToReplaceUserOps(newUserInfos);
const processedUserInfos: UserInfos = processUserStoreOps( const processedUserInfos: UserInfos = processUserStoreOps(
state.userInfos, state.userInfos,
userStoreOps, userStoreOps,
); );
if (!_isEqual(state.userInfos)(processedUserInfos)) { if (!_isEqual(state.userInfos)(processedUserInfos)) {
▲ Show 20 Lines • Show All 236 Lines • Show Last 20 Lines
View Options

lib/types/community-types.js

Show First 20 Lines • Show All 218 Lines • ▼ Show 20 Linesfunction generateOpsForUserUpdates(payload: {
return payload.updatesResult.newUpdates return payload.updatesResult.newUpdates
.map(update => .map(update =>
updateSpecs[update.type].generateOpsForUserInfoUpdates?.(update), updateSpecs[update.type].generateOpsForUserInfoUpdates?.(update),
) )
.filter(Boolean) .filter(Boolean)
.flat(); .flat();
} }
function discardKeyserverUsernames(
newUserInfos: UserInfos,
stateUserInfos: UserInfos,
): UserInfos {
let result: UserInfos = {};
for (const id in newUserInfos) {
const username = stateUserInfos[id] ? stateUserInfos[id].username : null;
result = {
...result,
[id]: {
...newUserInfos[id],
username,
},
};
}
return result;
}
type ReduceUserInfosResult = [ type ReduceUserInfosResult = [
UserStore, UserStore,
$ReadOnlyArray<ClientUserInconsistencyReportCreationRequest>, $ReadOnlyArray<ClientUserInconsistencyReportCreationRequest>,
$ReadOnlyArray<UserStoreOperation>, $ReadOnlyArray<UserStoreOperation>,
]; ];
function handleUserInfoUpdates( function handleUserInfoUpdates(
state: UserStore, state: UserStore,
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Lines ) {
if (action.type === joinThreadActionTypes.success) { if (action.type === joinThreadActionTypes.success) {
keyserverID = action.payload.keyserverID; keyserverID = action.payload.keyserverID;
} else { } else {
keyserverID = extractKeyserverIDFromID(action.payload.newThreadID); keyserverID = extractKeyserverIDFromID(action.payload.newThreadID);
} }
if (keyserverID !== authoritativeKeyserverID()) { if (keyserverID !== authoritativeKeyserverID()) {
return [state, [], []]; return [state, [], []];
} }
const newUserInfos: UserInfos = _keyBy(userInfo => userInfo.id)( const keyserverUserInfos: UserInfos = _keyBy(userInfo => userInfo.id)(
action.payload.userInfos, action.payload.userInfos,
); );
const newUserInfos = discardKeyserverUsernames(
keyserverUserInfos,
state.userInfos,
);
const userStoreOps: $ReadOnlyArray<UserStoreOperation> = const userStoreOps: $ReadOnlyArray<UserStoreOperation> =
convertUserInfosToReplaceUserOps(newUserInfos); convertUserInfosToReplaceUserOps(newUserInfos);
const processedUserInfos: UserInfos = processUserStoreOps( const processedUserInfos: UserInfos = processUserStoreOps(
state.userInfos, state.userInfos,
userStoreOps, userStoreOps,
); );
if (!_isEqual(state.userInfos)(processedUserInfos)) { if (!_isEqual(state.userInfos)(processedUserInfos)) {
▲ Show 20 Lines • Show All 236 Lines • Show Last 20 Lines
View Options

lib/types/redux-types.js

Show First 20 Lines • Show All 218 Lines • ▼ Show 20 Linesfunction generateOpsForUserUpdates(payload: {
return payload.updatesResult.newUpdates return payload.updatesResult.newUpdates
.map(update => .map(update =>
updateSpecs[update.type].generateOpsForUserInfoUpdates?.(update), updateSpecs[update.type].generateOpsForUserInfoUpdates?.(update),
) )
.filter(Boolean) .filter(Boolean)
.flat(); .flat();
} }
function discardKeyserverUsernames(
newUserInfos: UserInfos,
stateUserInfos: UserInfos,
): UserInfos {
let result: UserInfos = {};
for (const id in newUserInfos) {
const username = stateUserInfos[id] ? stateUserInfos[id].username : null;
result = {
...result,
[id]: {
...newUserInfos[id],
username,
},
};
}
return result;
}
type ReduceUserInfosResult = [ type ReduceUserInfosResult = [
UserStore, UserStore,
$ReadOnlyArray<ClientUserInconsistencyReportCreationRequest>, $ReadOnlyArray<ClientUserInconsistencyReportCreationRequest>,
$ReadOnlyArray<UserStoreOperation>, $ReadOnlyArray<UserStoreOperation>,
]; ];
function handleUserInfoUpdates( function handleUserInfoUpdates(
state: UserStore, state: UserStore,
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Lines ) {
if (action.type === joinThreadActionTypes.success) { if (action.type === joinThreadActionTypes.success) {
keyserverID = action.payload.keyserverID; keyserverID = action.payload.keyserverID;
} else { } else {
keyserverID = extractKeyserverIDFromID(action.payload.newThreadID); keyserverID = extractKeyserverIDFromID(action.payload.newThreadID);
} }
if (keyserverID !== authoritativeKeyserverID()) { if (keyserverID !== authoritativeKeyserverID()) {
return [state, [], []]; return [state, [], []];
} }
const newUserInfos: UserInfos = _keyBy(userInfo => userInfo.id)( const keyserverUserInfos: UserInfos = _keyBy(userInfo => userInfo.id)(
action.payload.userInfos, action.payload.userInfos,
); );
const newUserInfos = discardKeyserverUsernames(
keyserverUserInfos,
state.userInfos,
);
const userStoreOps: $ReadOnlyArray<UserStoreOperation> = const userStoreOps: $ReadOnlyArray<UserStoreOperation> =
convertUserInfosToReplaceUserOps(newUserInfos); convertUserInfosToReplaceUserOps(newUserInfos);
const processedUserInfos: UserInfos = processUserStoreOps( const processedUserInfos: UserInfos = processUserStoreOps(
state.userInfos, state.userInfos,
userStoreOps, userStoreOps,
); );
if (!_isEqual(state.userInfos)(processedUserInfos)) { if (!_isEqual(state.userInfos)(processedUserInfos)) {
▲ Show 20 Lines • Show All 236 Lines • Show Last 20 Lines