Page MenuHomePhabricator
Differential D11784

[native] update selectedChannel state to be a FarcasterChannel type
ClosedPublic
Actions

Authored by ginsu on Apr 25 2024, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 5:47 AM
Unknown Object (File)
Oct 15 2024, 5:59 AM
Unknown Object (File)
Oct 12 2024, 3:50 PM
Unknown Object (File)
Oct 12 2024, 3:50 PM
Unknown Object (File)
Oct 12 2024, 3:50 PM
Unknown Object (File)
Oct 12 2024, 3:50 PM
Unknown Object (File)
Oct 12 2024, 3:50 PM
Unknown Object (File)
Oct 4 2024, 9:58 AM
View All 55 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
atul
Commits
rCOMM7cf5ed482dfa: [native] update selectedChannel state to be a FarcasterChannel type
Summary

The selectedChannel state in the TagFarcasterChannel component was intially typed as a string. However, we should use the FarcasterChannel type here since I plan to use the farcaster channel id (which is a field in FarcasterChannel) in a subsequent diff

Depends on D11776

Test Plan

flow + confirmed that the existing farcaster channel selection user flow has no regressions

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 25 2024, 1:35 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 25 2024, 1:35 PM
ginsu edited the summary of this revision. (Show Details)Apr 25 2024, 1:38 PM
ginsu added reviewers: inka, atul.
ginsu added a parent revision: D11776: [lib] move farcaster types to dedicated file.
ginsu added a child revision: D11785: [native] introduce TagFarcasterChannelParams.Apr 25 2024, 1:42 PM
Harbormaster completed remote builds in B28480: Diff 39510.Apr 25 2024, 1:51 PM
ginsu requested review of this revision.Apr 25 2024, 1:51 PM
inka accepted this revision.Apr 26 2024, 8:30 AM
This revision is now accepted and ready to land.Apr 26 2024, 8:30 AM
ginsu updated this revision to Diff 39667.Apr 29 2024, 11:51 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 29 2024, 11:57 AM
Closed by commit rCOMM7cf5ed482dfa: [native] update selectedChannel state to be a FarcasterChannel type (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7cf5ed482dfa: [native] update selectedChannel state to be a FarcasterChannel type.
Harbormaster completed remote builds in B28587: Diff 39667.Apr 29 2024, 12:13 PM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
22 lines

Diff 39674

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...