[keyserver] introduce deleteFarcasterChannelTag
ClosedPublic
Actions

Authored by ginsu on Apr 26 2024, 12:32 PM.

Details

Reviewers

atul
bartek
tomek

Commits

rCOMMa6d188d1ca79: [keyserver] introduce deleteFarcasterChannelTag

Summary

This diff introduces the barebones deleteFarcasterChannelTag function. For the scope of this project we just want this function to delete the farcaster channel tag blob from the blob service for now, with the intention that all the other necessary parts for this function (like permissions, updating the row in the community table on the keyserver to remove the blob holder will be added to this function as a follow up project that I will start shortly)

Depends on D11809

Test Plan

In my local stack I was able to use deleteFarcasterChannelTag to delete the farcaster channel => comm community blob.

I also confirmed that when the GATE_TAG_FARCASTER_CHANNEL gate is set to true the function throws a server error

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 26 2024, 12:32 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 26 2024, 12:32 PM

ginsu edited the summary of this revision. (Show Details)Apr 26 2024, 12:34 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, bartek, tomek.

ginsu added a parent revision: D11809: [native] show error message for tag farcaster channel errors.

ginsu added inline comments.

lib/types/community-types.js
33 ↗	(On Diff #39592)	In my next project, we will refactor this so the blob holder is no longer part of the request

ginsu added a child revision: D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.Apr 26 2024, 12:45 PM

Harbormaster completed remote builds in B28536: Diff 39592.Apr 26 2024, 12:51 PM

ginsu requested review of this revision.Apr 26 2024, 12:51 PM

ashoat mentioned this in D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.Apr 27 2024, 5:12 PM

tomek accepted this revision.Apr 29 2024, 1:18 AM

tomek added inline comments.

lib/shared/community-utils.js
5 ↗	(On Diff #39592)	The argument is `farcasterChannelID` and not a `secret`. For invite links, this argument is called `secret` because it is a link secret.
lib/types/community-types.js
31 ↗	(On Diff #39592)	It doesn't seem we're using it. Is there a plan to start using it later?

This revision is now accepted and ready to land.Apr 29 2024, 1:18 AM

ginsu added inline comments.May 1 2024, 10:35 PM

lib/types/community-types.js
31 ↗	(On Diff #39592)	Yes we will use this in a subsequent diff that I will introduce. Sorry if this caused any confusion, will make sure that when I work in `keyserver` code + introduce endpoints in the future that my diffs are more clear + less dependent on subsequent diffs