Page MenuHomePhabricator
Differential D12142

Implement JSI for EntryStore
ClosedPublic
Actions

Authored by marcin on May 21 2024, 6:14 AM.
Tags
None
Referenced Files
F2132532: D12142.diff
Thu, Jun 27, 11:15 PM
Unknown Object (File)
Thu, Jun 20, 5:29 PM
Unknown Object (File)
Thu, Jun 20, 5:29 PM
Unknown Object (File)
Thu, Jun 20, 5:29 PM
Unknown Object (File)
Thu, Jun 20, 5:29 PM
Unknown Object (File)
Thu, Jun 20, 5:29 PM
Unknown Object (File)
Thu, Jun 20, 5:26 PM
Unknown Object (File)
Thu, Jun 20, 4:56 PM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM3c0246a0af6b: Implement JSI for EntryStore
Summary

This differential implements EntryStoreOperations and EntryStore

Test Plan

Compile

Diff Detail

Repository
rCOMM Comm
Branch
marcin-tomek/eng-3486
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.May 21 2024, 6:14 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 6:14 AM
marcin added a parent revision: D12138: Implement SQLite API to handle entry store.May 21 2024, 6:15 AM
Harbormaster completed remote builds in B29092: Diff 40456.May 21 2024, 6:35 AM
marcin requested review of this revision.May 21 2024, 6:35 AM
marcin updated this revision to Diff 40464.May 21 2024, 6:55 AM

entry_info -> entry

Harbormaster failed remote builds in B29100: Diff 40464!May 21 2024, 7:32 AM
tomek accepted this revision.May 21 2024, 7:33 AM
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/EntryStoreOperations.h
43

newline

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.h
31

newline

This revision is now accepted and ready to land.May 21 2024, 7:33 AM
marcin added a child revision: D12148: Connect pipes between C++ and JS for entry store.May 21 2024, 7:43 AM
marcin updated this revision to Diff 40475.May 21 2024, 7:47 AM

Rebase

marcin updated this revision to Diff 40479.May 21 2024, 8:02 AM

Fix build failure

Harbormaster failed remote builds in B29108: Diff 40475!May 21 2024, 8:22 AM
Harbormaster completed remote builds in B29112: Diff 40479.May 21 2024, 8:46 AM
marcin updated this revision to Diff 40569.May 22 2024, 8:40 AM

Add newlines

marcin edited the test plan for this revision. (Show Details)May 22 2024, 8:43 AM
Harbormaster completed remote builds in B29198: Diff 40569.May 22 2024, 9:45 AM
Closed by commit rCOMM3c0246a0af6b: Implement JSI for EntryStore (authored by marcin). · Explain WhyMay 27 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM3c0246a0af6b: Implement JSI for EntryStore.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
3 lines
2 lines
17 lines
42 lines
PersistentStorageUtilities/
DataStores/
30 lines
70 lines
ios/
Comm.xcodeproj/
8 lines

Diff 40464

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/EntryStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/EntryStore.cpp

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...