[native] Add a migration that moves entries to SQLite
ClosedPublic
Actions

Authored by tomek on May 21 2024, 8:56 AM.

Details

Reviewers

kamil
marcin

Commits

rCOMM3caaff0d3723: [native] Add a migration that moves entries to SQLite

Summary

This migration saves the entries in SQLite

Depends on D12152

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Killed a keyserver, opened the app - checked the logs, and verified that the migration was run. If the migration hasn't moved the entries successfully, there would be an alert reporting store inconsistencies.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.May 21 2024, 8:56 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 8:56 AM

tomek added a child revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 21 2024, 8:57 AM

tomek added a parent revision: D12152: [lib] Schedule entry store ops processing.

tomek removed a parent revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.May 21 2024, 8:59 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 9:41 AM

Harbormaster failed remote builds in B29122: Diff 40489!

tomek added a child revision: D12162: [lib] Replace merging entries with an ops approach.May 21 2024, 12:23 PM

tomek removed a child revision: D12162: [lib] Replace merging entries with an ops approach.May 21 2024, 12:23 PM

tomek added a child revision: D12162: [lib] Replace merging entries with an ops approach.May 21 2024, 12:28 PM

tomek removed a child revision: D12162: [lib] Replace merging entries with an ops approach.May 21 2024, 12:33 PM

tomek edited the summary of this revision. (Show Details)May 21 2024, 12:42 PM

Rebase

tomek added a child revision: D12162: [lib] Replace merging entries with an ops approach.May 21 2024, 12:44 PM

tomek removed a child revision: D12162: [lib] Replace merging entries with an ops approach.May 21 2024, 12:45 PM

Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 12:57 PM

Harbormaster failed remote builds in B29140: Diff 40508!

Harbormaster completed remote builds in B29140: Diff 40508.May 21 2024, 1:15 PM

tomek requested review of this revision.May 21 2024, 1:15 PM

marcin accepted this revision.May 22 2024, 2:53 AM

marcin added inline comments.

native/redux/persist.js
1310 ↗	(On Diff #40508)	Is this strictly necessary? Not opposed - just curious.

This revision is now accepted and ready to land.May 22 2024, 2:53 AM

tomek removed a child revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 22 2024, 3:48 AM

tomek added a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.

tomek added inline comments.May 22 2024, 4:12 AM

native/redux/persist.js
1310 ↗	(On Diff #40508)	Maybe not necessary, but we're using the same approach in other migrations and I think it is a bit safer.

tomek edited the test plan for this revision. (Show Details)May 22 2024, 4:16 AM

Closed by commit rCOMM3caaff0d3723: [native] Add a migration that moves entries to SQLite (authored by tomek). · Explain WhyMay 27 2024, 5:50 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM3caaff0d3723: [native] Add a migration that moves entries to SQLite.

Revision Contents
Changeset List

Path

Size

native/

redux/

persist.js

36 lines

Diff 40489

View Options

native/redux/persist.js

	Show All 20 Lines
	// eslint-disable-next-line no-unused-vars			// eslint-disable-next-line no-unused-vars
	function SecondaryDeviceQRCodeScanner(props: Props): React.Node {			function SecondaryDeviceQRCodeScanner(props: Props): React.Node {
	const [hasPermission, setHasPermission] = React.useState<?boolean>(null);			const [hasPermission, setHasPermission] = React.useState<?boolean>(null);
	const [scanned, setScanned] = React.useState(false);			const [scanned, setScanned] = React.useState(false);

	const styles = useStyles(unboundStyles);			const styles = useStyles(unboundStyles);
	const navigation = useNavigation();			const navigation = useNavigation();

				const tunnelbrokerContext = useTunnelbroker();
				const identityContext = React.useContext(IdentityClientContext);

				const addDeviceToList = React.useCallback(
				async (newDeviceID: string) => {
				invariant(identityContext, 'identity context not set');
				const { getDeviceListHistoryForUser, updateDeviceList } =
				identityContext.identityClient;
				invariant(
				updateDeviceList,
				'updateDeviceList() should be defined for primary device',
				);

				const authMetadata = await identityContext.getAuthMetadata();
				if (!authMetadata?.userID) {
				throw new Error('missing auth metadata');
				}

				const deviceLists = await getDeviceListHistoryForUser(
				authMetadata.userID,
				);
				const lastSignedDeviceList = deviceLists[deviceLists.length - 1];
				const deviceList: RawDeviceList = JSON.parse(
				lastSignedDeviceList.rawDeviceList,
				);

				const { devices } = deviceList;
				if (!devices.includes(newDeviceID)) {
				const newDeviceList: RawDeviceList = {
				devices: [...devices, newDeviceID],
				timestamp: Date.now(),
				};
				await updateDeviceList({
				rawDeviceList: JSON.stringify(newDeviceList),
				});
				return true;
				} else {
				return false;
				}
				},
				[identityContext],
				);

	React.useEffect(() => {			React.useEffect(() => {
	void (async () => {			void (async () => {
	const { status } = await BarCodeScanner.requestPermissionsAsync();			const { status } = await BarCodeScanner.requestPermissionsAsync();
	setHasPermission(status === 'granted');			setHasPermission(status === 'granted');

	if (status !== 'granted') {			if (status !== 'granted') {
	Alert.alert(			Alert.alert(
	'No access to camera',			'No access to camera',
	'Please allow Comm to access your camera in order to scan the QR code.',			'Please allow Comm to access your camera in order to scan the QR code.',
	[{ text: 'OK' }],			[{ text: 'OK' }],
	);			);

	navigation.goBack();			navigation.goBack();
	}			}
	})();			})();
	}, [navigation]);			}, [navigation]);

	const onConnect = React.useCallback((barCodeEvent: BarCodeEvent) => {			const onConnect = React.useCallback(
				(barCodeEvent: BarCodeEvent) => {
	const { data } = barCodeEvent;			const { data } = barCodeEvent;
	const parsedData = parseDataFromDeepLink(data);			const parsedData = parseDataFromDeepLink(data);
	const keysMatch = parsedData?.data?.keys;			const keysMatch = parsedData?.data?.keys;

	if (!parsedData \|\| !keysMatch) {			if (!parsedData \|\| !keysMatch) {
	Alert.alert(			Alert.alert(
	'Scan failed',			'Scan failed',
	'QR code does not contain a valid pair of keys.',			'QR code does not contain a valid pair of keys.',
	[{ text: 'OK' }],			[{ text: 'OK' }],
	);			);
	return;			return;
	}			}

	const keys = JSON.parse(decodeURIComponent(keysMatch));			const keys = JSON.parse(decodeURIComponent(keysMatch));
				const { aes256, ed25519 } = keys;

				void (async () => {
				try {
				invariant(identityContext, 'identity context not set');
				const { deviceID: primaryDeviceID, userID } =
				await identityContext.getAuthMetadata();
				if (!primaryDeviceID \|\| !userID) {
				throw new Error('missing auth metadata');
				}
				await addDeviceToList(ed25519);
				const message = createQRAuthTunnelbrokerMessage(aes256, {
				type: qrCodeAuthMessageTypes.DEVICE_LIST_UPDATE_SUCCESS,
				userID,
				primaryDeviceID,
				});
				await tunnelbrokerContext.sendMessage({
				deviceID: ed25519,
				payload: JSON.stringify(message),
				});
				} catch (err) {
				console.log('Primary device error:', err);
	Alert.alert(			Alert.alert(
	'Scan successful',			'Adding device failed',
	`QR code contains the following keys: ${JSON.stringify(keys)}`,			'Failed to update the device list',
	[{ text: 'OK' }],			[{ text: 'OK' }],
	);			);
	}, []);			navigation.goBack();
				}
				})();
				},
				[
				tunnelbrokerContext,
				addDeviceToList,
				identityContext,
				navigation,
				],
				);

	const onCancelScan = React.useCallback(() => setScanned(false), []);			const onCancelScan = React.useCallback(() => setScanned(false), []);

	const handleBarCodeScanned = React.useCallback(			const handleBarCodeScanned = React.useCallback(
	(barCodeEvent: BarCodeEvent) => {			(barCodeEvent: BarCodeEvent) => {
	setScanned(true);			setScanned(true);
	Alert.alert(			Alert.alert(
	'Connect with this device?',			'Connect with this device?',
	▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines

[native] Add a migration that moves entries to SQLiteClosedPublicActions