Paths

Table of Contentst

-
lib/reducers/
-
reducers/
2/3
entry-reducer.js

[lib] Migrate remaining actions
ClosedPublic
Actions

Authored by tomek on May 21 2024, 1:00 PM.

Details

Reviewers

kamil
marcin

Commits

rCOMMc71b931f667c: [lib] Migrate remaining actions

Summary

Migrate the actions

Depends on D12163

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

To test changeThreadSettingsActionTypes.success, removeUsersFromThreadActionTypes.success, changeThreadMemberRolesActionTypes.success: Create community as user A, add user B, create entry and delete user B. Check that entry disappears from B database.
To test fetchRevisionsActionType: Click history on a calendar entry on Web.

Diff Detail

Repository

rCOMM Comm

Branch

entries

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.May 21 2024, 1:00 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 1:00 PM

Harbormaster completed remote builds in B29145: Diff 40513.May 21 2024, 1:21 PM

tomek requested review of this revision.May 21 2024, 1:21 PM

tomek added a child revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 22 2024, 3:48 AM

tomek added a child revision: D12169: [web] Replace persisted entries with the ones from initial redux state.May 22 2024, 4:34 AM

tomek removed a child revision: D12153: [native] Persist only lastUserInteractionCalendar from the entry store.May 22 2024, 4:34 AM

marcin added inline comments.May 22 2024, 7:29 AM

lib/reducers/entry-reducer.js
527	Tested works. Tested by restoring on web and seeing that it remains across renders and restarts,
542	Tested works. Tested by seeing that after log in entries populate database and there are no local id entries.

marcin accepted this revision.May 23 2024, 5:27 AM

This revision is now accepted and ready to land.May 23 2024, 5:27 AM

marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:39 AM

marcin edited the test plan for this revision. (Show Details)May 24 2024, 7:52 AM

marcin edited the test plan for this revision. (Show Details)May 24 2024, 8:03 AM

marcin edited the test plan for this revision. (Show Details)May 24 2024, 8:17 AM

Closed by commit rCOMMc71b931f667c: [lib] Migrate remaining actions (authored by tomek). · Explain WhyMay 27 2024, 5:51 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMc71b931f667c: [lib] Migrate remaining actions.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

entry-reducer.js

61 lines

Diff 40513

View Options

lib/reducers/entry-reducer.js

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines	const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID,		creatorID: viewer.userID,
creatorFID: viewerFID,		creatorFID: viewerFID,
targetID: otherUserID,		targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID],		targetFID: request.userIDsToFID[otherUserID],
time: now,		time: now,
operation: 'farcaster_mutual',		operation: 'farcaster_mutual',
}));		}));
await createMessages(viewer, messageDatas, 'broadcast');		await createMessages(viewer, messageDatas, 'broadcast');
		} else if (request.action === relationshipActions.ACKNOWLEDGE) {
		updateIDs.push(...userIDs);

		const insertRows = userIDs.map(userID => {
		const [user1, user2] = sortUserIDs(viewer.userID, userID);
		return { user1, user2, status: undirectedStatus.KNOW_OF };
		});

		const updateDatas = await updateChangedUndirectedRelationships(insertRows);
		inkaAuthorUnsubmitted Done Inline Actions `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because `KNOW_OF` is `0`-the lowest possible value. So we will not override a more meaningful relationship. inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
		tomekUnsubmitted Not Done Inline Actions Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated? tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
		inkaAuthorUnsubmitted Done Inline Actions The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic. We discussed this offline and agreed that this code makes sense and can be left as is. inka: The only thing this function does is checking if the relationship needs to be updated, and if…
		await createUpdates(updateDatas);
} else {		} else {
invariant(		invariant(
false,		false,
`action ${request.action} is invalid or not supported currently`,		`action ${request.action} is invalid or not supported currently`,
);		);
}		}

await createUpdates(		await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines

[lib] Migrate remaining actionsClosedPublicActions