Page MenuHomePhabricator
Differential D12075

[SQLite] remove `deviceID` param when getting all Outbound P2P messages
ClosedPublic
Actions

Authored by kamil on May 16 2024, 7:33 AM.
Tags
None
Referenced Files
F2128943: D12075.diff
Thu, Jun 27, 11:41 AM
Unknown Object (File)
Sun, Jun 23, 4:16 AM
Unknown Object (File)
Wed, Jun 19, 9:12 AM
Unknown Object (File)
Tue, Jun 11, 11:51 AM
Unknown Object (File)
Mon, Jun 10, 10:35 AM
Unknown Object (File)
Mon, Jun 10, 7:13 AM
Unknown Object (File)
Mon, Jun 10, 7:07 AM
Unknown Object (File)
Fri, Jun 7, 7:04 PM
View All 16 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM20a9300d4d38: [SQLite] remove `deviceID` param when getting all Outbound P2P messages
Summary

There is no need to specify deviceID - we want to query and attempt to send all messages (usage later in the stack).

Depends on D12074

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Branch
publish-broadcasting-2
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
3 lines
3 lines
7 lines
web/
shared-worker/
_generated/
queries/
34 lines
types/
4 lines

Diff 40589

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...