Page MenuHomePhabricator
Differential D12147

[lib] Handle setClientDBStoreActionType for entries
ClosedPublic
Actions

Authored by tomek on May 21 2024, 7:30 AM.
Tags
None
Referenced Files
F3375122: D12147.id40476.diff
Tue, Nov 26, 6:26 PM
F3375091: D12147.id40501.diff
Tue, Nov 26, 6:13 PM
Unknown Object (File)
Sat, Nov 23, 3:33 AM
Unknown Object (File)
Fri, Nov 22, 11:24 PM
Unknown Object (File)
Sat, Nov 16, 6:06 AM
Unknown Object (File)
Sun, Nov 10, 4:00 PM
Unknown Object (File)
Sun, Nov 10, 1:53 PM
Unknown Object (File)
Sun, Nov 10, 11:57 AM
View All 98 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Commits
rCOMM8a3e3534159a: [lib] Handle setClientDBStoreActionType for entries
Summary

Handle the action and check if the expected and processed store match

Depends on D12143

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Created some entries, closed the app, killed the keyserver, opened the app, and checked if an alert with store difference wasn't shown.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.May 21 2024, 7:30 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 7:30 AM
tomek updated this revision to Diff 40476.May 21 2024, 7:51 AM

Rebase

tomek updated this revision to Diff 40477.May 21 2024, 7:56 AM

Rebase

Harbormaster completed remote builds in B29105: Diff 40471.May 21 2024, 7:57 AM
Harbormaster failed remote builds in B29109: Diff 40476!May 21 2024, 8:02 AM
tomek added a child revision: D12152: [lib] Schedule entry store ops processing.May 21 2024, 8:11 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 8:39 AM
Harbormaster failed remote builds in B29110: Diff 40477!
tomek updated this revision to Diff 40501.May 21 2024, 12:35 PM

Rebase

Harbormaster completed remote builds in B29133: Diff 40501.May 21 2024, 12:51 PM
tomek requested review of this revision.May 21 2024, 12:51 PM
marcin accepted this revision.May 22 2024, 2:48 AM
marcin added inline comments.
lib/reducers/entry-reducer.js
724 ↗(On Diff #40501)

If we want to proceed with this we need to postpone landing D12153

This revision is now accepted and ready to land.May 22 2024, 2:48 AM
tomek added inline comments.May 22 2024, 3:55 AM
lib/reducers/entry-reducer.js
724 ↗(On Diff #40501)

I moved it to the top of the stack

tomek updated this revision to Diff 40524.May 22 2024, 4:06 AM

Return state from the store

tomek edited the test plan for this revision. (Show Details)May 22 2024, 4:10 AM
Harbormaster completed remote builds in B29153: Diff 40524.May 22 2024, 4:22 AM
Closed by commit rCOMM8a3e3534159a: [lib] Handle setClientDBStoreActionType for entries (authored by tomek). · Explain WhyMay 27 2024, 5:50 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM8a3e3534159a: [lib] Handle setClientDBStoreActionType for entries.
ashoat mentioned this in D12177: [lib] Stop checking for entry store inconsistencies.May 28 2024, 12:06 PM

Revision Contents
Changeset List

PathSize
lib/
reducers/
52 lines
2 lines

Diff 40662

View Options

lib/reducers/entry-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...