Page MenuHomePhabricator
Differential D12294

[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 11:59 PM
Unknown Object (File)
Wed, Apr 16, 4:46 PM
Unknown Object (File)
Wed, Apr 16, 2:09 PM
Unknown Object (File)
Wed, Apr 16, 7:16 AM
Unknown Object (File)
Wed, Apr 16, 3:15 AM
Unknown Object (File)
Mon, Apr 14, 10:12 PM
Unknown Object (File)
Mon, Apr 14, 11:32 AM
Unknown Object (File)
Tue, Apr 8, 5:05 PM
View All 94 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMM67a5bdca2dc0: [lib] Remove `skipMemberAdminRoleCheck` option from…
Summary

Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook

Depends on D12293

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
17 lines

Diff 40903

View Options

lib/shared/thread-utils.js

Loading...