Page MenuHomePhabricator

[native] update EnumSettingsOption UI
ClosedPublic

Authored by ginsu on Jul 3 2024, 5:41 PM.
Tags
None
Referenced Files
F3582200: D12654.id42070.diff
Sun, Dec 29, 11:35 AM
F3582130: D12654.id41975.diff
Sun, Dec 29, 11:11 AM
F3575282: D12654.diff
Sat, Dec 28, 6:40 PM
Unknown Object (File)
Fri, Dec 27, 10:50 PM
Unknown Object (File)
Nov 11 2024, 6:47 AM
Unknown Object (File)
Nov 11 2024, 6:13 AM
Unknown Object (File)
Nov 11 2024, 6:13 AM
Unknown Object (File)
Nov 10 2024, 7:30 PM
Subscribers

Details

Summary

This diff updates the EnumSettingsOption UI to better match the web version of EnumSettingsOption. One big notable change with EnumSettingsOption is that the entire surface is now a touchable rather than just the input. This also matches the behavior we have on web.

Depends on D12653

Test Plan

Please see the demo videos below of all the places we use this component

Create community:
Before:

After:

Create Role:

Before:

After:

Thread notifs settings:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2024, 5:59 PM
Harbormaster failed remote builds in B30104: Diff 41975!
Harbormaster completed remote builds in B30103: Diff 41974.
ginsu requested review of this revision.Jul 3 2024, 6:28 PM
ashoat added inline comments.
native/roles/create-roles-screen.react.js
312–313 ↗(On Diff #41975)

Should we make similar changes for the community creation flow? It looks a bit scrunched up in the video

This revision is now accepted and ready to land.Jul 3 2024, 8:19 PM
ginsu edited the test plan for this revision. (Show Details)

address comments + rebase before landing

This revision was automatically updated to reflect the committed changes.