Page MenuHomePhabricator
Differential D12664

[lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT
ClosedPublic
Actions

Authored by ginsu on Jul 3 2024, 10:46 PM.
Tags
None
Referenced Files
F2903465: D12664.diff
Sat, Oct 5, 10:27 PM
Unknown Object (File)
Wed, Sep 25, 8:51 PM
Unknown Object (File)
Wed, Sep 25, 8:50 PM
Unknown Object (File)
Fri, Sep 6, 3:55 PM
Unknown Object (File)
Sep 5 2024, 6:41 PM
Unknown Object (File)
Sep 5 2024, 6:40 PM
Unknown Object (File)
Sep 5 2024, 6:39 PM
Unknown Object (File)
Sep 5 2024, 6:19 AM
View All 41 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMM17786b62ab07: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT
Summary

Addresses inline feedback from D12648

Depends on D12663

Test Plan

Confirm copy was updated

Diff Detail

Repository
rCOMM Comm
Branch
eng-8010 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 3 2024, 10:46 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 3 2024, 10:46 PM
ginsu mentioned this in D12648: [native] introduce NotificationDescription.Jul 3 2024, 10:47 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu added a parent revision: D12663: [native] update thread notif settings ui to handle case when parent thread is in background.
Harbormaster completed remote builds in B30128: Diff 41999.Jul 3 2024, 11:01 PM
ginsu requested review of this revision.Jul 3 2024, 11:01 PM
ginsu added a child revision: D12665: [native] update ThreadSettingsPushNotifs to use new thread notifs settings experience.Jul 4 2024, 12:18 AM
ashoat accepted this revision.Jul 4 2024, 6:31 AM

Nit: I figure we can leave badgeOnly around since we use it from the notifs code, but the badgeCount and BADGE_COUNT stuff could be renamed for consistency

native/chat/settings/thread-settings-notifications.react.js
89–94

Should this be renamed?

110

Should this be renamed?

This revision is now accepted and ready to land.Jul 4 2024, 6:31 AM
ginsu updated this revision to Diff 42058.Jul 4 2024, 11:11 AM

address comments + rebase before landing

This revision was landed with ongoing or failed builds.Jul 4 2024, 11:21 AM
Closed by commit rCOMM17786b62ab07: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM17786b62ab07: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT.
Harbormaster completed remote builds in B30166: Diff 42058.Jul 4 2024, 12:01 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
2 lines
native/
chat/
settings/
2 lines
web/
modals/
threads/
notifications/
6 lines

Diff 41999

View Options

lib/shared/thread-settings-notifications-utils.js

Loading...
View Options

native/chat/settings/thread-settings-notifications.react.js

Loading...
View Options

web/modals/threads/notifications/notifications-modal.react.js

Loading...