Details

Reviewers

tomek
kamil
marcin

Commits

rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table

Summary

issue: ENG-8825

Test Plan

Called sqliteQueryExecutor.updateMessageSearchResult and veryfied that updateMessageSearchResult was called

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 17 2024, 11:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 17 2024, 11:50 AM

inka added a parent revision: D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.Jul 17 2024, 11:50 AM

Harbormaster completed remote builds in B30407: Diff 42378.Jul 17 2024, 12:07 PM

inka requested review of this revision.Jul 17 2024, 12:07 PM

tomek accepted this revision.Jul 17 2024, 2:03 PM

This revision is now accepted and ready to land.Jul 17 2024, 2:03 PM

Rebase

Rename to updateMessageSearchIndex

Harbormaster completed remote builds in B30460: Diff 42459.Jul 18 2024, 12:15 PM

Harbormaster failed remote builds in B30464: Diff 42463!Jul 18 2024, 12:42 PM

Update wasm

Harbormaster completed remote builds in B30467: Diff 42466.Jul 18 2024, 1:15 PM

inka added a child revision: D12794: [native] Add MessageSearchStoreOperations.Jul 18 2024, 3:05 PM

Rename fix

Harbormaster completed remote builds in B30477: Diff 42476.Jul 18 2024, 3:52 PM

kamil accepted this revision.Jul 19 2024, 11:57 AM

Rebase

Harbormaster failed remote builds in B30556: Diff 42603!Jul 22 2024, 7:40 AM

Rebase

Harbormaster completed remote builds in B30568: Diff 42619.Jul 22 2024, 3:32 PM

Harbormaster completed remote builds in B30556: Diff 42603.Jul 23 2024, 6:36 AM

wasm

Harbormaster completed remote builds in B30588: Diff 42657.Jul 23 2024, 8:48 AM

Closed by commit rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table. · Explain WhyJul 23 2024, 9:44 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table.

[web] Add bindings for inserting into the search table
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42466

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/types/sqlite-query-executor.js

[web] Add bindings for inserting into the search tableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42466

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/types/sqlite-query-executor.js

[web] Add bindings for inserting into the search table
ClosedPublic
Actions

Revision Contents
Changeset List