Page MenuHomePhabricator
Differential D12788

[lib] Introduce `stripMemberPermissionsFromRawThreadInfos`
ClosedPublic
Actions

Authored by atul on Jul 17 2024, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 7:53 PM
Unknown Object (File)
Thu, Oct 31, 8:32 AM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
View All 75 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMb84a90848053: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`
Summary

This is the migrationFunc that will be consumed by createUpdateDBOpsForThreadStoreThreadInfos for the client migrations.

Depends on D12779

Test Plan

Included basic unit test. Will also be tested as part of native and web migrations.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12788 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jul 17 2024, 3:34 PM
Harbormaster completed remote builds in B30445: Diff 42425.Jul 17 2024, 3:51 PM
atul requested review of this revision.Jul 17 2024, 3:51 PM
atul added a child revision: D12789: [native] Introduce `native` migration to strip member permissions.Jul 17 2024, 4:02 PM
ashoat requested changes to this revision.Jul 18 2024, 12:04 PM
ashoat added inline comments.
lib/utils/member-info-utils.js
45 ↗(On Diff #42425)

I don't understand why this any-cast is necessary – isn't rawThreadInfo already a ThinRawThreadInfoWithPermissions?

Did you perhaps forget to remove the any-cast before diffing this up?

This revision now requires changes to proceed.Jul 18 2024, 12:04 PM
atul updated this revision to Diff 42479.Jul 18 2024, 12:08 PM

remove extraneous any-cast

atul added a comment.Jul 18 2024, 12:09 PM

Did you perhaps forget to remove the any-cast before diffing this up?

Yeah, I narrowed type of stripMemberPermissionsFromRawThreadInfos and should've removed any-cast after.

ashoat accepted this revision.Jul 18 2024, 12:13 PM
This revision is now accepted and ready to land.Jul 18 2024, 12:13 PM
Harbormaster completed remote builds in B30479: Diff 42479.Jul 18 2024, 12:25 PM
atul updated this revision to Diff 42489.Jul 18 2024, 12:41 PM

rebase

Harbormaster completed remote builds in B30487: Diff 42489.Jul 18 2024, 1:13 PM
atul updated this revision to Diff 42500.Jul 18 2024, 2:18 PM

rebase BEFORE re-removing any-cast

atul updated this revision to Diff 42501.Jul 18 2024, 2:20 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 18 2024, 2:28 PM
Closed by commit rCOMMb84a90848053: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb84a90848053: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
Harbormaster completed remote builds in B30494: Diff 42500.Jul 18 2024, 2:34 PM
Harbormaster completed remote builds in B30495: Diff 42501.

Revision Contents
Changeset List

Diff 42501

View Options

lib/utils/member-info-utils-test-data.js

Loading...
View Options

lib/utils/member-info-utils.js

Loading...
View Options

lib/utils/member-info-utils.test.js

Loading...