Details

Reviewers

tomek
kamil
marcin

Commits

rCOMMd41f5271dfed: [native] Add message search store

Summary

issue: ENG-8831

Test Plan

Tested with the next diff. Added an "add search message" operation on the js side and tested that updateMessageSearchIndex was run and no errors showed up in Metro nor in XCode console

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 18 2024, 8:08 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 18 2024, 8:08 AM

inka added a parent revision: D12794: [native] Add MessageSearchStoreOperations.Jul 18 2024, 8:08 AM

inka added a child revision: D12796: [native] Add CommCoreModule code for inserting into the search table.

Harbormaster completed remote builds in B30472: Diff 42471.Jul 18 2024, 8:24 AM

inka requested review of this revision.Jul 18 2024, 8:24 AM

inka added inline comments.Jul 19 2024, 2:59 AM

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp
9 ↗	(On Diff #42471)	I will rename insert to update

marcin added inline comments.Jul 19 2024, 3:32 AM

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp
16 ↗	(On Diff #42471)	I might be missing something but I am confused why this function doesn't do anything. If it is intended to always return empty array then it is a good practice to declare `jsiSearchMessages` as static to avoid recomputing this variable upon each call to this function.

You need to add this to Cmake - example in D11509

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp
16 ↗	(On Diff #42471)	It will return - it's just not yet implemented
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.h
5 ↗	(On Diff #42471)	Is it needed?