issue: ENG-8831
Details
Details
- Reviewers
tomek kamil marcin - Commits
- rCOMMd41f5271dfed: [native] Add message search store
Tested with the next diff. Added an "add search message" operation on the js side and tested that updateMessageSearchIndex was run and no errors showed up in Metro nor in XCode console
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp | ||
|---|---|---|
| 9 ↗ | (On Diff #42471) | I will rename insert to update |
| native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp | ||
|---|---|---|
| 16 ↗ | (On Diff #42471) | I might be missing something but I am confused why this function doesn't do anything. If it is intended to always return empty array then it is a good practice to declare jsiSearchMessages as static to avoid recomputing this variable upon each call to this function. |
Comment Actions
You need to add this to Cmake - example in D11509
| native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp | ||
|---|---|---|
| 16 ↗ | (On Diff #42471) | It will return - it's just not yet implemented |
| native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.h | ||
| 5 ↗ | (On Diff #42471) | Is it needed? |
| native/cpp/CommonCpp/DatabaseManagers/entities/MessageSearchResult.h | ||
|---|---|---|
| 29 ↗ | (On Diff #42471) | Newline |
| native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.h | ||
|---|---|---|
| 5 ↗ | (On Diff #42471) | Yes, in the cpp file |