Page MenuHomePhabricator

[web][keyserver] Use entries from the initial state only if they are missing from the store
ClosedPublic

Authored by tomek on May 22 2024, 4:41 AM.
Tags
None
Referenced Files
F3345013: D12170.id42688.diff
Fri, Nov 22, 5:06 AM
Unknown Object (File)
Sun, Nov 10, 11:48 AM
Unknown Object (File)
Sun, Nov 10, 7:39 AM
Unknown Object (File)
Sun, Nov 10, 7:04 AM
Unknown Object (File)
Sun, Nov 10, 4:20 AM
Unknown Object (File)
Sun, Nov 10, 1:38 AM
Unknown Object (File)
Mon, Nov 4, 7:26 AM
Unknown Object (File)
Fri, Nov 1, 7:20 PM
Subscribers

Details

Summary

This is the last step of the migration - we should no longer use the values returned from the initial Redux state.

Depends on D12153

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Test Plan

Closed and opened the app (both native and web) - the entries aren't sent from the keyserver so doing this verified if they are correctly persisted and rehydrated.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.May 22 2024, 4:58 AM
This revision is now accepted and ready to land.May 22 2024, 7:17 AM
keyserver/src/responders/redux-state-responders.js
223 ↗(On Diff #40527)

We still should return this because we don't persist it on web

keyserver/src/responders/redux-state-responders.js
223 ↗(On Diff #40527)

If it's always 0, is it something we can just insert automatically on the web side?

keyserver/src/responders/redux-state-responders.js
223 ↗(On Diff #40527)

Yes, that makes sense!

keyserver/src/responders/redux-state-responders.js
223 ↗(On Diff #40527)

We insert this value on the web automatically by having it in the defaultWebState. Here we still should return this value so that the finalEntryStorePromise returns Promise<EntryStore>.