Paths

Table of Contentst

[native] Persist only lastUserInteractionCalendar from the entry store
ClosedPublic
Actions

Authored by tomek on May 21 2024, 8:27 AM.

Details

Reviewers

kamil
marcin

Commits

rCOMMbb0f4743a386: [native] Persist only lastUserInteractionCalendar from the entry store

Summary

We keep this field in redux-persist. EntryInfos are stored in SQLite, and daysToEntries are computed based on the entries.

Depends on D12169

https://linear.app/comm/issue/ENG-3486/move-entrystore-to-sqlite

Note: this diff should be landed when we are sure that the migration to SQLite was successful

Test Plan

Added some console logs and checked if lastUserInteractionCalendar is persisted and rehydrated.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 21 2024, 8:27 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2024, 8:27 AM

tomek added a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.May 21 2024, 8:49 AM

tomek removed a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.May 21 2024, 8:56 AM

tomek edited parent revisions, added: D12157: [native] Add a migration that moves entries to SQLite; removed: D12152: [lib] Schedule entry store ops processing.

tomek added a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.May 21 2024, 8:59 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 21 2024, 9:11 AM

Harbormaster failed remote builds in B29116: Diff 40483!

tomek edited the summary of this revision. (Show Details)May 21 2024, 12:42 PM

Rebase

Harbormaster completed remote builds in B29141: Diff 40509.May 21 2024, 1:02 PM

tomek requested review of this revision.May 21 2024, 1:02 PM

marcin mentioned this in D12147: [lib] Handle setClientDBStoreActionType for entries.May 22 2024, 2:48 AM

Accepting but for now we have to hold this diff.

This revision is now accepted and ready to land.May 22 2024, 3:01 AM

tomek removed a child revision: D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.May 22 2024, 3:48 AM

tomek edited parent revisions, added: D12164: [lib] Migrate remaining actions; removed: D12157: [native] Add a migration that moves entries to SQLite.

tomek edited the summary of this revision. (Show Details)

tomek edited the summary of this revision. (Show Details)May 22 2024, 4:34 AM

tomek added a parent revision: D12169: [web] Replace persisted entries with the ones from initial redux state.

tomek removed a parent revision: D12164: [lib] Migrate remaining actions.

tomek edited the summary of this revision. (Show Details)

tomek added a child revision: D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.May 22 2024, 4:41 AM

Rebase

tomek edited the test plan for this revision. (Show Details)Jul 23 2024, 3:59 AM

Harbormaster completed remote builds in B30602: Diff 42677.Jul 23 2024, 4:10 AM

Closed by commit rCOMMbb0f4743a386: [native] Persist only lastUserInteractionCalendar from the entry store (authored by tomek). · Explain WhyJul 23 2024, 5:57 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMbb0f4743a386: [native] Persist only lastUserInteractionCalendar from the entry store.

Revision Contents
Changeset List

Path

Size

native/

redux/

persist.js

15 lines

Diff 42687

View Options

[native] Persist only lastUserInteractionCalendar from the entry storeClosedPublicActions