[native] Move render and constructor
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:12 AM.

Details

Reviewers

tomek
will

Commits

rCOMM1d7de47034d9: [native] Move render and constructor

Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository

rCOMM Comm

Branch

inka/nux

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 5 2024, 6:12 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:12 AM

inka added a parent revision: D12985: [native] Inline code in NUXTipsOverlay.Aug 5 2024, 6:13 AM

Harbormaster completed remote builds in B30934: Diff 43122.Aug 5 2024, 9:14 AM

inka requested review of this revision.Aug 5 2024, 9:14 AM

Great work on this!! You made the diff stack really easy to review

In D12986#367417, @ashoat wrote:

Great work on this!! You made the diff stack really easy to review

Strongly agree!

This revision is now accepted and ready to land.Aug 6 2024, 2:40 AM

Rebsae

inka added a child revision: D13062: [native] Turn MenuComponent into text.Aug 13 2024, 8:04 AM

Harbormaster completed remote builds in B31070: Diff 43356.Aug 13 2024, 8:14 AM

Closed by commit rCOMM1d7de47034d9: [native] Move render and constructor (authored by inka). · Explain WhyAug 19 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM1d7de47034d9: [native] Move render and constructor.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

165 lines

Diff 43122

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Move render and constructorClosedPublicActions