[native] Move buttonStyle
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:03 AM.

Details

Reviewers

tomek
will

Commits

rCOMMe8fce78e4e69: [native] Move buttonStyle

Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 5 2024, 6:03 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:03 AM

inka added a parent revision: D12978: [native] Move opacityStyle.Aug 5 2024, 6:11 AM

inka added a child revision: D12980: [native] Move onTipContainerLayout.

Harbormaster completed remote builds in B30926: Diff 43114.Aug 5 2024, 8:14 AM

inka requested review of this revision.Aug 5 2024, 8:14 AM

tomek accepted this revision.Aug 6 2024, 2:20 AM

tomek added inline comments.

native/tooltip/nux-tips-overlay.react.js
309 ↗	(On Diff #43114)	We can make this a little more efficient by using more specific dependencies (`initialCoordinates` and `verticalBounds`).

This revision is now accepted and ready to land.Aug 6 2024, 2:20 AM

Address review

Harbormaster completed remote builds in B31065: Diff 43343.Aug 13 2024, 6:54 AM

Closed by commit rCOMMe8fce78e4e69: [native] Move buttonStyle (authored by inka). · Explain WhyAug 13 2024, 7:46 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMe8fce78e4e69: [native] Move buttonStyle.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

29 lines

Diff 43343

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Move buttonStyleClosedPublicActions