Page MenuHomePhabricator
Differential D12983

[native] Move tipContainerStyle
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:09 AM.
Tags
None
Referenced Files
F3499470: D12983.diff
Thu, Dec 19, 11:14 PM
Unknown Object (File)
Nov 9 2024, 11:38 PM
Unknown Object (File)
Nov 9 2024, 8:28 PM
Unknown Object (File)
Nov 8 2024, 11:06 PM
Unknown Object (File)
Nov 8 2024, 12:24 PM
Unknown Object (File)
Nov 6 2024, 11:17 PM
Unknown Object (File)
Oct 18 2024, 9:47 PM
Unknown Object (File)
Oct 18 2024, 9:38 PM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM0c9ed621cf86: [native] Move tipContainerStyle
Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 5 2024, 6:09 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:09 AM
inka added a parent revision: D12982: [native] Move tipScale, tipHorizontal.Aug 5 2024, 6:12 AM
inka added a child revision: D12984: [native] Remove unused variables.
Harbormaster completed remote builds in B30931: Diff 43119.Aug 5 2024, 8:51 AM
inka requested review of this revision.Aug 5 2024, 8:51 AM
tomek accepted this revision.Aug 6 2024, 2:33 AM
tomek added inline comments.
native/tooltip/nux-tips-overlay.react.js
143–144 ↗(On Diff #43119)

After tipContainerStyle got moved, some of the props are no longer being used. I'm assuming it was done later in the stack.

340 ↗(On Diff #43119)
This revision is now accepted and ready to land.Aug 6 2024, 2:33 AM
tomek added inline comments.Aug 6 2024, 2:34 AM
native/tooltip/nux-tips-overlay.react.js
143–144 ↗(On Diff #43119)

It was done in D12985.

inka updated this revision to Diff 43354.Aug 13 2024, 7:51 AM

Address review

Harbormaster completed remote builds in B31068: Diff 43354.Aug 13 2024, 8:08 AM
Closed by commit rCOMM0c9ed621cf86: [native] Move tipContainerStyle (authored by inka). · Explain WhyAug 19 2024, 1:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM0c9ed621cf86: [native] Move tipContainerStyle.

Revision Contents
Changeset List

PathSize
native/
tooltip/
85 lines

Diff 43354

View Options

native/tooltip/nux-tips-overlay.react.js

Loading...