[native] Inline code in NUXTipsOverlay
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:11 AM.

Tags

None

Referenced Files

	F3234169: D12985.id43121.diff
	Tue, Nov 12, 5:36 PM

	F3234098: D12985.id43355.diff
	Tue, Nov 12, 5:19 PM

	Unknown Object (File)
	Sun, Nov 10, 12:01 AM

	Unknown Object (File)
	Sat, Nov 9, 11:38 PM

	Unknown Object (File)
	Fri, Nov 8, 11:06 PM

	Unknown Object (File)
	Fri, Nov 8, 12:24 PM

	Unknown Object (File)
	Wed, Nov 6, 11:17 PM

	Unknown Object (File)
	Sun, Nov 3, 9:38 PM

View All 62 Files

Subscribers

ashoat

Details

Reviewers

tomek
will

Commits

rCOMM8ba14cd37616: [native] Inline code in NUXTipsOverlay

Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Aug 5 2024, 6:11 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:11 AM

inka added a parent revision: D12984: [native] Remove unused variables.Aug 5 2024, 6:13 AM

inka added a child revision: D12986: [native] Move render and constructor.

Harbormaster completed remote builds in B30933: Diff 43121.Aug 5 2024, 9:06 AM

inka requested review of this revision.Aug 5 2024, 9:06 AM

tomek accepted this revision.Aug 6 2024, 2:34 AM

tomek mentioned this in D12983: [native] Move tipContainerStyle.

This revision is now accepted and ready to land.Aug 6 2024, 2:36 AM

Rebase

Harbormaster completed remote builds in B31069: Diff 43355.Aug 13 2024, 8:09 AM

Closed by commit rCOMM8ba14cd37616: [native] Inline code in NUXTipsOverlay (authored by inka). · Explain WhyAug 19 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM8ba14cd37616: [native] Inline code in NUXTipsOverlay.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

53 lines

Diff 43433

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Inline code in NUXTipsOverlayClosedPublicActions