Page MenuHomePhabricator

[lib] update `useProcessDMOperation` to use `DMOperationSpecification`
ClosedPublic

Authored by kamil on Aug 23 2024, 4:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 3:09 PM
Unknown Object (File)
Wed, Sep 25, 12:05 AM
Unknown Object (File)
Fri, Sep 20, 7:18 AM
Unknown Object (File)
Sep 15 2024, 10:53 AM
Unknown Object (File)
Sep 15 2024, 9:30 AM
Unknown Object (File)
Sep 13 2024, 11:57 AM
Unknown Object (File)
Sep 9 2024, 11:06 PM
Unknown Object (File)
Sep 9 2024, 2:58 PM
Subscribers

Details

Summary

ENG-8423.

In this hook, we need to generate OutboundP2PMessages to save this in DB in the same SQL transaction to handle cases when the app crashes after applying changes to our store and before addressing messages to other peers - this is inconsistency from which we're unable to heal.

Depends on D13145

Test Plan

Flow

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 23 2024, 7:24 AM
tomek added inline comments.
lib/shared/dm-ops/dm-ops-queue-handler.react.js
64

It might be a good idea to explain in a code comment why it is guaranteed to be an inbound.

This revision is now accepted and ready to land.Aug 26 2024, 1:49 AM