[lib] update `processDMOpsActionType` to handle `outboundP2PMessages`
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:05 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM8d305bcfcb5c: [lib] update `processDMOpsActionType` to handle `outboundP2PMessages`

Summary

ENG-8423.

We need to process DM Operations and save OutboundP2PMessages in DB in the same SQL transaction to handle cases when the app crashes after applying changes to our store and before addressing messages to other peers - this is inconsistency from which we're unable to heal.

Depends on D13146

Test Plan

Tested in next diff.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 23 2024, 5:05 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 5:05 AM

kamil retitled this revision from [lib] update `queueDMOpsActionType` and `processDMOpsActionType` to handle `outboundP2PMessages` to [lib] update `processDMOpsActionType` to handle `outboundP2PMessages`.Aug 23 2024, 5:06 AM

kamil added a child revision: D13149: [lib] move generating P2P messages to `useProcessDMOperation`.Aug 23 2024, 5:10 AM

Harbormaster completed remote builds in B31232: Diff 43605.Aug 23 2024, 5:22 AM

kamil published this revision for review.Aug 23 2024, 7:24 AM

tomek accepted this revision.Aug 26 2024, 1:55 AM

tomek added inline comments.