Page MenuHomePhabricator
Differential D13151

[lib] deprecate `sendDMOperation` and implement method to create sending promise
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:19 AM.
Tags
None
Referenced Files
F3193602: D13151.id43634.diff
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 2:29 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Sat, Oct 19, 2:33 PM
Unknown Object (File)
Sat, Oct 19, 2:33 PM
Unknown Object (File)
Sat, Oct 19, 2:32 PM
Unknown Object (File)
Oct 2 2024, 2:55 AM
Unknown Object (File)
Sep 25 2024, 3:09 PM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM1bd677c10966: [lib] deprecate `sendDMOperation` and implement method to create sending promise
Summary

ENG-8423.

We still need promise to be resolved after sending messages, but generating messages was moved to processDMOps.

Returning promise to later in that stack put it to dispatchActionPromise.

useProcessAndSendDMOperation looks no obsolete, but will be updated later in the stack.

Depends on D13150

Test Plan

Call getDMOpsSendingPromise and check if it works.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 23 2024, 5:19 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 5:19 AM
kamil added a child revision: D13152: [lib] introduce `DispatchMetadata` for Inbound and Outbound actions.Aug 23 2024, 5:24 AM
Harbormaster completed remote builds in B31235: Diff 43608.Aug 23 2024, 5:35 AM
kamil published this revision for review.Aug 23 2024, 7:25 AM
tomek accepted this revision.Aug 26 2024, 3:30 AM
tomek added inline comments.
lib/shared/dm-ops/process-dm-ops.js
187–197

At this point, it is equivalent to

const useProcessAndSendDMOperation = useProcessDMOperation;

But it doesn't matter because it is updated later in the stack.

This revision is now accepted and ready to land.Aug 26 2024, 3:30 AM
kamil updated this revision to Diff 43634.Aug 26 2024, 6:31 AM

rebase

Harbormaster failed remote builds in B31259: Diff 43634!Aug 26 2024, 6:45 AM
Harbormaster completed remote builds in B31259: Diff 43634.Aug 26 2024, 7:01 AM
Closed by commit rCOMM1bd677c10966: [lib] deprecate `sendDMOperation` and implement method to create sending promise (authored by kamil). · Explain WhyAug 26 2024, 9:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM1bd677c10966: [lib] deprecate `sendDMOperation` and implement method to create sending promise.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
5 lines
tunnelbroker/
57 lines

Diff 43608

View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...