Page MenuHomePhabricator
Differential D13169

[lib] add `supportsAutoRetry` to `DMOperationSpec`
ClosedPublic
Actions

Authored by kamil on Aug 26 2024, 7:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Wed, Feb 26, 9:44 AM
Unknown Object (File)
Feb 17 2025, 3:32 PM
Unknown Object (File)
Jan 15 2025, 7:21 AM
Unknown Object (File)
Jan 5 2025, 4:23 AM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM0c797216d0f2: [lib] add `supportsAutoRetry` to `DMOperationSpec`
Summary

ENG-8423.

This addresses https://phab.comm.dev/D13154#inline-75950.

Depends on D13153

Test Plan

Tested later in the stack.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 43653

View Options

lib/shared/dm-ops/add-members-spec.js

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Lines tShape({
sourceMessageID: tID, sourceMessageID: tID,
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
tShape({ tShape({
type: tNumEnum([ type: tNumEnum([
threadTypes.COMMUNITY_OPEN_SUBTHREAD, threadTypes.COMMUNITY_OPEN_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_SUBTHREAD, threadTypes.COMMUNITY_SECRET_SUBTHREAD,
threadTypes.GENESIS_PERSONAL, threadTypes.GENESIS_PERSONAL,
threadTypes.LOCAL,
threadTypes.COMMUNITY_ROOT, threadTypes.COMMUNITY_ROOT,
threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT, threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT,
threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD,
]), ]),
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
]); ]);
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Lines tShape({
sourceMessageID: tID, sourceMessageID: tID,
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
tShape({ tShape({
type: tNumEnum([ type: tNumEnum([
threadTypes.COMMUNITY_OPEN_SUBTHREAD, threadTypes.COMMUNITY_OPEN_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_SUBTHREAD, threadTypes.COMMUNITY_SECRET_SUBTHREAD,
threadTypes.GENESIS_PERSONAL, threadTypes.GENESIS_PERSONAL,
threadTypes.LOCAL,
threadTypes.COMMUNITY_ROOT, threadTypes.COMMUNITY_ROOT,
threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT, threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT,
threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD,
]), ]),
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
]); ]);
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/change-thread-settings-and-add-viewer-spec.js

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Lines tShape({
sourceMessageID: tID, sourceMessageID: tID,
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
tShape({ tShape({
type: tNumEnum([ type: tNumEnum([
threadTypes.COMMUNITY_OPEN_SUBTHREAD, threadTypes.COMMUNITY_OPEN_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_SUBTHREAD, threadTypes.COMMUNITY_SECRET_SUBTHREAD,
threadTypes.GENESIS_PERSONAL, threadTypes.GENESIS_PERSONAL,
threadTypes.LOCAL,
threadTypes.COMMUNITY_ROOT, threadTypes.COMMUNITY_ROOT,
threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT, threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT,
threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD,
]), ]),
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
]); ]);
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Lines tShape({
sourceMessageID: tID, sourceMessageID: tID,
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
tShape({ tShape({
type: tNumEnum([ type: tNumEnum([
threadTypes.COMMUNITY_OPEN_SUBTHREAD, threadTypes.COMMUNITY_OPEN_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_SUBTHREAD, threadTypes.COMMUNITY_SECRET_SUBTHREAD,
threadTypes.GENESIS_PERSONAL, threadTypes.GENESIS_PERSONAL,
threadTypes.LOCAL,
threadTypes.COMMUNITY_ROOT, threadTypes.COMMUNITY_ROOT,
threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT, threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT,
threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_OPEN_ANNOUNCEMENT_SUBTHREAD,
threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD, threadTypes.COMMUNITY_SECRET_ANNOUNCEMENT_SUBTHREAD,
]), ]),
...threadRequestValidationShape, ...threadRequestValidationShape,
}), }),
]); ]);
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/leave-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...
View Options

lib/shared/dm-ops/send-edit-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...