Paths

Table of Contentst

Differential D13156

[lib] implement sending DM messages with tracking of success/failures
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:47 AM.

Tags

None

Referenced Files

	F3242240: D13156.id43641.diff
	Wed, Nov 13, 8:20 PM

	Unknown Object (File)
	Tue, Nov 12, 4:04 PM

	Unknown Object (File)
	Fri, Nov 8, 11:06 PM

	Unknown Object (File)
	Fri, Nov 8, 2:29 AM

	Unknown Object (File)
	Fri, Oct 25, 2:50 PM

	Unknown Object (File)
	Fri, Oct 25, 2:37 AM

	Unknown Object (File)
	Thu, Oct 24, 7:01 PM

	Unknown Object (File)
	Thu, Oct 24, 6:45 PM

View All 44 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMMdf73af8c96df: [lib] implement sending DM messages with tracking of success/failures

Summary

Wrapping everything, processing message, and queueing on Tunnelbroker in one hook. In future this should also support Multimedia messages.

Depends on D13155

Test Plan

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 23 2024, 5:47 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 5:47 AM

kamil added a child revision: D13157: [lib] add passing DM operation ID when dispatching action.Aug 23 2024, 5:49 AM

Harbormaster completed remote builds in B31240: Diff 43613.Aug 23 2024, 6:04 AM

kamil added a child revision: D13160: [lib] implement sending DM text messages.Aug 23 2024, 7:01 AM

kamil removed a child revision: D13160: [lib] implement sending DM text messages.Aug 23 2024, 7:02 AM

kamil published this revision for review.Aug 23 2024, 7:27 AM

tomek accepted this revision.Aug 26 2024, 5:14 AM

tomek added inline comments.

lib/shared/dm-ops/process-dm-ops.js
212–213 ↗	(On Diff #43613)	At this point, it doesn't work, because these aren't related in any way, but it is fixed in the next diff.

This revision is now accepted and ready to land.Aug 26 2024, 5:14 AM

rebase

Harbormaster completed remote builds in B31266: Diff 43641.Aug 26 2024, 7:45 AM

Closed by commit rCOMMdf73af8c96df: [lib] implement sending DM messages with tracking of success/failures (authored by kamil). · Explain WhyAug 26 2024, 9:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMdf73af8c96df: [lib] implement sending DM messages with tracking of success/failures.

A little confused reading this code, as it's unclear to me how supportsAutoRetry specs get sent

Included a couple nits since I'm already asking for a follow-up diff

lib/shared/dm-ops/process-dm-ops.js
216	Wondering why we have this `!supportsAutoRetry` condition here. Is the idea that `!supportsAutoRetry` need to be manually sent when `processAndSendDMOperation` is called, whereas `supportsAutoRetry` gets automatically sent by some other mechanism? If so, it would be good to add a code comment explaining this, and pointing to the other mechanism.
218	Nit: invert condition to reduce indentation
219	Nit

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

process-dm-ops.js

35 lines

Diff 43656

lib/shared/dm-ops/process-dm-ops.js

Loading...