Page MenuHomePhabricator
Differential D13099

[lib] add getFCAvatarURLs method to NeynarClientProvider
ClosedPublic
Actions

Authored by varun on Aug 15 2024, 10:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 11:32 AM
Unknown Object (File)
Sat, Apr 19, 2:19 AM
Unknown Object (File)
Fri, Apr 18, 10:23 PM
Unknown Object (File)
Wed, Apr 16, 2:52 PM
Unknown Object (File)
Wed, Apr 16, 11:34 AM
Unknown Object (File)
Wed, Apr 16, 11:17 AM
Unknown Object (File)
Wed, Apr 16, 7:38 AM
Unknown Object (File)
Wed, Apr 16, 5:35 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
tomek
Commits
rCOMM360954426fa1: [lib] add getFCAvatarURLs method to NeynarClientProvider
Summary

Based this off the existing client provider method for FC usernames

Deduping made this code harder to follow. That said, I can revise this if reviewers think it would be better anyway

Depends on D13098

Test Plan

tested at end of stack by successfully fetching farcaster avatar URL with neynar

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Aug 15 2024, 10:53 PM
varun held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2024, 10:53 PM
varun added a child revision: D13100: [native] add farcaster avatar URL to registration workflow.Aug 15 2024, 10:53 PM
Harbormaster completed remote builds in B31123: Diff 43420.Aug 15 2024, 11:16 PM
varun updated this revision to Diff 43947.Sep 6 2024, 12:58 PM

rebase

varun edited the summary of this revision. (Show Details)Sep 6 2024, 12:59 PM
varun edited the test plan for this revision. (Show Details)
varun edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B31469: Diff 43947.Sep 6 2024, 1:19 PM
varun published this revision for review.Sep 18 2024, 6:43 AM
varun added reviewers: ashoat, tomek.
varun updated this revision to Diff 44306.Sep 18 2024, 7:12 AM

rebase

Harbormaster completed remote builds in B31694: Diff 44306.Sep 18 2024, 7:29 AM
ashoat accepted this revision.Sep 18 2024, 9:10 AM
This revision is now accepted and ready to land.Sep 18 2024, 9:10 AM
ashoat mentioned this in D13100: [native] add farcaster avatar URL to registration workflow.Sep 18 2024, 11:48 AM
varun updated this revision to Diff 44446.Sep 23 2024, 10:48 AM

use new base type for farcaster avatar URLs

varun planned changes to this revision.Sep 23 2024, 10:55 AM
varun added inline comments.
lib/utils/farcaster-helpers.js
125–127 ↗(On Diff #44446)

realized this can probably be removed

Harbormaster completed remote builds in B31784: Diff 44446.Sep 23 2024, 11:05 AM
varun updated this revision to Diff 44448.Sep 23 2024, 11:17 AM

remove unnecessary condition

This revision is now accepted and ready to land.Sep 23 2024, 11:17 AM
varun planned changes to this revision.Sep 23 2024, 11:32 AM

i don't want this reviewed until i've finalized the whole stack

Harbormaster completed remote builds in B31786: Diff 44448.Sep 23 2024, 11:35 AM
varun updated this revision to Diff 44500.Sep 24 2024, 2:44 PM

rebase and publish for review

This revision is now accepted and ready to land.Sep 24 2024, 2:44 PM
varun requested review of this revision.Sep 24 2024, 2:46 PM

sorry to request review again, but this changed considerably after addressing feedback later in stack

Harbormaster completed remote builds in B31828: Diff 44500.Sep 24 2024, 3:01 PM
ashoat accepted this revision.Sep 24 2024, 4:00 PM
ashoat added inline comments.
lib/utils/farcaster-helpers.js
5–20 ↗(On Diff #44500)

Nit: I would change how these are grouped – group BaseFCNamesInfo / GetFCNames, and BaseFCAvatarInfo / GetFCAvatarURLs

Meanwhile the avatar stuff can be moved to above the definition of getFCAvatarURLs

This revision is now accepted and ready to land.Sep 24 2024, 4:00 PM
Closed by commit rCOMM360954426fa1: [lib] add getFCAvatarURLs method to NeynarClientProvider (authored by varun). · Explain WhySep 25 2024, 7:23 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM360954426fa1: [lib] add getFCAvatarURLs method to NeynarClientProvider.

Revision Contents
Changeset List

PathSize
lib/
components/
7 lines
utils/
71 lines

Diff 44306

View Options

lib/components/neynar-client-provider.react.js

Show All 17 Linesexport type MarkdownRules = {
+simpleMarkdownRules: SharedMarkdown.ParserRules, +simpleMarkdownRules: SharedMarkdown.ParserRules,
+emojiOnlyFactor: ?number, +emojiOnlyFactor: ?number,
// We need to use a Text container for Entry because it needs to match up // We need to use a Text container for Entry because it needs to match up
// exactly with TextInput. However, if we use a Text container, we can't // exactly with TextInput. However, if we use a Text container, we can't
// support styles for things like blockQuote, which rely on rendering as a // support styles for things like blockQuote, which rely on rendering as a
// View, and Views can't be nested inside Texts without explicit height and // View, and Views can't be nested inside Texts without explicit height and
// width // width
+container: 'View' | 'Text', +container: 'View' | 'Text',
+color?: string,
}; };
// Entry requires a seamless transition between Markdown and TextInput // Entry requires a seamless transition between Markdown and TextInput
// components, so we can't do anything that would change the position of text // components, so we can't do anything that would change the position of text
const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => { const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => {
const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light'); const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light');
const simpleMarkdownRules = { const simpleMarkdownRules = {
// Matches 'https://google.com' during parse phase and returns a 'link' node // Matches 'https://google.com' during parse phase and returns a 'link' node
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines blockQuote: {
content: parse(content, state), content: parse(content, state),
}; };
}, },
// eslint-disable-next-line react/display-name // eslint-disable-next-line react/display-name
react: ( react: (
node: SharedMarkdown.SingleASTNode, node: SharedMarkdown.SingleASTNode,
output: SharedMarkdown.Output<SharedMarkdown.ReactElement>, output: SharedMarkdown.Output<SharedMarkdown.ReactElement>,
state: SharedMarkdown.State, state: SharedMarkdown.State,
) => ( ) => {
<View key={state.key} style={styles.blockQuote}> return (
<View
key={state.key}
style={{ ...styles.blockQuote, backgroundColor: state.color }}
>
{output(node.content, state)} {output(node.content, state)}
</View> </View>
), );
},
}, },
codeBlock: { codeBlock: {
...SimpleMarkdown.defaultRules.codeBlock, ...SimpleMarkdown.defaultRules.codeBlock,
match: SimpleMarkdown.blockRegex( match: SimpleMarkdown.blockRegex(
SharedMarkdown.codeBlockStripTrailingNewlineRegex, SharedMarkdown.codeBlockStripTrailingNewlineRegex,
), ),
parse(capture: SharedMarkdown.Capture) { parse(capture: SharedMarkdown.Capture) {
return { return {
▲ Show 20 Lines • Show All 144 Lines • Show Last 20 Lines
View Options

lib/utils/farcaster-helpers.js

Show All 17 Linesexport type MarkdownRules = {
+simpleMarkdownRules: SharedMarkdown.ParserRules, +simpleMarkdownRules: SharedMarkdown.ParserRules,
+emojiOnlyFactor: ?number, +emojiOnlyFactor: ?number,
// We need to use a Text container for Entry because it needs to match up // We need to use a Text container for Entry because it needs to match up
// exactly with TextInput. However, if we use a Text container, we can't // exactly with TextInput. However, if we use a Text container, we can't
// support styles for things like blockQuote, which rely on rendering as a // support styles for things like blockQuote, which rely on rendering as a
// View, and Views can't be nested inside Texts without explicit height and // View, and Views can't be nested inside Texts without explicit height and
// width // width
+container: 'View' | 'Text', +container: 'View' | 'Text',
+color?: string,
}; };
// Entry requires a seamless transition between Markdown and TextInput // Entry requires a seamless transition between Markdown and TextInput
// components, so we can't do anything that would change the position of text // components, so we can't do anything that would change the position of text
const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => { const inlineMarkdownRules: boolean => MarkdownRules = _memoize(useDarkStyle => {
const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light'); const styles = getMarkdownStyles(useDarkStyle ? 'dark' : 'light');
const simpleMarkdownRules = { const simpleMarkdownRules = {
// Matches 'https://google.com' during parse phase and returns a 'link' node // Matches 'https://google.com' during parse phase and returns a 'link' node
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines blockQuote: {
content: parse(content, state), content: parse(content, state),
}; };
}, },
// eslint-disable-next-line react/display-name // eslint-disable-next-line react/display-name
react: ( react: (
node: SharedMarkdown.SingleASTNode, node: SharedMarkdown.SingleASTNode,
output: SharedMarkdown.Output<SharedMarkdown.ReactElement>, output: SharedMarkdown.Output<SharedMarkdown.ReactElement>,
state: SharedMarkdown.State, state: SharedMarkdown.State,
) => ( ) => {
<View key={state.key} style={styles.blockQuote}> return (
<View
key={state.key}
style={{ ...styles.blockQuote, backgroundColor: state.color }}
>
{output(node.content, state)} {output(node.content, state)}
</View> </View>
), );
},
}, },
codeBlock: { codeBlock: {
...SimpleMarkdown.defaultRules.codeBlock, ...SimpleMarkdown.defaultRules.codeBlock,
match: SimpleMarkdown.blockRegex( match: SimpleMarkdown.blockRegex(
SharedMarkdown.codeBlockStripTrailingNewlineRegex, SharedMarkdown.codeBlockStripTrailingNewlineRegex,
), ),
parse(capture: SharedMarkdown.Capture) { parse(capture: SharedMarkdown.Capture) {
return { return {
▲ Show 20 Lines • Show All 144 Lines • Show Last 20 Lines