Page MenuHomePhabricator
Differential D13646

[comm-lib][blob] Add tags support to remove holders request payload
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:20 AM.
Tags
None
Referenced Files
F3335873: D13646.diff
Thu, Nov 21, 11:51 AM
Unknown Object (File)
Fri, Nov 15, 12:00 AM
Unknown Object (File)
Thu, Nov 14, 9:04 PM
Unknown Object (File)
Sat, Nov 9, 3:55 AM
Unknown Object (File)
Sat, Nov 9, 2:22 AM
Unknown Object (File)
Thu, Nov 7, 9:04 AM
Unknown Object (File)
Thu, Nov 7, 8:55 AM
Unknown Object (File)
Thu, Nov 7, 1:58 AM
View All 40 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMM6c8640428254: [comm-lib][blob] Add tags support to remove holders request payload
Summary

Expanded RemoveHoldersRequest to support either current payload format, or the new one that
removes holders that matches given tags. The new format is not supported yet, so added HTTP 501 Unimplemented response server side.

Depends on D13645

Test Plan

Unit tests for serialize/deserialize to make sure that existing request format is untouched.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
handlers/
9 lines
shared/
comm-lib/
src/
blob/
2 lines
90 lines

Diff 45161

View Options

services/blob/src/http/handlers/holders.rs

Loading...
View Options

shared/comm-lib/src/blob/client.rs

Loading...
View Options

shared/comm-lib/src/blob/types.rs

Loading...