[lib] Fetch message to preview from MessagePreview
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 30, 11:46 AM.

Details

Reviewers

tomek

Commits

rCOMMd436a37a6e69: [lib] Fetch message to preview from MessagePreview

Summary

In a later diff, we'll need to potentially call an async function to fetch a message from the database in order to determine which message should be the MessagePreview.

The code in chat-selectors.js isn't async, and it would be rather complicated to convert it to be.

Instead, in this diff I move the logic for determining which message to preview to the MessagePreview components that actually render the message.

Depends on D13825

Test Plan

Tested in combination with the rest of the stack:

Make sure membership operations (user joining / leaving) don't appear in MessagePreview
Make sure reactions to the viewer's messages still appear in MessagePreview
Make sure reactions to other user's messages don't appear in MessagePreview
Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Oct 30, 11:46 AM

ashoat added a child revision: D13827: [lib] Introduce MessageSpec.showInMessagePreview.

ashoat added inline comments.Wed, Oct 30, 11:55 AM

lib/hooks/message-hooks.js
17 ↗	(On Diff #45476)	This function is substantially similar to `getMostRecentMessageInfo` in `chat-selectors.js`, but has one difference which introduces a slight regression which is addressed in the next diff. The difference is that we don't check `isEmptyMediaMessage` here. Since the check is specific to multimedia messages, I add it to `multimedia-message-spec.js` in the next diff.
lib/selectors/chat-selectors.js
106 ↗	(On Diff #45476)	Check mentioned above