Differential D13878

[backup-service] make `user_data` and `user_keys` optional in `BackupData`
Needs ReviewPublic
Actions

Authored by kamil on Tue, Nov 5, 9:10 AM.

Tags

None

Referenced Files

	F3164742: D13878.diff
	Wed, Nov 6, 7:33 PM

	F3163711: D13878.id45634.diff
	Wed, Nov 6, 3:24 PM

	F3163710: D13878.id45613.diff
	Wed, Nov 6, 3:24 PM

	F3163701: D13878.id.diff
	Wed, Nov 6, 3:24 PM

	F3163683: D13878.diff
	Wed, Nov 6, 3:23 PM

Subscribers

Details

Reviewers

varun
bartek

Summary

Part of ENG-9673.

Tracked in ENG-9649.

Depends on D13877

Test Plan

Tested in D13879

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Tue, Nov 5, 9:10 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Nov 5, 9:10 AM

kamil added a child revision: D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately.Tue, Nov 5, 9:12 AM

kamil edited the test plan for this revision. (Show Details)Tue, Nov 5, 9:17 AM

Harbormaster failed remote builds in B32545: Diff 45613!Tue, Nov 5, 9:45 AM

minor update

Harbormaster completed remote builds in B32557: Diff 45634.Wed, Nov 6, 1:21 AM

kamil published this revision for review.Wed, Nov 6, 3:45 AM

kamil added inline comments.

native/native_rust_library/src/backup/upload_handler.rs
199–209 ↗	(On Diff #45634)	Depending on what files will be generated we're going to upload User Keys, or User Data, or both
services/commtest/tests/backup_integration_test.rs
60 ↗	(On Diff #45634)	not sure what is best pattern for this
shared/backup_client/src/lib.rs
59–84 ↗	(On Diff #45634)	this is strange but we need to maintain order, otherwise backup service can fail to parse Multiplart
86–88 ↗	(On Diff #45634)	We always want to upload at least one, and depending on data we're gone chose endpoint (see below)

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

upload_handler.rs

13 lines

services/

commtest/

src/

backup/

backup_utils.rs

8 lines

shared/

backup_client/

src/

53 lines

Diff 45613

native/native_rust_library/src/backup/upload_handler.rs

Loading...

services/commtest/src/backup/backup_utils.rs

Loading...

shared/backup_client/src/lib.rs

Loading...