Page MenuHomePhabricator
Differential D13836

[backup-client] refactor `SIWEBackupData` type
ClosedPublic
Actions

Authored by kamil on Thu, Oct 31, 4:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:00 AM
Unknown Object (File)
Tue, Nov 12, 4:39 PM
Unknown Object (File)
Mon, Nov 11, 12:11 PM
Unknown Object (File)
Mon, Nov 11, 11:26 AM
Unknown Object (File)
Mon, Nov 11, 10:42 AM
Unknown Object (File)
Mon, Nov 11, 10:35 AM
Unknown Object (File)
Sat, Nov 9, 1:58 PM
Unknown Object (File)
Sat, Nov 9, 11:54 AM
View All 20 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type
Summary

ENG-6145.

  1. Move retrieving SIWEBackupData to a util funtion - it will be needed later in the stack
  2. Move types to proper places on JS side
  3. Add comment keep types in sync
  4. Add validation on JS side
  5. Remove siwe_backup_msg - it's not needed
Test Plan

Test backup restore for Wallet user

Diff Detail

Repository
rCOMM Comm
Branch
land-backup
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Oct 31, 4:44 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Oct 31, 4:44 AM
kamil mentioned this in D13837: [native_rust_library] implement method to retrieve latest backup info.Thu, Oct 31, 5:00 AM
Harbormaster completed remote builds in B32465: Diff 45498.Thu, Oct 31, 5:02 AM
kamil added a child revision: D13837: [native_rust_library] implement method to retrieve latest backup info.Thu, Oct 31, 5:08 AM
kamil published this revision for review.Thu, Oct 31, 8:46 AM
kamil added inline comments.
lib/types/backup-types.js
24 ↗(On Diff #45498)

This is not needed, it's removed in D13850 to make CI pass

bartek accepted this revision.Mon, Nov 4, 11:20 PM
bartek added inline comments.
native/native_rust_library/src/backup.rs
253–272 ↗(On Diff #45498)

Nit: to avoid nested match you could use let-else to unwrap Some(siwe_backup_msg_value) and then the inner match get_siwe_backup_data_from_msg() would not be nested

This revision is now accepted and ready to land.Mon, Nov 4, 11:20 PM
kamil updated this revision to Diff 45651.Thu, Nov 7, 1:56 AM

address nit

Harbormaster failed remote builds in B32565: Diff 45651!Thu, Nov 7, 2:03 AM
Harbormaster completed remote builds in B32565: Diff 45651.Thu, Nov 7, 2:31 AM
Closed by commit rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type.
kamil mentioned this in rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info.

Revision Contents
Changeset List

PathSize
lib/
types/
16 lines
native/
backup/
21 lines
native_rust_library/
src/
86 lines

Diff 45651

View Options

lib/types/backup-types.js

Loading...
View Options

native/backup/use-client-backup.js

Loading...
View Options

native/native_rust_library/src/backup.rs

Loading...