Paths

Table of Contentst

[commtest] refactor backup service integration tests
ClosedPublic
Actions

Authored by kamil on Nov 5 2024, 6:06 AM.

Details

Reviewers

varun
bartek

Commits

rCOMM045eb2371305: [commtest] refactor backup service integration tests

Summary

Part of ENG-6145.

Tracked in ENG-9650.

Create mod for utils, similarly to e.g. blob_utils
Reduces code duplication and cleanup
Move code to a place so it can be used in more places (later in the stack I'll add a lot more backup integration tests)

Depends on D13809

Test Plan

run commtest

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 5 2024, 6:06 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 5 2024, 6:06 AM

kamil edited the summary of this revision. (Show Details)Nov 5 2024, 6:07 AM

kamil mentioned this in D13805: [commtest] use registered `UserIdentity` in backup tests.

Harbormaster completed remote builds in B32538: Diff 45606.Nov 5 2024, 6:24 AM

kamil published this revision for review.Nov 5 2024, 6:26 AM

kamil added a child revision: D13873: [backup-service] refactor uploading function in `/backups` endpoint.Nov 5 2024, 6:33 AM

Nice!

This revision is now accepted and ready to land.Nov 6 2024, 12:59 AM

Closed by commit rCOMM045eb2371305: [commtest] refactor backup service integration tests (authored by kamil). · Explain WhyNov 7 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM045eb2371305: [commtest] refactor backup service integration tests.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

backup/

backup_utils.rs

97 lines

mod.rs

1 line

identity/

device.rs

1 line

lib.rs

1 line

tests/

backup_integration_test.rs

116 lines

backup_performance_test.rs

42 lines

Diff 45677

View Options

services/commtest/src/backup/backup_utils.rs

View Options

services/commtest/src/backup/mod.rs

View Options

services/commtest/src/identity/device.rs

View Options

services/commtest/src/lib.rs

View Options

services/commtest/tests/backup_integration_test.rs

View Options

services/commtest/tests/backup_performance_test.rs

[commtest] refactor backup service integration testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45677

services/commtest/src/backup/backup_utils.rs

services/commtest/src/backup/mod.rs

services/commtest/src/identity/device.rs

services/commtest/src/lib.rs

services/commtest/tests/backup_integration_test.rs

services/commtest/tests/backup_performance_test.rs

[commtest] refactor backup service integration tests
ClosedPublic
Actions

Revision Contents
Changeset List