I think optional onClose makes the most sense.

use optional onClose

remove menu from diff

remove comment

No worries! Thanks for the detailed description.

closing in favor of D3681

address diff feedback

move conditional

Seems easier to read.

@ashoat -- you're still a blocking review. Could you give this a look?

change click handler name

Also appologies @def-au1t -- I should have asked and framed a question rather than made an assertion, additionally should have left more of a description in this diff.

Abandoning D3678 in favor of this diff.

In D3678#101545, @ashoat wrote:

@benschac introduced a new stack... it might be best to abandon this one and follow-up on D3681?

That said – @def-au1t, I still am curious to understand a bit better why useLayoutEffect is necessary here

update import

rebase

update file name

Sorry about #1. I was working on this late last Friday and I should have spent a bit more time thinking through the diff.

address diff feedback

Fair enough. I thought it would make visually checking the correctness of the CSS easier / easier review process. If it's making life difficult lets remove it.

update return type to mixed

change header copy

Closing. Changes from this diff were added to a different diff.

fix up layout

update type

There isn't a reason. We don't have design for the calendar. The ticket specifically said:

I can remove this diff from the stack. But, I think matching the content is helpful for visual inspection of styling.

https://stackoverflow.com/questions/20174426/html-how-to-make-h1-h2-etc-as-links -- this looks right.

In D3614#99365, @ashoat wrote:

This is definitely worse. @benschac, what's your thinking for putting up a change like this up? Please try to think of your role at a higher level – your job isn't to perfectly duplicate the Figma, your job is to make a good web app. This diff is absolutely a regression. You're taking placeholder copy from our Polish language designer at face value. "This and this will happen" is basically lorem ipsum.

rebase

rebase

rebase

rebase

fix thing

move modal heading style