Thanks for catching this!
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jan 26 2023
Jan 26 2023
atul added a comment to D6395: [keyserver] disable requiring legal policies for `update_device_token` endpoint.
now it works on prod:
move to dev dependencies
In D6365#191153, @ashoat wrote:Was this meant to be published for review? I thought we needed some hacks for this to work
Jan 25 2023
Jan 25 2023
arc amend
atul committed rCOMMabba003a69e6: Bump ua-parser-js from 0.7.31 to 0.7.33 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
rebase before landign
Jan 24 2023
Jan 24 2023
Run yarn dev and yarn prod (with env vars pointing at a custom repo) and check if it correctly serves files.
(Went ahead and added @ashoat as blocking since we'll need to do that once the feedback is addressed anyways.)
Overall looks super clean!
In D5796#187819, @ashoat wrote:
In D6362#190471, @ginsu wrote:Are you using yarn add {dependency} workflow or are you making the addition to package.json manually?
Was using the yarn add {dependency} workflow, will try the other method
Are you using yarn add {dependency} workflow or are you making the addition to package.json manually?
Surprised to see changes to react-native-flipper@^0.164.0 entry in yarn.lock. When I patched in this diff and ran yarn cleaninstall, it looks like it reverted those changes:
Looks good, minor notes inline.
land
Jan 23 2023
Jan 23 2023
fix
rebase before landing
atul added inline comments to D6340: [web] Proactively fetch `siweNonce` once user has indicated they intend to SIWE.
atul updated the diff for D6340: [web] Proactively fetch `siweNonce` once user has indicated they intend to SIWE.
address feedback
address feedback
In D6349#190075, @ashoat wrote:The second screenshot you included was not something you changed. Can you update this diff to have the screenshot of the interface you actually changed?
atul added inline comments to D6339: [keyserver] Ensure that we're including `calendarQuery` in `siweAccountCreationRequest`.
atul updated the diff for D6339: [keyserver] Ensure that we're including `calendarQuery` in `siweAccountCreationRequest`.
address feedback
atul added inline comments to D6340: [web] Proactively fetch `siweNonce` once user has indicated they intend to SIWE.
atul published D6340: [web] Proactively fetch `siweNonce` once user has indicated they intend to SIWE for review.
atul updated the diff for D6326: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint.
address inline comment
Jan 22 2023
Jan 22 2023
atul updated the diff for D6326: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint.
address feedback
atul updated the diff for D6326: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint.
rebase before addressing feedback
Jan 21 2023
Jan 21 2023
atul retitled D6326: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint from [web] Prompt user to sign SIWEMessage with wallet when "Sign in" clicked
atul updated the diff for D6326: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint.
update
atul committed rCOMMd1c586944e3a: Bump jsonwebtoken from 8.5.1 to 9.0.0 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM7fbf522d32ca: Bump activesupport from 6.1.7 to 6.1.7.1 in /native (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMM1cf3a3400c35: Bump luxon from 1.28.0 to 1.28.1 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
atul committed rCOMMe4f225aa1ec2: Bump bumpalo from 3.9.1 to 3.12.0 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Accepting, two notes inline,