Page MenuHomePhorge
Feed Search

Jan 30 2023

atul added a reverting change for rCOMM158929d5e086: Temporary changes for staff release: rCOMM9e93ecf25366: Revert "Temporary changes for staff release".
Jan 30 2023, 9:22 PM
atul committed rCOMM9e93ecf25366: Revert "Temporary changes for staff release".
Jan 30 2023, 9:22 PM
atul committed rCOMM7bad24d6d5ad: [native] `codeVersion` -> 180.
Jan 30 2023, 9:22 PM
atul committed rCOMM158929d5e086: Temporary changes for staff release.
Jan 30 2023, 9:22 PM
atul committed rCOMMb18d7b649053: [native] `codeVersion` -> 179.
Jan 30 2023, 9:22 PM
atul accepted D6470: [web] Show ENS names in PasswordChangeModal.
Jan 30 2023, 9:10 PM
atul closed D6469: [design] Introduce David's changes to `colors.js`.
Jan 30 2023, 8:45 PM
atul committed rCOMMb0981e012094: [design] Introduce David's changes to `colors.js`.
Jan 30 2023, 8:44 PM
atul added a comment to D6467: [native] Render the media gallery in the thread settings on native.

Might be best to tuck the gallery away behind another screen. Something that you'll want to discuss with Ted

Jan 30 2023, 8:24 PM
atul published D6469: [design] Introduce David's changes to `colors.js` for review.
Jan 30 2023, 8:23 PM
atul committed rCOMM1af6cfb41ca0: Update `staff.json`.
Jan 30 2023, 7:36 PM
atul closed D6451: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in `SIWE` component.
Jan 30 2023, 7:17 PM
atul committed rCOMM1dd0d74e03b3: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in….
Jan 30 2023, 7:17 PM
atul updated the diff for D6451: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in `SIWE` component.

rebase and land

Jan 30 2023, 7:10 PM
atul closed D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.
Jan 30 2023, 6:59 PM
atul committed rCOMM932d057e9d68: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.
Jan 30 2023, 6:59 PM
atul added inline comments to D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.
Jan 30 2023, 6:55 PM
atul updated the diff for D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.

remove export default

Jan 30 2023, 6:46 PM
atul closed D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.
Jan 30 2023, 6:36 PM
atul committed rCOMM1aae0e22e68d: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.
Jan 30 2023, 6:36 PM
atul awarded D6465: [keyserver] Add thread column to uploads table a Party Time token.
Jan 30 2023, 5:59 PM
atul accepted D6465: [keyserver] Add thread column to uploads table.
Jan 30 2023, 5:58 PM
atul updated the diff for D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.

rebase and land

Jan 30 2023, 5:52 PM
atul added inline comments to D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.
Jan 30 2023, 5:48 PM
atul requested review of D6451: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in `SIWE` component.
Jan 30 2023, 1:20 AM
atul updated the diff for D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.

add same sessionChange.cookieInvalidated check as reduceDeviceID

Jan 30 2023, 1:02 AM
atul updated the diff for D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.

hook up reducer to web/redux/redux-setup:reducer

Jan 30 2023, 12:33 AM
atul updated the diff for D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.

handle logout, account deletion, and session invalidation

Jan 30 2023, 12:18 AM
atul retitled D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux from [lib][web][native] Add `primaryIdentityPublicKey` entry to Redux
Jan 30 2023, 12:01 AM
atul updated the diff for D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.

web only

Jan 30 2023, 12:01 AM

Jan 29 2023

atul accepted D6450: [web] Fetch ENS names in AddMembersModal.
Jan 29 2023, 11:56 PM
atul accepted D6449: [web] Fetch ENS names in ChatThreadComposer.
Jan 29 2023, 11:53 PM
atul accepted D6446: [lib] Fetch ENS name in useKeyserverAdmin.
Jan 29 2023, 11:32 PM
atul accepted D6444: [lib] getKeyserverAdmin -> useKeyserverAdmin.
Jan 29 2023, 11:31 PM
atul updated the summary of D6444: [lib] getKeyserverAdmin -> useKeyserverAdmin.
Jan 29 2023, 11:31 PM
atul added a comment to D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.

Passing back to you with question – not clear why we need to put this in Redux on native given it's already persisted by CommCoreModule

Jan 29 2023, 11:30 PM
atul accepted D6443: [native] Show ENS names in MessageListThreadSearch.

Looks clean

Jan 29 2023, 10:38 PM
atul accepted D6442: [native] Show ENS names in AddUsersModal.

Looks clean

Jan 29 2023, 10:37 PM
atul accepted D6441: [native] Convert AddUsersModal to hook.

Didn't read through this too carefully since it seems like a fairly straightforward refactor + the Test Plan looks good. Can do a more thorough review if you think that would be good.

Jan 29 2023, 10:36 PM
atul accepted D6440: [native] Show ENS names in ComposeSubchannel.
Jan 29 2023, 10:32 PM
atul accepted D6439: [native] Convert ComposeSubchannel to hook.
Jan 29 2023, 10:17 PM
atul accepted D6438: [web] Fetch ENS names in MembersList.
Jan 29 2023, 10:12 PM
atul accepted D6437: [web] Fetch ENS names in SubchannelMembersList.
Jan 29 2023, 10:12 PM
atul added a comment to D6436: [native] Show ENS names in RelationshipList.

(Two of the files in the Test Plan aren't being shown because of the permissions thing)

Jan 29 2023, 10:12 PM
atul accepted D6436: [native] Show ENS names in RelationshipList.
Jan 29 2023, 10:11 PM
atul accepted D6435: [native] Convert RelationshipList to hook.
Jan 29 2023, 10:11 PM
atul updated the summary of D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.
Jan 29 2023, 12:01 AM
atul published D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer for review.
Jan 29 2023, 12:00 AM

Jan 28 2023

atul updated the diff for D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.

make sure to persist on web

Jan 28 2023, 11:59 PM
atul published D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux for review.
Jan 28 2023, 11:33 PM
atul updated the diff for D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.

update

Jan 28 2023, 9:42 PM
atul reopened D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.

Well looks like there are flow issues after rebasing

Jan 28 2023, 9:28 PM
atul added a reverting change for D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`: rCOMM6ee723cec222: Revert "[yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`".
Jan 28 2023, 9:27 PM
atul committed rCOMM6ee723cec222: Revert "[yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`".
Jan 28 2023, 9:27 PM
atul added a reverting change for rCOMMc0eeb2d6759c: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`: rCOMM6ee723cec222: Revert "[yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`".
Jan 28 2023, 9:27 PM
atul accepted D6432: [native] Use ENS names inside ThreadSettings.
Jan 28 2023, 9:25 PM
atul closed D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.
Jan 28 2023, 9:02 PM
atul committed rCOMMc0eeb2d6759c: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.
Jan 28 2023, 9:02 PM
atul added a comment to D6432: [native] Use ENS names inside ThreadSettings.

Think you intended to attach some screenshots?

Jan 28 2023, 9:01 PM
atul accepted D6431: [lib] Don't fetch the same ENS names simultaneously.
Jan 28 2023, 9:01 PM
atul updated the diff for D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.

rebase before landing

Jan 28 2023, 8:58 PM
atul accepted D6430: [lib] Make it possible for ENSCache to store Promises.
Jan 28 2023, 8:58 PM
atul accepted D6429: [lib] Refactor ENSCache lambdas a little bit.
Jan 28 2023, 8:55 PM
atul accepted D6428: [lib] Modify ENSCache test so ETH address normalization is checked.
Jan 28 2023, 8:48 PM
atul accepted D6427: [lib] Factor out constants in ENSCache tests.
Jan 28 2023, 8:47 PM
atul accepted D6426: [lib] Factor out normalization functions in ENSCache.
Jan 28 2023, 8:42 PM
atul accepted D6425: [native][web] Show ENS name for message author.
Jan 28 2023, 8:41 PM
atul accepted D6423: [lib] Introduce useENSNames to fetch more than one ENS name at a time.
Jan 28 2023, 8:39 PM
atul added a reviewer for D6405: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`: ashoat.
Jan 28 2023, 8:01 PM

Jan 27 2023

atul accepted D6422: [web] Show your ENS name in AccountSettings.
Jan 27 2023, 9:36 PM
atul added inline comments to D6421: [native] Show your ENS name in ProfileScreen.
Jan 27 2023, 9:35 PM
atul accepted D6421: [native] Show your ENS name in ProfileScreen.
Jan 27 2023, 9:35 PM
atul accepted D6420: [lib] Make stringForUser and useStringForUser work with any user types.
Jan 27 2023, 9:33 PM
atul accepted D6402: [web] switch like button to react button on message tooltip.

Looks good, left a couple of notes inline

Jan 27 2023, 9:30 PM
atul accepted D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.
Jan 27 2023, 9:12 PM
atul added a comment to D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.

Would we be able to pass all the arguments directly to the hook except the reactionInput? Personally feel like that would be a cleaner API

Jan 27 2023, 9:12 PM
atul closed D6410: [web] Include `primaryIdentityPublicKey` in SIWE message.
Jan 27 2023, 8:49 PM
atul committed rCOMM43573fdca59e: [web] Include `primaryIdentityPublicKey` in SIWE message.
Jan 27 2023, 8:49 PM
atul updated the diff for D6410: [web] Include `primaryIdentityPublicKey` in SIWE message.

rebase and land

Jan 27 2023, 8:48 PM
atul closed D6408: [landing] Reduce `.walletDisplay` padding in `siwe.css`.
Jan 27 2023, 8:47 PM
atul committed rCOMM593d50ca4bb4: [landing] Reduce `.walletDisplay` padding in `siwe.css`.
Jan 27 2023, 8:47 PM
atul updated the diff for D6408: [landing] Reduce `.walletDisplay` padding in `siwe.css`.

rebase and land

Jan 27 2023, 8:46 PM
atul closed D6406: [web][landing] Add legal acknowledgements to SIWE flow.
Jan 27 2023, 8:37 PM
atul committed rCOMM7ec720ec655e: [web][landing] Add legal acknowledgements to SIWE flow.
Jan 27 2023, 8:37 PM
atul updated the diff for D6406: [web][landing] Add legal acknowledgements to SIWE flow.

rebase and land

Jan 27 2023, 8:36 PM
atul accepted D6418: [lib] Add functions for getting cached results from ENSCache.
Jan 27 2023, 8:16 PM
atul accepted D6419: [lib] Show cached ENS names on first render.
Jan 27 2023, 8:14 PM
atul accepted D6411: Revert "[keyserver] implement registerUser rpc with napi-rs/tonic/opaque-ke".

(I think it’s usually chill to revert your own commits directly without putting up a diff… or at least i’ve been working under that assumption.)

Jan 27 2023, 4:25 AM
atul updated the diff for D6410: [web] Include `primaryIdentityPublicKey` in SIWE message.

remove <p> used for testing/debugging

Jan 27 2023, 12:41 AM
atul published D6410: [web] Include `primaryIdentityPublicKey` in SIWE message for review.
Jan 27 2023, 12:40 AM

Jan 26 2023

atul accepted D6399: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider.
Jan 26 2023, 11:34 PM
atul published D6408: [landing] Reduce `.walletDisplay` padding in `siwe.css` for review.
Jan 26 2023, 11:20 PM
atul abandoned D6407: [patch] Reduce width of `ConnectButton` by reducing amount of address displayed.

Not necessary after reducing padding.

Jan 26 2023, 11:13 PM
atul updated the test plan for D6407: [patch] Reduce width of `ConnectButton` by reducing amount of address displayed.
Jan 26 2023, 11:11 PM
atul updated the diff for D6407: [patch] Reduce width of `ConnectButton` by reducing amount of address displayed.

update

Jan 26 2023, 11:10 PM
atul published D6407: [patch] Reduce width of `ConnectButton` by reducing amount of address displayed for review.
Jan 26 2023, 11:08 PM
atul updated the test plan for D6406: [web][landing] Add legal acknowledgements to SIWE flow.
Jan 26 2023, 11:03 PM
atul added a comment to D6406: [web][landing] Add legal acknowledgements to SIWE flow.

Legal agreements do fit on screen. The button, however, does not. In subsequent diff I cut down width of ConnectButton (by reducing characters). In another I reduce the spacing below the ConnectButton so everything fits.

Jan 26 2023, 11:02 PM
atul requested changes to D6399: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider.

Curious why setRenderEmojiKeyboard(...) is optional. Could totally just be missing something.

Jan 26 2023, 10:46 PM
atul accepted D6404: [Nix] Fix undeclared failure.
Jan 26 2023, 10:42 PM