rebase with new implementation
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 31 2023
rerequesting review because made a significant updates to the diff
move reaction selection popover from tooltip to text/multimedia/robotext message tooltip buttons
remove reactionSelectionPopoverContainerStyle from tooltip
put reactionSelectionPopoverContainerStyle logic into a hook called useReactionSelectionPopoverPosition
This diff is no longer relevant since we don't want reactionSelectionPopoverLocation in the tooltip component
This diff is no longer relevant since we don't want canCreateReactionFromMessage in the tooltip component
thanks @atul!
Jan 30 2023
In D6447#193203, @tomek wrote:Is this diff going to crash any dev app that has saved navigation state with an open tooltip?
Not 100% sure if this is necessary but should we also add thread to the ALTER statement for the uploads table
Not 100% sure if this is necessary but should we also add thread to the ALTER statement for the uploads table
When we have a couple of reactions, it is not clear to which of these the number corresponds.
Jan 29 2023
Jan 28 2023
Jan 27 2023
address atul's comments
Would we be able to pass all the arguments directly to the hook except the reactionInput?
address atul's comments
In D6412#192153, @ashoat wrote:Encourage you to only use arc patch for pulling in other people's work going forward – it's typically a "crutch" for not understanding git well enough. Try to use git cherry-pick if you need to get a commit from another branch into the current one
How do you think the file was missed in the original land?
Jan 26 2023
add jest tests for onlyOneEmojiRegex
Curious why setRenderEmojiKeyboard(...) is optional. Could totally just be missing something.
made setRenderEmojiKeyboard non optional
address ashoat's feedback
In D6398#191658, @ashoat wrote:Could an attacker hit this endpoint with a weird string and mess with things? It feels like we should introduce some sort of validation to make sure the input is good
Jan 24 2023
added dependencies directly to package.json and ran yarn cleaninstall
address atul's comments
remove unnecessary margin
address atul's comments
address atuls comments
Wonder if you just ran yarn cleaninstall from the root of the repo if things would get fixed up?
Are you using yarn add {dependency} workflow or are you making the addition to package.json manually?
include @emoji-mart/data dependency
Merged with D6302
address ashoat's comments
address ashoat's comments
Jan 23 2023
rebase