Page MenuHomePhabricator
Feed Advanced Search

Jan 31 2023

ginsu updated the diff for D6455: [native] implement emoji keyboard button on reaction selection popover.

rebase with new implementation

Jan 31 2023, 2:56 PM
ginsu requested review of D6454: [native] introduce reaction selection popover component.

rerequesting review because made a significant updates to the diff

Jan 31 2023, 1:41 PM
ginsu updated the summary of D6454: [native] introduce reaction selection popover component.
Jan 31 2023, 1:40 PM
ginsu attached a referenced file: F354289: Screen Recording 2023-01-31 at 4.31.34 PM.mov.
Jan 31 2023, 1:39 PM
ginsu added a reviewer for D6454: [native] introduce reaction selection popover component: atul.
Jan 31 2023, 1:39 PM
ginsu updated the summary of D6454: [native] introduce reaction selection popover component.
Jan 31 2023, 1:38 PM
ginsu updated the diff for D6454: [native] introduce reaction selection popover component.

move reaction selection popover from tooltip to text/multimedia/robotext message tooltip buttons

Jan 31 2023, 1:36 PM
ginsu requested review of D6487: [native] introduce useSendReaction hook.
Jan 31 2023, 1:30 PM
ginsu retitled D6453: [native] introduce useReactionSelectionPopoverPosition hook from [native] introduce get reactionSelectionPopoverContainerStyle to [native] introduce useReactionSelectionPopoverPosition hook.
Jan 31 2023, 12:36 PM
ginsu updated the diff for D6453: [native] introduce useReactionSelectionPopoverPosition hook.

remove reactionSelectionPopoverContainerStyle from tooltip

Jan 31 2023, 12:35 PM
ginsu updated the diff for D6453: [native] introduce useReactionSelectionPopoverPosition hook.

put reactionSelectionPopoverContainerStyle logic into a hook called useReactionSelectionPopoverPosition

Jan 31 2023, 12:30 PM
ginsu abandoned D6452: [native] introduce get reactionSelectionPopoverLocation.

This diff is no longer relevant since we don't want reactionSelectionPopoverLocation in the tooltip component

Jan 31 2023, 12:17 PM
ginsu abandoned D6448: [native] introduce canCreateReactionFromMessage prop to Tooltip component.

This diff is no longer relevant since we don't want canCreateReactionFromMessage in the tooltip component

Jan 31 2023, 12:03 PM
ginsu accepted D6486: [lib] Add `emote-smile-filled` to `CommIcons`.

thanks @atul!

Jan 31 2023, 11:59 AM

Jan 30 2023

ginsu attached a referenced file: F352643: Screen Recording 2023-01-30 at 3.33.32 PM.mov.
Jan 30 2023, 12:38 PM
ginsu added a comment to D6447: [native] change location to tooltipLocation in the TooltipParams.
In D6447#193203, @tomek wrote:

Is this diff going to crash any dev app that has saved navigation state with an open tooltip?

Jan 30 2023, 12:38 PM
ginsu accepted D6469: [design] Introduce David's changes to `colors.js`.
Jan 30 2023, 12:23 PM
ginsu requested review of D6445: [native] introduce showEmojiKeyboard shared value.
Jan 30 2023, 12:21 PM
ginsu added inline comments to D6445: [native] introduce showEmojiKeyboard shared value.
Jan 30 2023, 12:20 PM
ginsu added a comment to D6465: [keyserver] Add thread column to uploads table.

Not 100% sure if this is necessary but should we also add thread to the ALTER statement for the uploads table

Jan 30 2023, 10:55 AM
ginsu added a comment to D6465: [keyserver] Add thread column to uploads table.

Not 100% sure if this is necessary but should we also add thread to the ALTER statement for the uploads table

Jan 30 2023, 10:54 AM
ginsu added a comment to D6455: [native] implement emoji keyboard button on reaction selection popover.

When we have a couple of reactions, it is not clear to which of these the number corresponds.

Jan 30 2023, 7:54 AM

Jan 29 2023

ginsu requested review of D6456: [native] remove Like button from tooltip.
Jan 29 2023, 9:56 PM
ginsu requested review of D6455: [native] implement emoji keyboard button on reaction selection popover.
Jan 29 2023, 9:44 PM
ginsu requested review of D6454: [native] introduce reaction selection popover component.
Jan 29 2023, 9:31 PM
ginsu requested review of D6453: [native] introduce useReactionSelectionPopoverPosition hook.
Jan 29 2023, 8:41 PM
ginsu requested review of D6452: [native] introduce get reactionSelectionPopoverLocation.
Jan 29 2023, 8:36 PM
ginsu requested review of D6448: [native] introduce canCreateReactionFromMessage prop to Tooltip component.
Jan 29 2023, 3:11 PM
ginsu requested review of D6447: [native] change location to tooltipLocation in the TooltipParams.
Jan 29 2023, 3:05 PM
ginsu requested review of D6445: [native] introduce showEmojiKeyboard shared value.
Jan 29 2023, 2:54 PM

Jan 28 2023

ginsu closed D6403: [web] remove message like tooltip button component.
Jan 28 2023, 4:12 PM
ginsu closed D6402: [web] switch like button to react button on message tooltip.
Jan 28 2023, 4:12 PM
ginsu committed rCOMM639e994c1bbf: [web] switch like button to react button on message tooltip (authored by ginsu).
[web] switch like button to react button on message tooltip
Jan 28 2023, 4:12 PM
ginsu committed rCOMM940219fd6579: [web] remove message like tooltip button component (authored by ginsu).
[web] remove message like tooltip button component
Jan 28 2023, 4:12 PM
ginsu closed D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.
Jan 28 2023, 4:12 PM
ginsu committed rCOMM2b64942985b2: [web] modify useOnClickReact to return function with arguments instead of… (authored by ginsu).
[web] modify useOnClickReact to return function with arguments instead of…
Jan 28 2023, 4:12 PM

Jan 27 2023

ginsu added inline comments to D6402: [web] switch like button to react button on message tooltip.
Jan 27 2023, 11:23 PM
ginsu updated the diff for D6402: [web] switch like button to react button on message tooltip.

address atul's comments

Jan 27 2023, 11:10 PM
ginsu added a comment to D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.

Would we be able to pass all the arguments directly to the hook except the reactionInput?

Jan 27 2023, 11:09 PM
ginsu added inline comments to D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.
Jan 27 2023, 11:07 PM
ginsu updated the diff for D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.

address atul's comments

Jan 27 2023, 11:06 PM
ginsu accepted D6424: [lib] createMessageReactionsList -> useMessageReactionsList for ENS fetching.
Jan 27 2023, 10:32 PM
ginsu closed D6413: [native] add rn-emoji-keyboard dependency.
Jan 27 2023, 10:48 AM
ginsu committed rCOMM1e4d2f13f138: [native] add rn-emoji-keyboard dependency (authored by ginsu).
[native] add rn-emoji-keyboard dependency
Jan 27 2023, 10:48 AM
ginsu added a comment to D6412: [lib] add emoji tests file.

Encourage you to only use arc patch for pulling in other people's work going forward – it's typically a "crutch" for not understanding git well enough. Try to use git cherry-pick if you need to get a commit from another branch into the current one

Jan 27 2023, 8:45 AM
ginsu closed D6412: [lib] add emoji tests file.
Jan 27 2023, 7:56 AM
ginsu committed rCOMMadc6be45d0b6: [lib] add emoji tests file (authored by ginsu).
[lib] add emoji tests file
Jan 27 2023, 7:56 AM
ginsu added a comment to D6412: [lib] add emoji tests file.

How do you think the file was missed in the original land?

Jan 27 2023, 7:54 AM

Jan 26 2023

ginsu requested review of D6413: [native] add rn-emoji-keyboard dependency.
Jan 26 2023, 11:25 PM
ginsu requested review of D6412: [lib] add emoji tests file.
Jan 26 2023, 8:53 PM
ginsu closed D6399: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider.
Jan 26 2023, 8:14 PM
ginsu committed rCOMMf5f65e7157d0: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip… (authored by ginsu).
[web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip…
Jan 26 2023, 8:14 PM
ginsu closed D6398: [keyserver] change reaction type from just like emoji to any emoji.
Jan 26 2023, 8:14 PM
ginsu committed rCOMM7a70f73090bb: [keyserver] change reaction type from just like emoji to any emoji (authored by ginsu).
[keyserver] change reaction type from just like emoji to any emoji
Jan 26 2023, 8:14 PM
ginsu closed D6409: [lib] bump emoji-regex version to 10.2.1.
Jan 26 2023, 8:11 PM
ginsu committed rCOMM25ee6809e5bf: [lib] bump emoji-regex version to 10.2.1 (authored by ginsu).
[lib] bump emoji-regex version to 10.2.1
Jan 26 2023, 8:11 PM
ginsu added inline comments to D6409: [lib] bump emoji-regex version to 10.2.1.
Jan 26 2023, 8:02 PM
ginsu attached a referenced file: F346459: Screenshot 2023-01-26 at 7.23.19 PM.png.
Jan 26 2023, 4:23 PM
ginsu retitled D6398: [keyserver] change reaction type from just like emoji to any emoji from [keyserver] change reaction type from just like to any string to [keyserver] change reaction type from just like emoji to any emoji.
Jan 26 2023, 4:23 PM
ginsu requested review of D6409: [lib] bump emoji-regex version to 10.2.1.
Jan 26 2023, 4:22 PM
ginsu updated the diff for D6398: [keyserver] change reaction type from just like emoji to any emoji.

add jest tests for onlyOneEmojiRegex

Jan 26 2023, 4:21 PM
ginsu updated the summary of D6398: [keyserver] change reaction type from just like emoji to any emoji.
Jan 26 2023, 4:12 PM
ginsu added a comment to D6399: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider.

Curious why setRenderEmojiKeyboard(...) is optional. Could totally just be missing something.

Jan 26 2023, 2:58 PM
ginsu updated the diff for D6399: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider.

made setRenderEmojiKeyboard non optional

Jan 26 2023, 2:58 PM
ginsu updated the diff for D6398: [keyserver] change reaction type from just like emoji to any emoji.

address ashoat's feedback

Jan 26 2023, 2:47 PM
ginsu requested review of D6403: [web] remove message like tooltip button component.
Jan 26 2023, 12:26 PM
ginsu requested review of D6402: [web] switch like button to react button on message tooltip.
Jan 26 2023, 12:15 PM
ginsu requested review of D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.
Jan 26 2023, 12:07 PM
ginsu planned changes to D6398: [keyserver] change reaction type from just like emoji to any emoji.
Jan 26 2023, 12:07 PM
ginsu added a comment to D6398: [keyserver] change reaction type from just like emoji to any emoji.

Could an attacker hit this endpoint with a weird string and mess with things? It feels like we should introduce some sort of validation to make sure the input is good

Jan 26 2023, 12:05 PM
ginsu requested review of D6399: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider.
Jan 26 2023, 12:03 PM
ginsu updated the summary of D6398: [keyserver] change reaction type from just like emoji to any emoji.
Jan 26 2023, 12:02 PM
ginsu requested review of D6398: [keyserver] change reaction type from just like emoji to any emoji.
Jan 26 2023, 12:00 PM
ginsu closed D6362: [web] add emoji-mart dependency.
Jan 26 2023, 8:54 AM
ginsu committed rCOMM6fff0861a75e: [web] add emoji-mart dependency (authored by ginsu).
[web] add emoji-mart dependency
Jan 26 2023, 8:54 AM

Jan 24 2023

ginsu added a comment to D6362: [web] add emoji-mart dependency.

Still not sure why the uid for react-native-flipper is getting removed. Wondering if @ashoat/ @tomek have some context

Jan 24 2023, 1:53 PM
ginsu updated the diff for D6362: [web] add emoji-mart dependency.

added dependencies directly to package.json and ran yarn cleaninstall

Jan 24 2023, 1:51 PM
ginsu closed D6351: [native] implement new InlineEngagement design.
Jan 24 2023, 1:18 PM
ginsu committed rCOMMb0c1ad95d9ca: [native] implement new InlineEngagement design (authored by ginsu).
[native] implement new InlineEngagement design
Jan 24 2023, 1:18 PM
ginsu closed D6318: [web] implement new InlineEngagement design.
Jan 24 2023, 1:18 PM
ginsu closed D6350: [native] introduce MessageReactionsModal.
Jan 24 2023, 1:18 PM
ginsu committed rCOMM1401e536a93c: [web] implement new InlineEngagement design (authored by ginsu).
[web] implement new InlineEngagement design
Jan 24 2023, 1:18 PM
ginsu committed rCOMM4f331467faf7: [native] introduce MessageReactionsModal (authored by ginsu).
[native] introduce MessageReactionsModal
Jan 24 2023, 1:18 PM
ginsu closed D6302: [web/lib] introduce MessageReactionsModal.
Jan 24 2023, 1:18 PM
ginsu committed rCOMM2d9f99f71578: [web/lib] introduce MessageReactionsModal (authored by ginsu).
[web/lib] introduce MessageReactionsModal
Jan 24 2023, 1:18 PM
ginsu updated the diff for D6351: [native] implement new InlineEngagement design.

address atul's comments

Jan 24 2023, 1:03 PM
ginsu updated the diff for D6350: [native] introduce MessageReactionsModal.

remove unnecessary margin

Jan 24 2023, 12:56 PM
ginsu updated the diff for D6350: [native] introduce MessageReactionsModal.

address atul's comments

Jan 24 2023, 12:54 PM
ginsu added inline comments to D6350: [native] introduce MessageReactionsModal.
Jan 24 2023, 12:50 PM
ginsu updated the diff for D6318: [web] implement new InlineEngagement design.

address atuls comments

Jan 24 2023, 12:35 PM
ginsu added inline comments to D6318: [web] implement new InlineEngagement design.
Jan 24 2023, 12:30 PM
ginsu added a comment to D6362: [web] add emoji-mart dependency.

Wonder if you just ran yarn cleaninstall from the root of the repo if things would get fixed up?

Jan 24 2023, 10:36 AM
ginsu added a comment to D6362: [web] add emoji-mart dependency.

Are you using yarn add {dependency} workflow or are you making the addition to package.json manually?

Jan 24 2023, 10:25 AM
ginsu updated the diff for D6362: [web] add emoji-mart dependency.

include @emoji-mart/data dependency

Jan 24 2023, 10:05 AM
ginsu requested review of D6362: [web] add emoji-mart dependency.
Jan 24 2023, 9:36 AM
ginsu retitled D6302: [web/lib] introduce MessageReactionsModal from [web] introduce MessageReactionsModal to [web/lib] introduce MessageReactionsModal.
Jan 24 2023, 8:44 AM
ginsu abandoned D6348: [web/lib] put logic for creating message reaction list in reaction utils.

Merged with D6302

Jan 24 2023, 8:42 AM
ginsu updated the diff for D6302: [web/lib] introduce MessageReactionsModal.

address ashoat's comments

Jan 24 2023, 8:41 AM
ginsu updated the diff for D6351: [native] implement new InlineEngagement design.

address ashoat's comments

Jan 24 2023, 8:40 AM

Jan 23 2023

ginsu updated the diff for D6348: [web/lib] put logic for creating message reaction list in reaction utils.

rebase

Jan 23 2023, 11:46 AM