Page MenuHomePhorge
Feed Search

Nov 2 2023

ginsu requested review of D9673: [lib] correctly skip using established socket when urlPrefix is overriden.
Nov 2 2023, 8:31 AM
ginsu added inline comments to D9667: [lib/native] add keyserver url validation logic and error handling to the add keyserver screen.
Nov 2 2023, 8:08 AM
ginsu updated the diff for D9666: [lib/native] introduce useIsKeyserverURLValid hook.

update

Nov 2 2023, 7:58 AM
ginsu added inline comments to D9666: [lib/native] introduce useIsKeyserverURLValid hook.
Nov 2 2023, 7:57 AM

Nov 1 2023

ginsu updated the diff for D9664: [lib] add conditions for adding keyserver to the keyserver store.

update

Nov 1 2023, 6:48 PM
ginsu updated the diff for D9664: [lib] add conditions for adding keyserver to the keyserver store.

address @ashoat's comment

Nov 1 2023, 6:44 PM
ginsu accepted D9167: [lib] Introduce new avatar type for encrypted images.

Looks good, but please make sure to address @ashoat's inline comment + rebase and make sure the CI passes before landing

Nov 1 2023, 6:19 PM
ginsu requested review of D9667: [lib/native] add keyserver url validation logic and error handling to the add keyserver screen.
Nov 1 2023, 5:43 AM
ginsu requested review of D9666: [lib/native] introduce useIsKeyserverURLValid hook.
Nov 1 2023, 5:31 AM
ginsu closed D9591: [native] introduce addKeyserverActionType.
Nov 1 2023, 5:19 AM
ginsu committed rCOMM07c3986f8c52: [native] introduce addKeyserverActionType.
Nov 1 2023, 5:19 AM
ginsu closed D9590: [native] introduce Add keyserver screen UI.
Nov 1 2023, 5:19 AM
ginsu committed rCOMM50808c71ec3f: [native] introduce Add keyserver screen UI.
Nov 1 2023, 5:19 AM
ginsu requested review of D9665: [native] implement onPressSave keyserver button callback.
Nov 1 2023, 4:52 AM
ginsu updated the diff for D9591: [native] introduce addKeyserverActionType.

rebase before landing

Nov 1 2023, 4:44 AM
ginsu updated the diff for D9590: [native] introduce Add keyserver screen UI.

rebase before landing

Nov 1 2023, 4:42 AM
ginsu added a comment to D9590: [native] introduce Add keyserver screen UI.

Do the diffs for filling in the missing // TODO exist?

Nov 1 2023, 4:41 AM
ginsu requested review of D9664: [lib] add conditions for adding keyserver to the keyserver store.
Nov 1 2023, 4:39 AM
ginsu closed D9641: [lib] introduce selected keyservers selector.
Nov 1 2023, 4:23 AM
ginsu committed rCOMM6dfc1c43efbd: [lib] introduce selected keyservers selector.
Nov 1 2023, 4:23 AM
ginsu closed D9639: [lib] introduce KeyserverInfos type.
Nov 1 2023, 4:23 AM
ginsu committed rCOMMa05da78f5178: [lib] introduce KeyserverInfos type.
Nov 1 2023, 4:23 AM
ginsu updated the diff for D9641: [lib] introduce selected keyservers selector.

update

Nov 1 2023, 3:46 AM

Oct 31 2023

ginsu updated the diff for D9641: [lib] introduce selected keyservers selector.

address @rohan's comments + rebase before landing

Oct 31 2023, 7:07 PM
ginsu added inline comments to D9641: [lib] introduce selected keyservers selector.
Oct 31 2023, 7:04 PM
ginsu updated the diff for D9639: [lib] introduce KeyserverInfos type.

rebase before landing

Oct 31 2023, 6:39 PM
ginsu requested review of D9643: [native] display connnection state of keyserver.
Oct 31 2023, 9:02 AM
ginsu requested review of D9642: [native] implement keyserver list ui.
Oct 31 2023, 8:58 AM
ginsu requested review of D9641: [lib] introduce selected keyservers selector.
Oct 31 2023, 8:46 AM
ginsu requested review of D9639: [lib] introduce KeyserverInfos type.
Oct 31 2023, 8:09 AM

Oct 26 2023

ginsu closed D9587: [native] introduce KeyserverSelectionListAddButton.
Oct 26 2023, 8:12 PM
ginsu committed rCOMMd979f2ce4b1e: [native] introduce KeyserverSelectionListAddButton.
Oct 26 2023, 8:12 PM
ginsu closed D9586: [native] introduce HeaderRightTextButton.
Oct 26 2023, 8:12 PM
ginsu committed rCOMMf5429de51d2c: [native] introduce HeaderRightTextButton.
Oct 26 2023, 8:12 PM
ginsu updated the diff for D9587: [native] introduce KeyserverSelectionListAddButton.

rebase before landing

Oct 26 2023, 6:52 PM
ginsu updated the diff for D9586: [native] introduce HeaderRightTextButton.

rebase before landing

Oct 26 2023, 6:35 PM
ginsu closed D9604: [web] fix user profile long username bug.
Oct 26 2023, 6:31 PM
ginsu committed rCOMM10bd397d84d4: [web] fix user profile long username bug.
Oct 26 2023, 6:31 PM
ginsu updated the diff for D9604: [web] fix user profile long username bug.

rebase before landing

Oct 26 2023, 6:30 PM
ginsu added inline comments to D9604: [web] fix user profile long username bug.
Oct 26 2023, 6:29 PM
ginsu closed D9603: [landing] replace Patryk with Monika on team page.
Oct 26 2023, 6:06 PM
ginsu committed rCOMM2957186830f5: [landing] replace Patryk with Monika on team page.
Oct 26 2023, 6:06 PM
ginsu requested review of D9604: [web] fix user profile long username bug.
Oct 26 2023, 3:46 AM
ginsu requested review of D9603: [landing] replace Patryk with Monika on team page.
Oct 26 2023, 2:50 AM
ginsu added a comment to D9580: [web] introduce AppThemeWrapper.

While this is true, defaultGlobalThemeInfo defaults to dark mode, which means the app defaults to dark mode. I assume we're doing the same on web?

Oct 26 2023, 2:37 AM

Oct 25 2023

ginsu requested review of D9591: [native] introduce addKeyserverActionType.
Oct 25 2023, 4:38 AM
ginsu requested review of D9590: [native] introduce Add keyserver screen UI.
Oct 25 2023, 4:28 AM
ginsu closed D9582: [web] introduce light mode to the account settings screen.
Oct 25 2023, 3:09 AM
ginsu closed D9583: [web] introduce light mode to danger zone component.
Oct 25 2023, 3:09 AM
ginsu committed rCOMMabeda0ea88cf: [web] introduce light mode to the account settings screen.
Oct 25 2023, 3:09 AM
ginsu committed rCOMM558aef52fb7e: [web] introduce light mode to danger zone component.
Oct 25 2023, 3:09 AM
ginsu closed D9580: [web] introduce AppThemeWrapper.
Oct 25 2023, 3:09 AM
ginsu committed rCOMM1250e84f80d3: [web] introduce AppThemeWrapper.
Oct 25 2023, 3:09 AM
ginsu updated the diff for D9583: [web] introduce light mode to danger zone component.

rebase before landing

Oct 25 2023, 2:45 AM
ginsu updated the diff for D9582: [web] introduce light mode to the account settings screen.

address @atul's comments + rebase before landing

Oct 25 2023, 2:42 AM
ginsu updated the diff for D9580: [web] introduce AppThemeWrapper.

rebase before landing

Oct 25 2023, 2:35 AM

Oct 24 2023

ginsu updated the diff for D9587: [native] introduce KeyserverSelectionListAddButton.

rebase

Oct 24 2023, 11:41 PM
ginsu retitled D9586: [native] introduce HeaderRightTextButton from [native] introduce HeaderRightAddButton
Oct 24 2023, 11:38 PM
ginsu added inline comments to D9586: [native] introduce HeaderRightTextButton.
Oct 24 2023, 11:38 PM
ginsu updated the diff for D9586: [native] introduce HeaderRightTextButton.

update

Oct 24 2023, 11:36 PM
ginsu added inline comments to D9580: [web] introduce AppThemeWrapper.
Oct 24 2023, 10:25 PM
ginsu requested review of D9587: [native] introduce KeyserverSelectionListAddButton.

requesting review for now, will rebase/confirm that all builds succeed when CI is more stable

Oct 24 2023, 10:00 PM
ginsu closed D9566: [native] introduce barebones keyserver selection list screen.
Oct 24 2023, 9:42 PM
ginsu committed rCOMMa5d69348e54d: [native] introduce barebones keyserver selection list screen.
Oct 24 2023, 9:42 PM
ginsu closed D9565: [native] introduce Keyserver selection settings panel in user settings.
Oct 24 2023, 9:42 PM
ginsu committed rCOMM80a3440fed66: [native] introduce Keyserver selection settings panel in user settings.
Oct 24 2023, 9:42 PM
ginsu requested review of D9586: [native] introduce HeaderRightTextButton.
Oct 24 2023, 9:32 PM
ginsu updated the diff for D9566: [native] introduce barebones keyserver selection list screen.

rebase before landing

Oct 24 2023, 8:29 PM
ginsu updated the diff for D9565: [native] introduce Keyserver selection settings panel in user settings.

rebase before landing

Oct 24 2023, 8:28 PM
ginsu requested review of D9583: [web] introduce light mode to danger zone component.
Oct 24 2023, 8:16 PM
ginsu requested review of D9582: [web] introduce light mode to the account settings screen.
Oct 24 2023, 8:10 PM
ginsu requested review of D9580: [web] introduce AppThemeWrapper.
Oct 24 2023, 7:52 PM

Oct 23 2023

ginsu published D9566: [native] introduce barebones keyserver selection list screen for review.
Oct 23 2023, 6:25 PM
ginsu published D9565: [native] introduce Keyserver selection settings panel in user settings for review.
Oct 23 2023, 6:20 PM
ginsu closed D9554: [web] update AppearanceChangeModal buttons to use redux state.
Oct 23 2023, 6:15 PM
ginsu closed D9553: [lib/native] introduce useUpdateThemePreference.
Oct 23 2023, 6:15 PM
ginsu committed rCOMM3c42ecffc737: [web] update AppearanceChangeModal buttons to use redux state.
Oct 23 2023, 6:15 PM
ginsu closed D9552: [web] introduce redux persist migration for globalThemeInfo.
Oct 23 2023, 6:15 PM
ginsu committed rCOMM4d90492abaeb: [lib/native] introduce useUpdateThemePreference.
Oct 23 2023, 6:14 PM
ginsu committed rCOMMabf2583fc896: [web] introduce redux persist migration for globalThemeInfo.
Oct 23 2023, 6:14 PM
ginsu closed D9551: [lib/native] introduce useUpdateSystemTheme.
Oct 23 2023, 6:14 PM
ginsu committed rCOMM736e75a1fd24: [lib/native] introduce useUpdateSystemTheme.
Oct 23 2023, 6:14 PM
ginsu closed D9550: [lib/native/web] lift globalThemeInfo redux state into lib.
Oct 23 2023, 6:14 PM
ginsu committed rCOMM476f6b9930f3: [lib/native/web] lift globalThemeInfo redux state into lib.
Oct 23 2023, 6:14 PM
ginsu updated the diff for D9554: [web] update AppearanceChangeModal buttons to use redux state.

address @atul's comments + rebase before landing

Oct 23 2023, 6:06 PM
ginsu updated the diff for D9553: [lib/native] introduce useUpdateThemePreference.

rebase before landing

Oct 23 2023, 6:03 PM
ginsu updated the diff for D9552: [web] introduce redux persist migration for globalThemeInfo.

rebase before landing

Oct 23 2023, 6:02 PM
ginsu updated the diff for D9551: [lib/native] introduce useUpdateSystemTheme.

rebase before landing

Oct 23 2023, 6:01 PM
ginsu updated the diff for D9550: [lib/native/web] lift globalThemeInfo redux state into lib.

rebase before landing

Oct 23 2023, 5:59 PM
ginsu added a comment to D9550: [lib/native/web] lift globalThemeInfo redux state into lib.

Does the native concept of a theme translate cleanly into the web concept? Does web have access to the "system theme" selected by the user? Does the API for accessing it mirror the native ones?

Oct 23 2023, 5:53 PM

Oct 20 2023

ginsu requested review of D9554: [web] update AppearanceChangeModal buttons to use redux state.
Oct 20 2023, 8:00 AM
ginsu requested review of D9553: [lib/native] introduce useUpdateThemePreference.
Oct 20 2023, 7:51 AM
ginsu requested review of D9552: [web] introduce redux persist migration for globalThemeInfo.
Oct 20 2023, 7:42 AM
ginsu requested review of D9551: [lib/native] introduce useUpdateSystemTheme.
Oct 20 2023, 7:36 AM
ginsu requested review of D9550: [lib/native/web] lift globalThemeInfo redux state into lib.
Oct 20 2023, 7:27 AM
ginsu closed D9530: [lib/naitve] lift update theme info action type into lib.
Oct 20 2023, 12:55 AM
ginsu committed rCOMM6d63cec0abc8: [lib/naitve] lift update theme info action type into lib.
Oct 20 2023, 12:55 AM
ginsu closed D9529: [native] rename native themes-types to theme-utils.
Oct 20 2023, 12:55 AM
ginsu closed D9528: [lib/native] lift theme types from native into lib.
Oct 20 2023, 12:55 AM
ginsu committed rCOMM77d262dbe0cc: [native] rename native themes-types to theme-utils.
Oct 20 2023, 12:55 AM