- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 3 2024
Jun 3 2024
atul published D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` for review.
atul published D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar` for review.
atul committed rCOMMc2da721a842f: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock` (authored by atul).
[lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`
atul updated the diff for D12266: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`.
rebase and land
Jun 1 2024
Jun 1 2024
atul requested review of D12266: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`.
May 31 2024
May 31 2024
atul requested review of D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`.
atul committed rCOMM3e1eaaa86882: [lib] Fix `containingThreadID` typo in `usePotentialMemberItems` (authored by atul).
[lib] Fix `containingThreadID` typo in `usePotentialMemberItems`
land
atul committed rCOMMa962807ac47f: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly` (authored by atul).
[lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
make entries of ThreadIsWithBlockedUserOnlyOptions read-only
atul updated the test plan for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
atul added inline comments to D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
May 30 2024
May 30 2024
remove unnecessary spread
update and amend
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
"create some sort of options object for threadIsWithBlockedUserOnly"
I'd like to understand a bit more why this is safe to do at this time.
atul committed rCOMMa9069cb74360: [lib] Narrow `threadHasPermission` so it only accepts… (authored by atul).
[lib] Narrow `threadHasPermission` so it only accepts…
atul updated the diff for D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
now we should be good to land this
atul committed rCOMMc1af1165ee37: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
atul updated the diff for D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
remove extraneous threadInfo from useEffect + deplist
atul added inline comments to D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
partially address feedback
atul updated the diff for D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
address @tomek's feedback
atul added inline comments to D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
atul updated the diff for D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
rebase before addressing feedback
rebase before addressing feedback
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
rebase before addressing feedback
atul updated the diff for D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
rebase before addressing feedback
atul added a comment to D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
Ah, got to land D11753 before I can land this one. Will update that diff to get it land-able.
atul updated the diff for D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
rebase and land
atul committed rCOMM2d73eae9c45a: [lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions` (authored by atul).
[lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions`
atul updated the diff for D12245: [lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions`.
rebase and land
atul added inline comments to D12245: [lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions`.
atul added a comment to D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
The high level goal of this work was to remove non-viewer/non-admin computed Member permissions to reduce space taken up by them on the clients.
May 29 2024
May 29 2024
atul requested review of D12245: [lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions`.
atul committed rCOMMe31838429e78: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly`… (authored by atul).
[lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly`…
atul updated the diff for D12150: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly` required.
ready to land
atul updated the diff for D12150: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly` required.
rebase
atul committed rCOMM977cb22b3010: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission` (authored by atul).
[lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`
atul updated the diff for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
ready to land
atul updated the test plan for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
atul updated the diff for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
fix logic to handle undefined case
atul updated the diff for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
address feedback before updating test plan and before landing
atul committed rCOMM7e09588162a4: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex` (authored by atul).
[lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex`
atul updated the test plan for D12145: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex`.
atul updated the diff for D12145: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex`.
address feedback before updating test plan and before landing
May 21 2024
May 21 2024
atul published D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly` for review.
atul published D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission` for review.
atul published D12145: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex` for review.
May 15 2024
May 15 2024
atul committed rCOMM9a0a2d05b565: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread` (authored by atul).
[lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`
atul committed rCOMM9789033fdcb4: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal` (authored by atul).
[web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`
atul committed rCOMM931f3491dd4b: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads` (authored by atul).
[lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`
atul updated the test plan for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
atul updated the test plan for D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.
atul updated the test plan for D11980: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.
May 14 2024
May 14 2024
atul updated the diff for D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.
fix
atul updated the diff for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
address feedback before landing
atul updated the test plan for D11980: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.
atul updated the test plan for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
atul updated the diff for D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.
resolve merge conflicts
atul updated the diff for D11980: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.
resolve merge conflicts
atul updated the diff for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
resolve merge conflicts
atul committed rCOMM0ab6a315ac2d: [lib] Introduce `useOnScreenEntryEditableThreadInfos` (authored by atul).
[lib] Introduce `useOnScreenEntryEditableThreadInfos`
land
atul committed rCOMM25680afe29ab: [lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s (authored by atul).
[lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s
atul updated the diff for D11924: [lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s.
address feedback and land
atul updated the test plan for D11924: [lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s.
atul committed rCOMMd90270ac68f8: [native] Consume `useThreadInChatList` in `native/ThreadSettings` (authored by atul).
[native] Consume `useThreadInChatList` in `native/ThreadSettings`
atul updated the diff for D11916: [native] Consume `useThreadInChatList` in `native/ThreadSettings`.
address feedback (useThreadInChatList -> useIsThreadInChatList)