Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Thu, Nov 28

angelika committed rCOMM1d992bd69d6b: [native] Move text update and editing logic in ChatInputBar to function… (authored by angelika).

[native] Move text update and editing logic in ChatInputBar to function…

Thu, Nov 28, 5:12 PM

angelika committed rCOMM3c5be31f62b3: [native] Move text input refs in ChatInputBar to function component (authored by angelika).

[native] Move text input refs in ChatInputBar to function component

Thu, Nov 28, 5:12 PM

angelika closed D14010: [native] Move button expansion logic in ChatInputBar to function component.

Thu, Nov 28, 5:12 PM

angelika closed D14009: [native] Move Reanimated definitions in ChatInputBar to function component.

Thu, Nov 28, 5:12 PM

angelika committed rCOMM4af634331c67: [native] Move button expansion logic in ChatInputBar to function component (authored by angelika).

[native] Move button expansion logic in ChatInputBar to function component

Thu, Nov 28, 5:12 PM

angelika committed rCOMM5931501647f8: [native] Move Reanimated definitions in ChatInputBar to function component (authored by angelika).

[native] Move Reanimated definitions in ChatInputBar to function component

Thu, Nov 28, 5:12 PM

angelika closed D14008: [native] Move isExitingDuringEditMode in ChatInputBar to a ref in function component.

Thu, Nov 28, 5:12 PM

angelika committed rCOMM1704349e4f67: [native] Move isExitingDuringEditMode in ChatInputBar to a ref in function… (authored by angelika).

[native] Move isExitingDuringEditMode in ChatInputBar to a ref in function…

Thu, Nov 28, 5:12 PM

angelika closed D14007: [native] Move buttonsExpanded in ChatInputBar to function component.

Thu, Nov 28, 5:12 PM

angelika committed rCOMMafbdd826c734: [native] Move buttonsExpanded in ChatInputBar to function component (authored by angelika).

[native] Move buttonsExpanded in ChatInputBar to function component

Thu, Nov 28, 5:12 PM

angelika closed D14006: [native] Move text state in ChatInputBar to function component.

Thu, Nov 28, 5:12 PM

angelika committed rCOMMc89b46e94e74: [native] Move text state in ChatInputBar to function component (authored by angelika).

[native] Move text state in ChatInputBar to function component

Thu, Nov 28, 5:12 PM

Tue, Nov 26

angelika requested review of D14020: [native] Migrate ChatInputBar component to Reanimated v2 API.

Tue, Nov 26, 4:31 PM

angelika updated the diff for D14020: [native] Migrate ChatInputBar component to Reanimated v2 API.

Fix rebase

Tue, Nov 26, 5:28 AM

angelika updated the diff for D14019: [native] Use destructuring syntax in ChatInputBar component.

Fix rebase

Tue, Nov 26, 5:28 AM

angelika updated the diff for D14018: [native] Move render functions in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:27 AM

angelika updated the diff for D14017: [native] Migrate componentDidUpdate() in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:27 AM

angelika updated the diff for D14016: [native] Move keyboard handling in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:27 AM

angelika updated the diff for D14015: [native] Move join thread functions in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:27 AM

angelika updated the diff for D14014: [native] Move edit message listeners set up in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:26 AM

angelika updated the diff for D14013: [native] Move navigation related callbacks in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:26 AM

angelika updated the diff for D14012: [native] Move text update and editing logic in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:26 AM

angelika updated the diff for D14011: [native] Move text input refs in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:26 AM

angelika updated the diff for D14010: [native] Move button expansion logic in ChatInputBar to function component.

Fix rebase

Tue, Nov 26, 5:25 AM

Mon, Nov 25

angelika updated the diff for D14020: [native] Migrate ChatInputBar component to Reanimated v2 API.

Rebase and review changes

Mon, Nov 25, 7:23 AM

angelika updated the diff for D14019: [native] Use destructuring syntax in ChatInputBar component.

Rebase and review changes

Mon, Nov 25, 7:23 AM

angelika updated the diff for D14018: [native] Move render functions in ChatInputBar to function component.

Rebase and review changes

Mon, Nov 25, 7:22 AM

angelika updated the diff for D14017: [native] Migrate componentDidUpdate() in ChatInputBar to function component.

Rebase and review changes

Mon, Nov 25, 7:22 AM

angelika updated the diff for D14016: [native] Move keyboard handling in ChatInputBar to function component.

Rebase and review changes

Mon, Nov 25, 7:22 AM

angelika updated the diff for D14015: [native] Move join thread functions in ChatInputBar to function component.

Rebase and review changes

Mon, Nov 25, 7:21 AM

angelika updated the diff for D14014: [native] Move edit message listeners set up in ChatInputBar to function component.

Rebase and review changes

Mon, Nov 25, 7:21 AM

angelika updated the diff for D14013: [native] Move navigation related callbacks in ChatInputBar to function component.

Rebase and review changes

Mon, Nov 25, 7:21 AM

angelika updated the diff for D14012: [native] Move text update and editing logic in ChatInputBar to function component.

Rebase and review changes

Mon, Nov 25, 7:20 AM

angelika updated the diff for D14011: [native] Move text input refs in ChatInputBar to function component.

Review changes

Mon, Nov 25, 7:20 AM

angelika updated the diff for D14010: [native] Move button expansion logic in ChatInputBar to function component.

Rebase

Mon, Nov 25, 7:20 AM

angelika updated the diff for D14009: [native] Move Reanimated definitions in ChatInputBar to function component.

Review changes

Mon, Nov 25, 5:09 AM

Fri, Nov 22

angelika requested review of D14023: [lib] Don't created thin thread if call to identity server failed when adding friends.

Fri, Nov 22, 1:40 PM

angelika requested review of D14022: [lib] Check if device list exists instead of using userHasDeviceList() in useUsersSupportThickThreads().

Fri, Nov 22, 1:33 PM

angelika abandoned D13940: [lib] Don't swallow errors in getUserIdentities() call.

Made changes in this diff: https://phab.comm.dev/D14023

Fri, Nov 22, 1:25 PM

angelika abandoned D13939: [lib] Consider thread infos in useUsersSupportThickThreads().

Made the above change in https://phab.comm.dev/D14022

Fri, Nov 22, 1:24 PM

angelika updated the diff for D13938: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in useUpdateRelationships().

Rebase

Fri, Nov 22, 1:12 PM

angelika requested review of D14007: [native] Move buttonsExpanded in ChatInputBar to function component.

Fri, Nov 22, 10:35 AM

Nov 22 2024

angelika requested review of D14020: [native] Migrate ChatInputBar component to Reanimated v2 API.

Nov 22 2024, 6:39 AM

angelika requested review of D14019: [native] Use destructuring syntax in ChatInputBar component.

Nov 22 2024, 6:29 AM

angelika requested review of D14018: [native] Move render functions in ChatInputBar to function component.

Nov 22 2024, 6:21 AM

angelika requested review of D14017: [native] Migrate componentDidUpdate() in ChatInputBar to function component.

Nov 22 2024, 6:14 AM

angelika requested review of D14016: [native] Move keyboard handling in ChatInputBar to function component.

Nov 22 2024, 6:05 AM

angelika requested review of D14015: [native] Move join thread functions in ChatInputBar to function component.

Nov 22 2024, 5:56 AM

angelika requested review of D14014: [native] Move edit message listeners set up in ChatInputBar to function component.

Nov 22 2024, 5:47 AM

angelika requested review of D14013: [native] Move navigation related callbacks in ChatInputBar to function component.

Nov 22 2024, 5:39 AM

angelika requested review of D14012: [native] Move text update and editing logic in ChatInputBar to function component.

Nov 22 2024, 5:30 AM

angelika requested review of D14011: [native] Move text input refs in ChatInputBar to function component.

Nov 22 2024, 5:22 AM

angelika requested review of D14010: [native] Move button expansion logic in ChatInputBar to function component.

Nov 22 2024, 5:14 AM

angelika requested review of D14009: [native] Move Reanimated definitions in ChatInputBar to function component.

Nov 22 2024, 5:06 AM

angelika requested review of D14006: [native] Move text state in ChatInputBar to function component.

Nov 22 2024, 5:01 AM

angelika requested review of D14008: [native] Move isExitingDuringEditMode in ChatInputBar to a ref in function component.

Nov 22 2024, 4:57 AM

Nov 20 2024

angelika added a comment to D13939: [lib] Consider thread infos in useUsersSupportThickThreads().

@ashoat Do I understand correctly that the threads check is not needed and I just need to check for existence of device list instead of using userHasDeviceList?

Nov 20 2024, 4:06 AM

Nov 19 2024

angelika closed D13952: [keyserver] Log on keyserver when session recovery is attempted.

Nov 19 2024, 5:31 AM

angelika committed rCOMM601de810f74f: [keyserver] Log on keyserver when session recovery is attempted (authored by angelika).

[keyserver] Log on keyserver when session recovery is attempted

Nov 19 2024, 5:31 AM

angelika closed D13951: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is sent to the client.

Nov 19 2024, 5:30 AM

angelika committed rCOMM287b768e8ff4: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is… (authored by angelika).

[keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is…

Nov 19 2024, 5:30 AM

angelika closed D13961: [lib] Add staff-only alert when client attempts keyserver session recovery.

Nov 19 2024, 3:32 AM

angelika committed rCOMM6259cebd7864: [lib] Add staff-only alert when client attempts keyserver session recovery (authored by angelika).

[lib] Add staff-only alert when client attempts keyserver session recovery

Nov 19 2024, 3:32 AM

angelika closed D13953: [lib] Add staff-only alert for when notifsSessionReassignmentPromise reassigns a notif session.

Nov 19 2024, 3:32 AM

angelika committed rCOMMe39c5d31b44a: [lib] Add staff-only alert for when notifsSessionReassignmentPromise reassigns… (authored by angelika).

[lib] Add staff-only alert for when notifsSessionReassignmentPromise reassigns…

Nov 19 2024, 3:32 AM

angelika closed D13950: [native] Make sure all virtual classes in C++ code base have virtual destructor.

Nov 19 2024, 3:30 AM

angelika committed rCOMM7a608523bf85: [native] Make sure all virtual classes in C++ code base have virtual destructor (authored by angelika).

[native] Make sure all virtual classes in C++ code base have virtual destructor

Nov 19 2024, 3:30 AM

angelika closed D13948: [native] Increase expansion button tap target in community side drawer.

Nov 19 2024, 3:29 AM

angelika committed rCOMMd3f8dfe50344: [native] Increase expansion button tap target in community side drawer (authored by angelika).

[native] Increase expansion button tap target in community side drawer

Nov 19 2024, 3:29 AM

angelika updated the diff for D13952: [keyserver] Log on keyserver when session recovery is attempted.

Review changes

Nov 19 2024, 3:27 AM

angelika updated the diff for D13951: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is sent to the client.

Review comments

Nov 19 2024, 3:25 AM

Nov 18 2024

angelika requested review of D13953: [lib] Add staff-only alert for when notifsSessionReassignmentPromise reassigns a notif session.

Nov 18 2024, 12:10 PM

angelika requested review of D13961: [lib] Add staff-only alert when client attempts keyserver session recovery.

Nov 18 2024, 7:59 AM

angelika requested review of D13952: [keyserver] Log on keyserver when session recovery is attempted.

Nov 18 2024, 6:54 AM

angelika requested review of D13951: [keyserver] Log on keyserver when INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE is sent to the client.

Nov 18 2024, 5:50 AM

angelika updated the diff for D13950: [native] Make sure all virtual classes in C++ code base have virtual destructor.

Review comments

Nov 18 2024, 4:29 AM

angelika added a comment to D13940: [lib] Don't swallow errors in getUserIdentities() call.

I'm also a bit confused as to why this is necessary or what it accomplishes. I re-read through the Linear task but couldn't find anything. Could you explain why we want to stop swallowing errors here?

With swallowing errors in case findUserIdentities fails because for example there is no internet connection, a thin thread will be created.
Without swallowing errors an error message will be shown to the user and no thread is created.

Nov 18 2024, 3:58 AM

Nov 15 2024

angelika requested review of D13950: [native] Make sure all virtual classes in C++ code base have virtual destructor.

Nov 15 2024, 1:52 PM

angelika requested review of D13948: [native] Increase expansion button tap target in community side drawer.

Nov 15 2024, 12:40 PM

Nov 14 2024

angelika requested review of D13939: [lib] Consider thread infos in useUsersSupportThickThreads().

Nov 14 2024, 2:08 PM

angelika requested review of D13940: [lib] Don't swallow errors in getUserIdentities() call.

Nov 14 2024, 2:08 PM

angelika requested review of D13938: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in useUpdateRelationships().

Nov 14 2024, 2:06 PM

Nov 13 2024

angelika closed D13924: [lib] Fix long line in olmSessionErrors.

Nov 13 2024, 11:27 AM

angelika committed rCOMM3e5fbff299f3: [lib] Fix long line in olmSessionErrors (authored by angelika).

[lib] Fix long line in olmSessionErrors

Nov 13 2024, 11:27 AM

angelika closed D13923: [lib] Fix capitalization in usePeerToPeerMessageHandler.

Nov 13 2024, 11:25 AM

angelika committed rCOMMf7cf29b804d1: [lib] Fix capitalization in usePeerToPeerMessageHandler (authored by angelika).

[lib] Fix capitalization in usePeerToPeerMessageHandler

Nov 13 2024, 11:24 AM

angelika closed D13922: [sqlite] Add missing spaces in getInboundP2PMessagesByID query.

Nov 13 2024, 11:22 AM

angelika committed rCOMMadd745dbaf17: [sqlite] Add missing spaces in getInboundP2PMessagesByID query (authored by angelika).

[sqlite] Add missing spaces in getInboundP2PMessagesByID query

Nov 13 2024, 11:22 AM

angelika requested review of D13924: [lib] Fix long line in olmSessionErrors.

Nov 13 2024, 7:04 AM

angelika requested review of D13923: [lib] Fix capitalization in usePeerToPeerMessageHandler.

Nov 13 2024, 6:58 AM

angelika requested review of D13922: [sqlite] Add missing spaces in getInboundP2PMessagesByID query.

Nov 13 2024, 6:55 AM

angelika closed D13909: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().

Nov 13 2024, 6:10 AM

angelika committed rCOMM6c66ce0a270a: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages() (authored by angelika).

[sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages()

Nov 13 2024, 6:10 AM

angelika closed D13908: [sqlite] Read Outbound messages with status different than sent.

Nov 13 2024, 6:10 AM

angelika committed rCOMM825e943afe0f: [sqlite] Read Outbound messages with status different than sent (authored by angelika).

[sqlite] Read Outbound messages with status different than sent

Nov 13 2024, 6:10 AM

angelika updated the diff for D13909: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().

Fix line order

Nov 13 2024, 5:18 AM

angelika updated the diff for D13909: [sqlite] Rename getAllOutboundP2PMessages() to getUnsentOutboundP2PMessages().

Rebase

Nov 13 2024, 4:25 AM

angelika updated the diff for D13908: [sqlite] Read Outbound messages with status different than sent.

Rebase

Nov 13 2024, 4:24 AM

angelika closed D13901: [lib] Do not reset a session when getting already decrypted message.

Nov 13 2024, 4:17 AM

angelika closed D13900: [lib] Implement getInboundP2PMessagesByID in SQLiteAPI.

Nov 13 2024, 4:17 AM