@jon you are blocking here, could you please either accept or request changes? Thanks.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jul 26 2022
Jul 26 2022
• karol added inline comments to D4588: [services] Tunnelbroker - Move init logging to the global tools.
change number of threads
address feedback
• karol requested review of D4635: [services] Tests - Backup - Move compare backups to backup utils.
Jul 25 2022
Jul 25 2022
• karol requested changes to D4511: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use `MessageItem`.
Please, make sure the CI doesn't fail.
• karol updated the diff for D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
address feedback from D4571
rebase
• karol updated the diff for D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
prevent hanging on blocking read for logs
rebase
rebase
• karol updated the diff for D4438: [services] Backup - pull attachment holders out of the data section.
rebase
Jul 22 2022
Jul 22 2022
• karol updated the diff for D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
rebase
fix ci
update the logic so the internal buffer is being sent if it exceeds the limit instead of throwing there
• karol updated the diff for D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
start method name with lowercase
start method name with lowercase
• karol updated the diff for D4555: [services] Backup - pull backup - change logic to use att holders out of data section.
rebase
rename method
rebase
address feedback - number of cores
rebase
rebase
rebase
rebase
receive number of threads from the outside
It does now. It didn't work properly after I switched to m1 but I fixed my local env.
fix source
@jon it would be easier if you used the machine state provided by the phabricator. If you have serious doubts about the code from the diff, please use "request changes". It's easier because it get in my queue and if I am to make any changes, I can just update the diff instead of using "plan changes". Thanks ;)
In D4597#131546, @max wrote:I think it's not a good idea to explicitly out all the logs to file only. Actually, it's a bad practice for microservices.
Jul 21 2022
Jul 21 2022
• karol added 1 blocking reviewer(s) for D4592: [services] Tunnelbroker - remove include iostream: tomek.
• karol added 1 blocking reviewer(s) for D4591: [services] Lib - Remove couts or replace them with glog: tomek.
• karol added 1 blocking reviewer(s) for D4590: [services] Blob - Remove couts or replace them with glog: tomek.
• karol added 1 blocking reviewer(s) for D4589: [services] Backup - Remove couts or replace them with glog: tomek.
• karol added 1 blocking reviewer(s) for D4588: [services] Tunnelbroker - Move init logging to the global tools: tomek.
address feedback
Ok, put formatting in D4598
rename as requested, increate internal buffer limit
• karol updated the diff for D4588: [services] Tunnelbroker - Move init logging to the global tools.
rebase to master + CI
One TODO: What if we spawn more than one instance of the same service in one docker container? We should probably use some uuid to avoid having the logs mixed up.
Publishing the draft. CI failed for the services but that's expected. When I push the new version of the base image to the hub, it will pass.
Services built properly
Services built properly
Services built properly
Services built properly
Services built properly
Services built properly
Services built properly
Services built properly
• karol added reviewers for D4583: [services] Tests - Add GET for Blob performance tests: tomek, varun.
Jul 20 2022
Jul 20 2022
lazily add stuff
lazily add stuff
clean up