address feedback
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Aug 2 2022
Aug 2 2022
Aug 1 2022
Aug 1 2022
• karol updated the diff for D4667: [services] Tests - Backup - Calculate a real hash for backups/logs.
Jul 29 2022
Jul 29 2022
• karol added a comment to D4667: [services] Tests - Backup - Calculate a real hash for backups/logs.
It would be better to have an abstraction over hash algorithm so that when we decide to change it, we don't need to modify its usages.
Jul 28 2022
Jul 28 2022
• karol requested review of D4667: [services] Tests - Backup - Calculate a real hash for backups/logs.
rebase
rebase
rebase
rebase
rebase
rebase
rebase
rebase
rebase
rebase
In D4631#133050, @tomek wrote:We can consider extracting some common logic from this and D4581. We can e.g. create a function that determines number of threads and use it in both places.
address feedback
borrow
address feedback, fix build
Jul 27 2022
Jul 27 2022
• karol requested review of D4651: [services] Blob - PullBackupReactor - Simplify write response logic.
Jul 26 2022
Jul 26 2022
address feedback
rebase
mention that the default value is the number of CPUs
• karol updated the diff for D4635: [services] Tests - Backup - Move compare backups to backup utils.
rebase
address feedback
remove duplicated variable
address feedback - remove redundant log and refactor the loop
• karol accepted D4638: [services] Tunnelbroker - Changing the `ConfigManager` load function to include the sandbox condition.
How did it work before without an argument provided?
What does this launch? CryptoTest.mm? Anything else?
No need to wait for the mobile builds
Ok, I think this diff can be abandoned
Ok, I think this diff can be abandoned
How about tunnelbroker ad backup? I think we should have a consistent way of installing this in every service.
Separately, if glog's used in all of them, why don't we install it in the base image and just use the installed version in the child images instead force the children to install/pull it (which essentially leads to wasting time when building child images for the first time)?