Might be best to tuck the gallery away behind another screen. Something that you'll want to discuss with Ted
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Jan 30 2023
rebase and land
remove export default
rebase and land
add same sessionChange.cookieInvalidated check as reduceDeviceID
hook up reducer to web/redux/redux-setup:reducer
handle logout, account deletion, and session invalidation
web only
Jan 29 2023
In D6433#192577, @ashoat wrote:Passing back to you with question – not clear why we need to put this in Redux on native given it's already persisted by CommCoreModule
Looks clean
Didn't read through this too carefully since it seems like a fairly straightforward refactor + the Test Plan looks good. Can do a more thorough review if you think that would be good.
(Two of the files in the Test Plan aren't being shown because of the permissions thing)
Jan 28 2023
make sure to persist on web
update
Well looks like there are flow issues after rebasing
Think you intended to attach some screenshots?
rebase before landing
Jan 27 2023
Looks good, left a couple of notes inline
Would we be able to pass all the arguments directly to the hook except the reactionInput? Personally feel like that would be a cleaner API
rebase and land
rebase and land
rebase and land
(I think it’s usually chill to revert your own commits directly without putting up a diff… or at least i’ve been working under that assumption.)
remove <p> used for testing/debugging
Jan 26 2023
Not necessary after reducing padding.
update
Legal agreements do fit on screen. The button, however, does not. In subsequent diff I cut down width of ConnectButton (by reducing characters). In another I reduce the spacing below the ConnectButton so everything fits.
Curious why setRenderEmojiKeyboard(...) is optional. Could totally just be missing something.