Change index on roles from thread to thread_special_role. Re-requesting review since I'd like another pass on this.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 27 2023
Nov 27 2023
rohan added inline comments to D9977: [keyserver] Update usage of threads.default_role in thread-updaters.js.
rohan updated the diff for D9961: [keyserver/lib] Introduce a specialRoles enum and special_role column in MariaDB.
rohan added a comment to D9981: [keyserver] Update usage of threads.default_role in thread-creator.js.
In D9981#291960, @tomek wrote:Is the default_role column nullable at this point?
rohan updated the diff for D9978: [keyserver] Update usage of threads.default_role in validate-role-permissions.js.
Indent query
rohan updated the diff for D9976: [keyserver] Update usage of threads.default_role in role-fetchers.js.
Add indent, drop table alias, and drop the join on threads
rohan updated the diff for D9974: [keyserver/lib] Populate special_role field when initial roles are created.
Use ?? over ||
Nov 24 2023
Nov 24 2023
rohan requested review of D9981: [keyserver] Update usage of threads.default_role in thread-creator.js.
rohan requested review of D9980: [keyserver] Update usage of threads.default_role in thread-fetchers.js.
rohan requested review of D9977: [keyserver] Update usage of threads.default_role in thread-updaters.js.
rohan requested review of D9975: [keyserver] Update usage of threads.default_role in role-deleters.js.
rohan requested review of D9974: [keyserver/lib] Populate special_role field when initial roles are created.
rohan requested review of D9976: [keyserver] Update usage of threads.default_role in role-fetchers.js.
Nov 23 2023
Nov 23 2023
Nov 22 2023
Nov 22 2023
rohan committed rCOMMe80647bd005f: [lib] Delete the old universalCommunityPermissions set (authored by rohan).
[lib] Delete the old universalCommunityPermissions set
rohan committed rCOMMddaed8961488: [keyserver] Add updateRolesAndPermissionsForAllThreads migration (authored by rohan).
[keyserver] Add updateRolesAndPermissionsForAllThreads migration
rohan committed rCOMMd31d2a01ca4f: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread… (authored by rohan).
[keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread…
rohan committed rCOMMd8e045b1de70: [lib] Rename getRolePermissionBlobsForCommunity to… (authored by rohan).
[lib] Rename getRolePermissionBlobsForCommunity to…
rohan committed rCOMM5a1516fd8cef: [keyserver] Validate community ID corresponds to a community root in role… (authored by rohan).
[keyserver] Validate community ID corresponds to a community root in role…
rohan committed rCOMM67f55a80135f: [lib] Introduce getUniversalCommunityRootPermissionsBlob (authored by rohan).
[lib] Introduce getUniversalCommunityRootPermissionsBlob
rohan committed rCOMM3b4f16f477fe: [lib/web/native] Show voiced_in_announcement_channels user-surfaced permission… (authored by rohan).
[lib/web/native] Show voiced_in_announcement_channels user-surfaced permission…
rohan committed rCOMM3c2390914b53: [native] Redux persist migration to remove incorrect permissions from threads (authored by rohan).
[native] Redux persist migration to remove incorrect permissions from threads
rohan committed rCOMMd35cd9589da6: [keyserver] Write MariaDB migration to remove incorrect permission from roles (authored by rohan).
[keyserver] Write MariaDB migration to remove incorrect permission from roles
rohan committed rCOMM11d0868e0328: [lib] Prevent editing role permissions from adding unexpected permissions (authored by rohan).
[lib] Prevent editing role permissions from adding unexpected permissions
rohan committed rCOMM9a45b9a2a16e: [lib] Fix universal community permissions to prevent input bar and join chat… (authored by rohan).
[lib] Fix universal community permissions to prevent input bar and join chat…
Rebase
rohan updated the diff for D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Fix persist version after rebase
Rebase
rohan updated the diff for D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Rebase
rohan updated the diff for D9901: [lib] Rename getRolePermissionBlobsForCommunity to getRolePermissionBlobsForCommunityRoot.
Rebase
rohan updated the diff for D9900: [keyserver] Validate community ID corresponds to a community root in role-creator.
Rebase
Rebase
rohan updated the diff for D9514: [lib/web/native] Show voiced_in_announcement_channels user-surfaced permission for all community types.
Rebase
rohan updated the diff for D9608: [native] Redux persist migration to remove incorrect permissions from threads.
Rebase
rohan updated the diff for D9599: [keyserver] Write MariaDB migration to remove incorrect permission from roles.
Rebase
rohan updated the diff for D9686: [lib] Prevent editing role permissions from adding unexpected permissions.
Rebase
rohan updated the diff for D9493: [lib] Fix universal community permissions to prevent input bar and join chat button from appearing at the same time.
Rebase
Nov 21 2023
Nov 21 2023
rohan updated the diff for D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Address feedback (use NEXT_CODE_VERSION and use threadTypeIsAnnouncementThread)
rohan updated the diff for D9901: [lib] Rename getRolePermissionBlobsForCommunity to getRolePermissionBlobsForCommunityRoot.
Rebase
rohan updated the diff for D9900: [keyserver] Validate community ID corresponds to a community root in role-creator.
Rebase
Address feedback.
rohan added a comment to D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Did some investigating and it seems like we mainly have rolePermissions as null when a user is a former member and is now a ghost member of a thread (-1 role)
rohan updated the summary of D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Nov 20 2023
Nov 20 2023
rohan updated the diff for D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Update approach (planning changes until I can update diff description/test plan)
Abandoning this for now since we're reconsidering the Voiced approach
rohan added a comment to D9825: [keyserver] Migration to add Voiced role to announcement subchannels.
Abandoning this for now since we're reconsidering the Voiced approach
Abandoning this for now since we're reconsidering the Voiced approach
rohan updated the summary of D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
rohan updated the diff for D9901: [lib] Rename getRolePermissionBlobsForCommunity to getRolePermissionBlobsForCommunityRoot.
Rebase
Merge diffs (for now)
rohan updated the summary of D9924: [lib] Use configurableCommunityPermissions in getRolePermissionBlobsForCommunityRoot.
Update
rohan updated the summary of D9900: [keyserver] Validate community ID corresponds to a community root in role-creator.
rohan updated the summary of D9899: [keyserver] Use getUniversalCommunityRootPermissionsBlob in role-creator.
This is getting merged into D9897
rohan abandoned D9898: [keyserver] Use getUniversalCommunityRootPermissionsBlob in validate-role-permissions script.
This is getting merged into D9897
rohan added inline comments to D9883: [lib] Define a function that detects when an ENS name is typed.
rohan added inline comments to D9883: [lib] Define a function that detects when an ENS name is typed.
Update tests
- Updated the RegEx to match any character except newline to match all unicode characters (like ö) but also to match emojis (🎃)
- Changed the order of isValidENSName to match the regex first. This is to prevent converting an invalid parameter like ö.eth toAscii, which would then meet the length requirements of the regex statement.
- Updated the unit tests, used this post to identify the valid one-char emojis that can be registered as ENS names. Cross checked this manually on https://app.ens.domains/
Nov 17 2023
Nov 17 2023
rohan planned changes to D9899: [keyserver] Use getUniversalCommunityRootPermissionsBlob in role-creator.
rohan updated the diff for D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Rebase on the stack so
- hacky checks in role-creator are removed
- community validation is done
Address feedback (extract query to a function and fix formatting).