Page MenuHomePhorge
Feed All Stories

All Stories
Use Results
Edit Query

Feb 25 2025

kamil committed rCOMM5e28325d4ed2: [native] disable navigation in `RestoreBackupScreen`.
Feb 25 2025, 12:34 PM
kamil closed D14396: [native] fix `currentInitializeCryptoAccountPromise`.
Feb 25 2025, 12:34 PM
kamil committed rCOMM7f7445303068: [native] fix `currentInitializeCryptoAccountPromise`.
Feb 25 2025, 12:34 PM
tomek accepted D14405: [native] use `initializeCryptoAccount` from `olmAPI` in `IdentityServiceContextProvider`.
Feb 25 2025, 12:06 PM
kamil updated the diff for D14397: [native] prevent leaving restore screen when falling back to v1.

remove goBack from Alert

Feb 25 2025, 12:01 PM
kamil published D14405: [native] use `initializeCryptoAccount` from `olmAPI` in `IdentityServiceContextProvider` for review.
Feb 25 2025, 11:52 AM
kamil attached a referenced file: F4289967: ScreenRecording_02-25-2025 12-39-34_1.MP4.
Feb 25 2025, 11:51 AM
kamil added inline comments to D14397: [native] prevent leaving restore screen when falling back to v1.
Feb 25 2025, 11:51 AM
tomek accepted D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.

Do we know what was the intention of this code and whether we have a corresponding logic in the Reanimated 2 code?

Feb 25 2025, 11:43 AM
tomek accepted D14410: [native] Rename clampV2 to clamp.
Feb 25 2025, 11:42 AM
tomek accepted D14409: [native] Remove reanimated v1 code from animation-utils.js.
Feb 25 2025, 11:42 AM
tomek accepted D14408: [native] Rename progressV2 variables to progress.
Feb 25 2025, 11:41 AM
tomek accepted D14407: [native] Rename positionV2 to position in overlay navigator.
Feb 25 2025, 11:40 AM
tomek accepted D14406: [native] Remove position from overlay navigator.
Feb 25 2025, 11:39 AM
angelika published D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay for review.
Feb 25 2025, 11:36 AM
angelika published D14410: [native] Rename clampV2 to clamp for review.
Feb 25 2025, 11:35 AM
angelika published D14409: [native] Remove reanimated v1 code from animation-utils.js for review.
Feb 25 2025, 11:35 AM
angelika published D14408: [native] Rename progressV2 variables to progress for review.
Feb 25 2025, 11:35 AM
angelika published D14407: [native] Rename positionV2 to position in overlay navigator for review.
Feb 25 2025, 11:35 AM
angelika published D14406: [native] Remove position from overlay navigator for review.
Feb 25 2025, 11:34 AM
angelika closed D14381: [web] Add colon in qr code login copy.
Feb 25 2025, 10:52 AM
angelika committed rCOMMb952e5ec7881: [web] Add colon in qr code login copy.
Feb 25 2025, 10:52 AM
angelika closed D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component.
Feb 25 2025, 10:48 AM
angelika committed rCOMM5a00b30209f9: [native] Migrate render function and finish FullScreenViewModal migration to….
Feb 25 2025, 10:48 AM
angelika closed D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14311: [native] Migrate updateDimensions method in FullScreenViewModal to functional component.
Feb 25 2025, 10:48 AM
angelika committed rCOMM0452eeb23353: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14310: [native] Remove leftover Reanimated v1 code in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional….
Feb 25 2025, 10:48 AM
angelika closed D14309: [native] Cancel animations when gesture is started in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMM43c03694bf15: [native] Remove leftover Reanimated v1 code in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14308: [native] Migrate fling functionality in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMM3e75cc6b16f4: [native] Cancel animations when gesture is started in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14307: [native] Migrate recenter functionality in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMMf4bc51387b80: [native] Migrate fling functionality in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMM87db6a222d12: [native] Migrate recenter functionality in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMM89acbf761f52: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14304: [native] Migrate single tap gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMMe0028f81cbb3: [native] Migrate double tap gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMM624f6e3eacf9: [native] Migrate single tap gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14303: [native] Migrate pinch gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14302: [native] Migrate pan gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14301: [native] Migrate buttons refs and measuring in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMMc2e2ab2d01b8: [native] Migrate pan gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMM86f44da46631: [native] Migrate buttons refs and measuring in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika closed D14299: [native] Migrate state in FullScreenViewModal to functional component.
Feb 25 2025, 10:48 AM
angelika closed D14300: [native] Migrate gestures to react-native-gesture-handler v2 API in FullScreenViewModal.
Feb 25 2025, 10:48 AM
angelika committed rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component.
Feb 25 2025, 10:48 AM
angelika committed rCOMM35649a6fa388: [native] Migrate gestures to react-native-gesture-handler v2 API in….
Feb 25 2025, 10:48 AM
angelika closed D14298: [native] Migrate orientation logic in FullScreenViewModal to functional component.
Feb 25 2025, 10:48 AM
angelika committed rCOMMa2da5af2a7d5: [native] Migrate orientation logic in FullScreenViewModal to functional….
Feb 25 2025, 10:48 AM
tomek accepted D14402: [lib] Avoid unnecessarily mutating MessageStore on processServerRequestsActionType.
Feb 25 2025, 10:37 AM
tomek accepted D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.

MessageStorePruner doesn't run for thick threads

This isn't correct. The pruner runs for thick threads, but it doesn't remove from the DB.
https://github.com/CommE2E/comm/blob/3206010f0102cb2c82d0872a9c84aade5643d59c/lib/reducers/message-reducer.js#L1397-L1400

Feb 25 2025, 10:32 AM
tomek accepted D14400: [lib] Add numMessagesToFetch param to useFetchMessages.
Feb 25 2025, 10:23 AM
tomek accepted D14399: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo.
Feb 25 2025, 10:20 AM
ashoat requested review of D14402: [lib] Avoid unnecessarily mutating MessageStore on processServerRequestsActionType.
Feb 25 2025, 9:54 AM
ashoat requested review of D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.
Feb 25 2025, 9:30 AM
bartek accepted D14398: [native] disable navigation in `RestoreBackupScreen`.
Feb 25 2025, 9:28 AM
tomek added inline comments to D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 25 2025, 9:22 AM
bartek published D14404: [scripts] Script to reset keyserver owner in DDB for review.
Feb 25 2025, 9:15 AM
ashoat requested review of D14400: [lib] Add numMessagesToFetch param to useFetchMessages.
Feb 25 2025, 9:11 AM
bartek published D14403: [nix] Add jq tool to dev shell for review.
Feb 25 2025, 9:01 AM
ashoat requested review of D14399: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo.
Feb 25 2025, 8:53 AM
ashoat closed D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 25 2025, 8:36 AM
ashoat committed rCOMMfa0d0c36cdce: [lib] Introduce useGetMessageAuthor hook.
Feb 25 2025, 8:36 AM
ashoat updated the diff for D14395: [lib] Introduce useGetMessageAuthor hook.

Avoid fetching latest message in reactionMessageSpec.getLastUpdatedTime until function is actually called

Feb 25 2025, 8:15 AM

Feb 24 2025

kamil added a comment to D14398: [native] disable navigation in `RestoreBackupScreen`.
In D14398#400120, @ashoat wrote:

Just confirming – is this screen only used when the restore is in-progress?

Feb 24 2025, 6:09 PM
Harbormaster failed remote builds in B33613: Diff 47233 for D14395: [lib] Introduce useGetMessageAuthor hook!
Feb 24 2025, 5:31 PM
ashoat updated the diff for D14395: [lib] Introduce useGetMessageAuthor hook.

Review

Feb 24 2025, 5:13 PM
ashoat added inline comments to D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 24 2025, 5:12 PM
ashoat added inline comments to D14397: [native] prevent leaving restore screen when falling back to v1.
Feb 24 2025, 5:10 PM
ashoat added a comment to D14398: [native] disable navigation in `RestoreBackupScreen`.

Just confirming – is this screen only used when the restore is in-progress? If the button to start is on this screen too, we might want to only prevent the user from navigating away after the button is pressed

Feb 24 2025, 5:06 PM
tomek accepted D14397: [native] prevent leaving restore screen when falling back to v1.
Feb 24 2025, 4:44 PM
tomek accepted D14398: [native] disable navigation in `RestoreBackupScreen`.
Feb 24 2025, 4:33 PM
tomek accepted D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 24 2025, 4:15 PM
Harbormaster failed remote builds in B33609: Diff 47229 for D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component!
Feb 24 2025, 3:28 PM
ashoat accepted D14396: [native] fix `currentInitializeCryptoAccountPromise`.
Feb 24 2025, 2:57 PM
kamil published D14397: [native] prevent leaving restore screen when falling back to v1 for review.
Feb 24 2025, 2:48 PM
kamil published D14398: [native] disable navigation in `RestoreBackupScreen` for review.
Feb 24 2025, 2:48 PM
Harbormaster failed remote builds in B33601: Diff 47221 for D14305: [native] Migrate double tap gesture handling in FullScreenViewModal!
Feb 24 2025, 1:51 PM
Harbormaster failed remote builds in B33598: Diff 47218 for D14302: [native] Migrate pan gesture handling in FullScreenViewModal!
Feb 24 2025, 1:13 PM
Harbormaster failed remote builds in B33605: Diff 47225 for D14309: [native] Cancel animations when gesture is started in FullScreenViewModal!
Feb 24 2025, 12:19 PM
Harbormaster failed remote builds in B33604: Diff 47224 for D14308: [native] Migrate fling functionality in FullScreenViewModal!
Feb 24 2025, 12:18 PM
kamil published D14396: [native] fix `currentInitializeCryptoAccountPromise` for review.
Feb 24 2025, 12:08 PM
angelika updated the diff for D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component.

Rebase

Feb 24 2025, 11:54 AM
angelika updated the diff for D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.

Rebase

Feb 24 2025, 11:54 AM
angelika updated the diff for D14311: [native] Migrate updateDimensions method in FullScreenViewModal to functional component.

Rebase

Feb 24 2025, 11:53 AM
angelika updated the diff for D14310: [native] Remove leftover Reanimated v1 code in FullScreenViewModal.

Rebase

Feb 24 2025, 11:53 AM
angelika updated the diff for D14309: [native] Cancel animations when gesture is started in FullScreenViewModal.

Rebase

Feb 24 2025, 11:53 AM
angelika updated the diff for D14308: [native] Migrate fling functionality in FullScreenViewModal.

Rebase

Feb 24 2025, 11:53 AM
angelika updated the diff for D14307: [native] Migrate recenter functionality in FullScreenViewModal.

Rebase

Feb 24 2025, 11:52 AM
angelika updated the diff for D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.

Rebase

Feb 24 2025, 11:52 AM
angelika updated the diff for D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.

Rebase

Feb 24 2025, 11:52 AM
angelika updated the diff for D14304: [native] Migrate single tap gesture handling in FullScreenViewModal.

Rebase

Feb 24 2025, 11:51 AM
angelika updated the diff for D14303: [native] Migrate pinch gesture handling in FullScreenViewModal.

Rebase

Feb 24 2025, 11:51 AM
angelika updated the diff for D14302: [native] Migrate pan gesture handling in FullScreenViewModal.

Rebase

Feb 24 2025, 11:51 AM
angelika updated the diff for D14301: [native] Migrate buttons refs and measuring in FullScreenViewModal.

Rebase

Feb 24 2025, 11:50 AM
First
Prev
Next