Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Sat, Mar 1

varun added inline comments to D14053: [native] DisplayCommunityDirectoryPrompt.
Sat, Mar 1, 1:47 PM
ashoat accepted D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet.
Sat, Mar 1, 12:55 PM
varun closed D14391: [native] ColdStartTracker.
Sat, Mar 1, 9:08 AM
varun committed rCOMMebee92ea5903: [native] ColdStartTracker (authored by varun).
[native] ColdStartTracker
Sat, Mar 1, 9:08 AM
varun added inline comments to D14391: [native] ColdStartTracker.
Sat, Mar 1, 9:04 AM
varun added inline comments to D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet.
Sat, Mar 1, 9:01 AM
varun added inline comments to D14420: [native] navigate to CommunityJoinerModal if user accepts prompt.
Sat, Mar 1, 9:00 AM

Fri, Feb 28

ashoat committed rCOMM3a108c6159c2: [native] codeVersion -> 468 (authored by ashoat).
[native] codeVersion -> 468
Fri, Feb 28, 7:31 PM
ashoat added a reverting change for rCOMM293d0416ff42: [native] Temporary changes for staff release: rCOMM0f7926420770: Revert "[native] Temporary changes for staff release".
Fri, Feb 28, 7:31 PM
ashoat committed rCOMM0f7926420770: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Fri, Feb 28, 7:31 PM
ashoat committed rCOMM293d0416ff42: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Fri, Feb 28, 7:31 PM
ashoat committed rCOMM9c73b80a98a1: [native] codeVersion -> 467 (authored by ashoat).
[native] codeVersion -> 467
Fri, Feb 28, 7:31 PM
ashoat committed rCOMM62ad50cdac46: [web][keyserver] codeVersion -> 156 (authored by ashoat).
[web][keyserver] codeVersion -> 156
Fri, Feb 28, 7:31 PM
ashoat committed rCOMM9f0825134f26: [lib] Ship signed device lists (authored by ashoat).
[lib] Ship signed device lists
Fri, Feb 28, 7:31 PM
ashoat committed rCOMMa43d50b6171c: [native] Fix patch after react-native-reanimated@2.14.4 upgrade (authored by ashoat).
[native] Fix patch after react-native-reanimated@2.14.4 upgrade
Fri, Feb 28, 4:08 PM
ashoat requested changes to D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet.

Passing back to you with a question about why we avoid goBack when showing the NUX tip

Fri, Feb 28, 3:32 PM
ashoat accepted D14420: [native] navigate to CommunityJoinerModal if user accepts prompt.
Fri, Feb 28, 3:28 PM
ashoat committed rCOMMe6e9fb06e390: Revert "Tmate for iOS CI to debug" (authored by ashoat).
Revert "Tmate for iOS CI to debug"
Fri, Feb 28, 3:26 PM
ashoat added a reverting change for rCOMM13414db4eb0b: Tmate for iOS CI to debug: rCOMMe6e9fb06e390: Revert "Tmate for iOS CI to debug".
Fri, Feb 28, 3:26 PM
ashoat committed rCOMMd4f6bac1310c: [native] Update to react-native-reanimated@2.14.4 (authored by ashoat).
[native] Update to react-native-reanimated@2.14.4
Fri, Feb 28, 3:08 PM
varun published D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet for review.

CI has been stuck for a day

Fri, Feb 28, 2:48 PM
varun published D14420: [native] navigate to CommunityJoinerModal if user accepts prompt for review.

CI has been stuck for a day

Fri, Feb 28, 2:48 PM
ashoat committed rCOMM13414db4eb0b: Tmate for iOS CI to debug (authored by ashoat).
Tmate for iOS CI to debug
Fri, Feb 28, 2:03 PM
ashoat closed D14414: [native] Fix copying encrypted images on iOS.
Fri, Feb 28, 1:51 PM
ashoat committed rCOMM66e8cbf090ee: [native] Fix copying encrypted images on iOS (authored by ashoat).
[native] Fix copying encrypted images on iOS
Fri, Feb 28, 1:51 PM
ashoat committed rCOMM33f5b2d57510: [native] Update to react-native-gesture-handler@2.9.0 (authored by ashoat).
[native] Update to react-native-gesture-handler@2.9.0
Fri, Feb 28, 1:50 PM
ashoat committed rCOMM14b87fd298f9: Revert "Tmate for iOS CI to debug" (authored by ashoat).
Revert "Tmate for iOS CI to debug"
Fri, Feb 28, 1:50 PM
ashoat added a reverting change for rCOMM207609aaf9bb: Tmate for iOS CI to debug: rCOMM14b87fd298f9: Revert "Tmate for iOS CI to debug".
Fri, Feb 28, 1:50 PM
ashoat committed rCOMM207609aaf9bb: Tmate for iOS CI to debug (authored by ashoat).
Tmate for iOS CI to debug
Fri, Feb 28, 1:25 PM
ashoat committed rCOMMcc64f6c805dd: [lib] Minor fix to siwe patch (authored by ashoat).
[lib] Minor fix to siwe patch
Fri, Feb 28, 1:25 PM
tomek closed D14425: [native] Schedule backup generation and upload after saving SIWE secrets.
Fri, Feb 28, 9:10 AM
tomek committed rCOMM61641f9fdae9: [native] Schedule backup generation and upload after saving SIWE secrets (authored by tomek).
[native] Schedule backup generation and upload after saving SIWE secrets
Fri, Feb 28, 9:10 AM
tomek closed D14416: [native] Avoid running the handler multiple times.
Fri, Feb 28, 9:10 AM
tomek committed rCOMM672473b38cfc: [native] Avoid running the handler multiple times (authored by tomek).
[native] Avoid running the handler multiple times
Fri, Feb 28, 9:10 AM
tomek updated the diff for D14416: [native] Avoid running the handler multiple times.

Fix eslint

Fri, Feb 28, 8:45 AM
Harbormaster failed remote builds in B33658: Diff 47312 for D14416: [native] Avoid running the handler multiple times!
Fri, Feb 28, 8:38 AM
tomek updated the diff for D14416: [native] Avoid running the handler multiple times.

Fix eslint

Fri, Feb 28, 8:23 AM
Harbormaster failed remote builds in B33657: Diff 47311 for D14416: [native] Avoid running the handler multiple times!
Fri, Feb 28, 7:58 AM
kamil accepted D14425: [native] Schedule backup generation and upload after saving SIWE secrets.
Fri, Feb 28, 7:58 AM
kamil accepted D14417: [native] Remove background identity login handler.

This looks reasonable to me, accepting to unblock, but I don't have the full context about BackgroundIdentityLoginHandler purposes, so feel free to add @bartek or @ashoat as blocking, if you think this is needed

Fri, Feb 28, 7:50 AM
kamil accepted D14416: [native] Avoid running the handler multiple times.
Fri, Feb 28, 7:46 AM
tomek updated the diff for D14416: [native] Avoid running the handler multiple times.

Update the ref immediatelly

Fri, Feb 28, 7:46 AM
tomek updated the diff for D14416: [native] Avoid running the handler multiple times.

Delete unnecessary dependency

Fri, Feb 28, 7:44 AM
tomek updated the diff for D14425: [native] Schedule backup generation and upload after saving SIWE secrets.

Rebase

Fri, Feb 28, 7:33 AM
kamil closed D14424: [native] remove `useStaffCanSee` from `BackupHandler`.
Fri, Feb 28, 7:25 AM
kamil committed rCOMMdf2230754b77: [native] remove `useStaffCanSee` from `BackupHandler` (authored by kamil).
[native] remove `useStaffCanSee` from `BackupHandler`
Fri, Feb 28, 7:25 AM
tomek added inline comments to D14417: [native] Remove background identity login handler.
Fri, Feb 28, 6:18 AM
tomek updated the diff for D14417: [native] Remove background identity login handler.

Bump min code version

Fri, Feb 28, 6:16 AM
tomek requested review of D14425: [native] Schedule backup generation and upload after saving SIWE secrets.
Fri, Feb 28, 6:16 AM
tomek requested review of D14416: [native] Avoid running the handler multiple times.
Fri, Feb 28, 6:00 AM
tomek accepted D14424: [native] remove `useStaffCanSee` from `BackupHandler`.
Fri, Feb 28, 5:13 AM
bartek accepted D14423: [terraform] Bump RabbitMQ engine_version to 3.13.7.
Fri, Feb 28, 5:05 AM
kamil published D14424: [native] remove `useStaffCanSee` from `BackupHandler` for review.
Fri, Feb 28, 4:14 AM
kamil accepted D14422: [comm-lib] Add comm.software to CORS config.
Fri, Feb 28, 4:13 AM
kamil published D14423: [terraform] Bump RabbitMQ engine_version to 3.13.7 for review.
Fri, Feb 28, 3:55 AM
bartek closed D14419: [proto] Add comment about siwe fields being social proof.
Fri, Feb 28, 3:27 AM
bartek committed rCOMM1e9a700a7121: [proto] Add comment about siwe fields being social proof (authored by bartek).
[proto] Add comment about siwe fields being social proof
Fri, Feb 28, 3:27 AM
bartek closed D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.
Fri, Feb 28, 3:27 AM
bartek committed rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC (authored by bartek).
[lib] Handle user_not_found returned by GetKeyserverKeys RPC
Fri, Feb 28, 3:27 AM
bartek closed D14415: [lib][native] Respect login flow in useLogIn and useIdentityLogOut.
Fri, Feb 28, 3:27 AM
bartek committed rCOMMb218da0df38f: [lib][native] Respect login flow in useLogIn and useIdentityLogOut (authored by bartek).
[lib][native] Respect login flow in useLogIn and useIdentityLogOut
Fri, Feb 28, 3:27 AM
bartek published D14422: [comm-lib] Add comm.software to CORS config for review.
Fri, Feb 28, 2:58 AM
kamil accepted D14419: [proto] Add comment about siwe fields being social proof.
Fri, Feb 28, 2:32 AM
bartek added inline comments to D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.
Fri, Feb 28, 12:56 AM

Thu, Feb 27

ashoat accepted D14053: [native] DisplayCommunityDirectoryPrompt.

Shouldn't D14391 be added to the stack here? You seem to be depending on it

Thu, Feb 27, 11:37 PM
varun updated the diff for D14053: [native] DisplayCommunityDirectoryPrompt.

address feedback

Thu, Feb 27, 9:36 PM
bartek accepted D14414: [native] Fix copying encrypted images on iOS.
In D14414#400577, @ashoat wrote:
In D14414#400524, @bartek wrote:

I'm worried about using Clipboard.setImageFromBase64 for large media files... I suspect it will be passing a massive string over the legacy React Native bridge, and so I feel obliged to do some performance testing on that, and I don't have the time to do that for an approach that I suspect might end up not working for us.

Thu, Feb 27, 12:17 PM
ashoat committed rCOMM9e4a92343213: [terraform] Bump RabbitMQ engine_version to 3.12.13 (authored by ashoat).
[terraform] Bump RabbitMQ engine_version to 3.12.13
Thu, Feb 27, 12:09 PM
ashoat committed rCOMMfeed126fa882: [terraform] Bump keyserver image to 1.0.155 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.155
Thu, Feb 27, 11:27 AM
ashoat added a reverting change for rCOMM9bd00d080a48: [lib] Temporarily flip useIsRestoreFlowEnabled to true: rCOMM2ee1094cc908: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Thu, Feb 27, 10:42 AM
ashoat committed rCOMM2ee1094cc908: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true" (authored by ashoat).
Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true"
Thu, Feb 27, 10:42 AM
ashoat added a reverting change for rCOMM637bad1cdcde: [native] Temporary changes for staff release: rCOMM0682b2365132: Revert "[native] Temporary changes for staff release".
Thu, Feb 27, 10:42 AM
ashoat committed rCOMM0682b2365132: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Feb 27, 10:42 AM
ashoat committed rCOMMd8703be7333a: [native] codeVersion -> 466 (authored by ashoat).
[native] codeVersion -> 466
Thu, Feb 27, 10:42 AM
ashoat committed rCOMM637bad1cdcde: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Feb 27, 10:42 AM
ashoat committed rCOMM9bd00d080a48: [lib] Temporarily flip useIsRestoreFlowEnabled to true (authored by ashoat).
[lib] Temporarily flip useIsRestoreFlowEnabled to true
Thu, Feb 27, 10:42 AM
ashoat committed rCOMMbd9de7b6608d: [native] codeVersion -> 465 (authored by ashoat).
[native] codeVersion -> 465
Thu, Feb 27, 10:42 AM
ashoat committed rCOMM942f3d7bd0d0: [web][keyserver] codeVersion -> 155 (authored by ashoat).
[web][keyserver] codeVersion -> 155
Thu, Feb 27, 10:42 AM
ashoat added a comment to D14414: [native] Fix copying encrypted images on iOS.
In D14414#400524, @bartek wrote:

An alternative approach, that doesn't require using temporary file:

  • Extract some logic from saveRemoteMediaToDisk() in`save-file.js`, with the following changes:
    • For encrypted media, call fetchAndDecryptMedia({ destination: 'data_uri' }) instead of destination: file
    • For non-encrypted, fetch base64 but don't save to file (skip last step)
  • call Clipboard.setImageFromBase64 - iOS implementation is in the patch, line 116
Thu, Feb 27, 9:07 AM
tomek accepted D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.
Thu, Feb 27, 9:00 AM
ashoat closed D14413: Upgrade to Rust 1.85.
Thu, Feb 27, 8:58 AM
ashoat committed rCOMM67fde31e015d: Upgrade to Rust 1.85 (authored by ashoat).
Upgrade to Rust 1.85
Thu, Feb 27, 8:58 AM
tomek accepted D14415: [lib][native] Respect login flow in useLogIn and useIdentityLogOut.
Thu, Feb 27, 8:57 AM
ashoat added a comment to D14413: Upgrade to Rust 1.85.

Okay, in order to fix CI and unblock the builds, I'll go ahead and land this on the assumption that things are working. I've created a task to confirm that it's working once things are deployed in production; assigned to @bartek for now since @kamil is out sick.

Thu, Feb 27, 8:57 AM
ashoat requested review of D14414: [native] Fix copying encrypted images on iOS.
Thu, Feb 27, 8:41 AM
ashoat added a comment to D14417: [native] Remove background identity login handler.

Should we bump the version in keyserver/src/session/version.js along with this change?

Thu, Feb 27, 8:36 AM
bartek published D14419: [proto] Add comment about siwe fields being social proof for review.
Thu, Feb 27, 8:31 AM
bartek published D14418: [lib] Handle user_not_found returned by GetKeyserverKeys RPC for review.
Thu, Feb 27, 8:30 AM
tomek requested review of D14417: [native] Remove background identity login handler.
Thu, Feb 27, 6:55 AM
bartek published D14415: [lib][native] Respect login flow in useLogIn and useIdentityLogOut for review.
Thu, Feb 27, 3:03 AM
bartek closed D14404: [scripts] Script to reset keyserver owner in DDB.
Thu, Feb 27, 2:25 AM
bartek committed rCOMM20e275c76839: [scripts] Script to reset keyserver owner in DDB (authored by bartek).
[scripts] Script to reset keyserver owner in DDB
Thu, Feb 27, 2:25 AM
bartek closed D14403: [nix] Add jq tool to dev shell.
Thu, Feb 27, 2:25 AM
bartek committed rCOMM49223dae4753: [nix] Add jq tool to dev shell (authored by bartek).
[nix] Add jq tool to dev shell
Thu, Feb 27, 2:25 AM
bartek added inline comments to D14404: [scripts] Script to reset keyserver owner in DDB.
Thu, Feb 27, 1:57 AM
bartek updated the diff for D14404: [scripts] Script to reset keyserver owner in DDB.

Invert confirmation prompt logic to make script more error-proof

Thu, Feb 27, 1:56 AM
tomek closed D14412: [native] Fall back to v1 login after `use_v1_flow` response.
Thu, Feb 27, 1:50 AM
tomek committed rCOMM0795c4d41308: [native] Fall back to v1 login after `use_v1_flow` response (authored by tomek).
[native] Fall back to v1 login after `use_v1_flow` response
Thu, Feb 27, 1:50 AM
bartek attached a referenced file: F4398714: Screenshot 2025-02-27 at 10.27.11.png.
Thu, Feb 27, 1:46 AM
bartek accepted D14413: Upgrade to Rust 1.85.

Rust update looks good to me

Thu, Feb 27, 1:46 AM
First
Prev
Next