Page MenuHomePhabricator
Feed All Stories

May 26 2023

atul added a reverting change for rCOMM910fab748b67: [native] Temporary changes for staff release: rCOMM0b94c84fc87f: Revert "[native] Temporary changes for staff release".
May 26 2023, 1:57 PM
atul committed rCOMM0b94c84fc87f: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
May 26 2023, 1:57 PM
atul committed rCOMM4815d7cc920d: [native] `codeVersion` -> 222 (authored by atul).
[native] `codeVersion` -> 222
May 26 2023, 1:57 PM
atul committed rCOMM910fab748b67: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
May 26 2023, 1:57 PM
atul committed rCOMM02d51161d723: [native] `codeVersion` -> 221 (authored by atul).
[native] `codeVersion` -> 221
May 26 2023, 1:57 PM
atul closed D8007: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions` < 221.
May 26 2023, 1:50 PM
atul committed rCOMM615e4e2804f9: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions`… (authored by atul).
[keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions`…
May 26 2023, 1:50 PM
ashoat closed D8006: [native] Add migration to populate MANAGE_INVITE_LINKS permission.
May 26 2023, 1:50 PM
ashoat committed rCOMM094cad791838: [native] Add migration to populate MANAGE_INVITE_LINKS permission (authored by ashoat).
[native] Add migration to populate MANAGE_INVITE_LINKS permission
May 26 2023, 1:50 PM
ashoat accepted D8007: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions` < 221.
May 26 2023, 1:49 PM
atul accepted D8006: [native] Add migration to populate MANAGE_INVITE_LINKS permission.
May 26 2023, 1:49 PM
atul published D8007: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions` < 221 for review.
May 26 2023, 1:48 PM
ashoat published D8006: [native] Add migration to populate MANAGE_INVITE_LINKS permission for review.
May 26 2023, 1:46 PM
ashoat added a comment to D7762: [lib] Introduce a new permission for managing invite links.

This permission should not have been introduced without corresponding changes on the native side to prevent massive inconsistency reports from being generated.

May 26 2023, 1:43 PM
atul committed rCOMMde06493115db: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
May 26 2023, 1:31 PM
atul added a reverting change for rCOMM7a1c6e8ceaf6: [native] Temporary changes for staff release: rCOMMde06493115db: Revert "[native] Temporary changes for staff release".
May 26 2023, 1:31 PM
atul committed rCOMMfe4e7f872ef6: [native] `codeVersion` -> 220 (authored by atul).
[native] `codeVersion` -> 220
May 26 2023, 1:31 PM
atul committed rCOMM7a1c6e8ceaf6: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
May 26 2023, 1:31 PM
atul committed rCOMM62fd5d6d49f9: [native] `codeVersion` -> 219 (authored by atul).
[native] `codeVersion` -> 219
May 26 2023, 1:31 PM
ashoat closed D8005: [native] Launch message editing on mobile.
May 26 2023, 1:25 PM
ashoat committed rCOMMc09ed2789c50: [native] Launch message editing on mobile (authored by ashoat).
[native] Launch message editing on mobile
May 26 2023, 1:25 PM
atul accepted D8005: [native] Launch message editing on mobile.
May 26 2023, 1:24 PM
ashoat requested review of D8005: [native] Launch message editing on mobile.
May 26 2023, 1:22 PM
ashoat closed D8004: [native] Introduce AvatarSelection screen.
May 26 2023, 12:59 PM
ashoat closed D8003: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on Android.
May 26 2023, 12:59 PM
ashoat committed rCOMM46c4f8098ad7: [native] Introduce AvatarSelection screen (authored by ashoat).
[native] Introduce AvatarSelection screen
May 26 2023, 12:59 PM
ashoat committed rCOMM98a1caa65c72: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on… (authored by ashoat).
[native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on…
May 26 2023, 12:59 PM
ashoat closed D8002: [native] Add password autofill support to PasswordSelection.
May 26 2023, 12:59 PM
ashoat committed rCOMM0c853385763b: [native] Add password autofill support to PasswordSelection (authored by ashoat).
[native] Add password autofill support to PasswordSelection
May 26 2023, 12:59 PM
atul accepted D8004: [native] Introduce AvatarSelection screen.
May 26 2023, 12:54 PM
atul accepted D8003: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on Android.

Huh that's weird

May 26 2023, 12:53 PM
atul accepted D8002: [native] Add password autofill support to PasswordSelection.
May 26 2023, 12:52 PM
ashoat requested review of D8004: [native] Introduce AvatarSelection screen.
May 26 2023, 12:37 PM
ashoat requested review of D8003: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on Android.
May 26 2023, 12:14 PM
ashoat requested review of D8002: [native] Add password autofill support to PasswordSelection.
May 26 2023, 12:11 PM
ashoat closed D8001: [native] Set RegistrationTextInput keyboardAppearance based on theme.
May 26 2023, 10:59 AM
ashoat committed rCOMMe80f9ddc2a62: [native] Set RegistrationTextInput keyboardAppearance based on theme (authored by ashoat).
[native] Set RegistrationTextInput keyboardAppearance based on theme
May 26 2023, 10:59 AM
ashoat closed D8000: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 10:59 AM
ashoat committed rCOMMa43b0f2ea47b: [native] Delay PasswordSelection autoFocus on Android (authored by ashoat).
[native] Delay PasswordSelection autoFocus on Android
May 26 2023, 10:59 AM
atul accepted D8000: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 10:48 AM
atul accepted D8001: [native] Set RegistrationTextInput keyboardAppearance based on theme.
May 26 2023, 10:48 AM
ashoat updated the diff for D8000: [native] Delay PasswordSelection autoFocus on Android.

Comment

May 26 2023, 10:46 AM
atul accepted D8000: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 10:36 AM
atul closed D7991: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`.
May 26 2023, 10:34 AM
atul committed rCOMM5510d4a0d2b7: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers` (authored by atul).
[native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`
May 26 2023, 10:34 AM
atul closed D7988: [native] Pull `CommunityCreationKeyserverLabel` out of `CommunityConfiguration`.
May 26 2023, 10:34 AM
atul closed D7987: [native] Introduce placeholder `CommunityCreationMembers` component.
May 26 2023, 10:34 AM
atul closed D7980: [native] Display error message when community creation fails.
May 26 2023, 10:34 AM
atul committed rCOMM9e4a8a3c8ca0: [native] Introduce placeholder `CommunityCreationMembers` component (authored by atul).
[native] Introduce placeholder `CommunityCreationMembers` component
May 26 2023, 10:34 AM
atul committed rCOMMf902a92c8c9f: [native] Pull `CommunityCreationKeyserverLabel` out of `CommunityConfiguration` (authored by atul).
[native] Pull `CommunityCreationKeyserverLabel` out of `CommunityConfiguration`
May 26 2023, 10:34 AM
atul committed rCOMMc395aab3ca94: [native] Display error message when community creation fails (authored by atul).
[native] Display error message when community creation fails
May 26 2023, 10:34 AM
atul closed D7979: [native] Show spinner when community creation request is in progress.
May 26 2023, 10:34 AM
atul closed D7978: [native] Hit `new_thread` endpoint in `CommunityConfiguration`.
May 26 2023, 10:34 AM
atul committed rCOMM8833d0289256: [native] Show spinner when community creation request is in progress (authored by atul).
[native] Show spinner when community creation request is in progress
May 26 2023, 10:34 AM
atul committed rCOMMe5c3f8a5e8f8: [native] Hit `new_thread` endpoint in `CommunityConfiguration` (authored by atul).
[native] Hit `new_thread` endpoint in `CommunityConfiguration`
May 26 2023, 10:34 AM
ashoat accepted D7997: [lib] Remove unused 3rd-party base64 lib.
May 26 2023, 10:34 AM
ashoat accepted D7991: [native] Add `CommunityCreationKeyserverLabel` to `CommunityCreationMembers`.
May 26 2023, 10:30 AM
ashoat accepted D7988: [native] Pull `CommunityCreationKeyserverLabel` out of `CommunityConfiguration`.
May 26 2023, 10:30 AM
ashoat accepted D7987: [native] Introduce placeholder `CommunityCreationMembers` component.
May 26 2023, 10:29 AM
ashoat added a comment to D7981: [web] Don't hide pinned messages on reload.

What happens on a refresh? Wondering if the results get "replaced" after the load is complete, or if they get "merged"

May 26 2023, 10:29 AM
ashoat accepted D7980: [native] Display error message when community creation fails.
May 26 2023, 10:26 AM
ashoat accepted D7979: [native] Show spinner when community creation request is in progress.
May 26 2023, 10:25 AM
ashoat accepted D7978: [native] Hit `new_thread` endpoint in `CommunityConfiguration`.
May 26 2023, 10:24 AM
atul accepted D7996: [web] Simplify media gallery hooks.
May 26 2023, 10:18 AM
marcin added inline comments to D7874: Encrypt Android notifications on the keyserver before sending them.
May 26 2023, 9:43 AM
marcin updated subscribers of D7874: Encrypt Android notifications on the keyserver before sending them.
May 26 2023, 9:32 AM
atul accepted D7995: [web] Fix thread gallery for encrypted media.
May 26 2023, 9:00 AM
ashoat requested changes to D7874: Encrypt Android notifications on the keyserver before sending them.

Taking over for @tomek on the review, since he is on vacation now. Thought about his feedback and have a proposed approach – @marcin, what do you think?

May 26 2023, 8:59 AM
ashoat added inline comments to D7957: [web] Create a modal where invite link can be accepted.
May 26 2023, 8:53 AM
ashoat added a comment to D7974: [native] Implement BlobUtils expo-module on Android.

Lack of syntax highlighting for Kotlin was annoying... solved it with this. Let me know if any other languages have similar problems

May 26 2023, 8:51 AM
bartek added inline comments to D7994: [web] Add MediaGalleryItem component.
May 26 2023, 8:50 AM
atul attached a referenced file: F560004: 6b1ca2.png.
May 26 2023, 8:45 AM
atul attached a referenced file: F560005: a3d6c8.png.
May 26 2023, 8:45 AM
atul requested changes to D7994: [web] Add MediaGalleryItem component.

We should use the classnames component to conditionally apply styles on web. Added some examples of usage inline.

May 26 2023, 8:44 AM
atul accepted D7976: [native] Use BlobUtils for media encryption/decryption.

In my case, the time went down from hundreds of milliseconds to 1-2ms.

May 26 2023, 8:40 AM
atul added inline comments to D7973: [native] Add BlobUtils expo-module and add iOS implementation.
May 26 2023, 8:40 AM
atul accepted D7974: [native] Implement BlobUtils expo-module on Android.

Looks good to me, but adding @marcin as blocking to take another look since he's more familiar w/ Kotlin/Android APIs/etc.

May 26 2023, 8:39 AM
bartek added inline comments to D7973: [native] Add BlobUtils expo-module and add iOS implementation.
May 26 2023, 8:39 AM
atul accepted D7973: [native] Add BlobUtils expo-module and add iOS implementation.
May 26 2023, 8:34 AM
ashoat requested review of D8001: [native] Set RegistrationTextInput keyboardAppearance based on theme.
May 26 2023, 8:18 AM
ashoat requested review of D8000: [native] Delay PasswordSelection autoFocus on Android.
May 26 2023, 8:14 AM
ashoat closed D7999: [web] Update wordmark positioning.
May 26 2023, 8:12 AM
ashoat committed rCOMM2d0fb3d0286a: [web] Update wordmark positioning (authored by ashoat).
[web] Update wordmark positioning
May 26 2023, 8:12 AM
atul accepted D7999: [web] Update wordmark positioning.
May 26 2023, 8:11 AM
atul closed D7968: [native] Make `enumCheckBox` functional in `CommunityConfiguration`.
May 26 2023, 8:10 AM
atul committed rCOMMf1b7ba40e705: [native] Make `enumCheckBox` functional in `CommunityConfiguration` (authored by atul).
[native] Make `enumCheckBox` functional in `CommunityConfiguration`
May 26 2023, 8:10 AM
ashoat requested review of D7999: [web] Update wordmark positioning.
May 26 2023, 8:03 AM
atul updated the diff for D7968: [native] Make `enumCheckBox` functional in `CommunityConfiguration`.

rebase and land

May 26 2023, 7:55 AM
atul added inline comments to D7968: [native] Make `enumCheckBox` functional in `CommunityConfiguration`.
May 26 2023, 7:48 AM
ashoat closed D7998: [web] Avoid global styles in accept-invite-modal.css.
May 26 2023, 7:40 AM
ashoat committed rCOMMd2962e1bb5fd: [web] Avoid global styles in accept-invite-modal.css (authored by ashoat).
[web] Avoid global styles in accept-invite-modal.css
May 26 2023, 7:40 AM
atul accepted D7998: [web] Avoid global styles in accept-invite-modal.css.
May 26 2023, 7:19 AM
ashoat published D7998: [web] Avoid global styles in accept-invite-modal.css for review.
May 26 2023, 7:15 AM
bartek requested review of D7997: [lib] Remove unused 3rd-party base64 lib.
May 26 2023, 2:01 AM
bartek published D7996: [web] Simplify media gallery hooks for review.
May 26 2023, 1:53 AM
bartek published D7995: [web] Fix thread gallery for encrypted media for review.
May 26 2023, 1:52 AM
bartek published D7994: [web] Add MediaGalleryItem component for review.
May 26 2023, 1:52 AM
bartek published D7993: [web] Add multimediaClassName prop to encrypted media components for review.
May 26 2023, 1:52 AM

May 25 2023

ashoat closed D7992: [native] Implement PasswordSelection logic.
May 25 2023, 2:10 PM
ashoat closed D7990: [native] Minor updates to UsernameSelection.
May 25 2023, 2:10 PM