Page MenuHomePhabricator
People ashoat

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 9:28 AM (231 w, 11 h)
Roles
Administrator

Recent Activity
View All

Today

ashoat added inline comments to D13994: [native] community list item component.
Mon, Dec 23, 8:20 AM
ashoat accepted D13994: [native] community list item component.
Mon, Dec 23, 8:19 AM

Sat, Dec 21

ashoat committed rCOMMde65669e2e44: [terraform] Bump keyserver image to 1.0.149 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.149
Sat, Dec 21, 12:10 PM
ashoat committed rCOMMcd2b9afc1ccc: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Sat, Dec 21, 9:45 AM
ashoat added a reverting change for rCOMMec8443e9e70d: [native] Temporary changes for staff release: rCOMMcd2b9afc1ccc: Revert "[native] Temporary changes for staff release".
Sat, Dec 21, 9:45 AM
ashoat committed rCOMM725f61f3d048: [native] codeVersion -> 454 (authored by ashoat).
[native] codeVersion -> 454
Sat, Dec 21, 9:45 AM
ashoat committed rCOMMec8443e9e70d: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Sat, Dec 21, 9:45 AM
ashoat committed rCOMM61284c683669: [native] codeVersion -> 453 (authored by ashoat).
[native] codeVersion -> 453
Sat, Dec 21, 9:45 AM
ashoat committed rCOMMae5270a91019: [web][keyserver] codeVersion -> 149 (authored by ashoat).
[web][keyserver] codeVersion -> 149
Sat, Dec 21, 9:45 AM
ashoat committed rCOMMce405c6de0c6: [native] Add specific commit hash for remote-redux-devtools (authored by ashoat).
[native] Add specific commit hash for remote-redux-devtools
Sat, Dec 21, 9:45 AM

Fri, Dec 20

ashoat added a reverting change for rCOMM20c577a82bd3: [native] Temporary changes for staff release: rCOMM30b94d076407: Revert "[native] Temporary changes for staff release".
Fri, Dec 20, 12:56 PM
ashoat committed rCOMM30b94d076407: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Fri, Dec 20, 12:56 PM
ashoat committed rCOMMf2146d9df587: [native] codeVersion -> 452 (authored by ashoat).
[native] codeVersion -> 452
Fri, Dec 20, 12:56 PM
ashoat committed rCOMM20c577a82bd3: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Fri, Dec 20, 12:56 PM
ashoat committed rCOMM2836dcffc01f: [native] codeVersion -> 451 (authored by ashoat).
[native] codeVersion -> 451
Fri, Dec 20, 12:56 PM
ashoat committed rCOMM503e0d3478ed: [web][keyserver] codeVersion -> 148 (authored by ashoat).
[web][keyserver] codeVersion -> 148
Fri, Dec 20, 12:56 PM
ashoat closed D14176: [keyserver] Avoid ignorePromiseRejections if isScriptViewer.
Fri, Dec 20, 12:52 PM
ashoat committed rCOMMb84a1b80f2b7: [keyserver] Avoid ignorePromiseRejections if isScriptViewer (authored by ashoat).
[keyserver] Avoid ignorePromiseRejections if isScriptViewer
Fri, Dec 20, 12:52 PM
ashoat closed D14175: [lib] Always include an extra item in getCandidateSidebarItemsForThreadList.
Fri, Dec 20, 12:52 PM
ashoat committed rCOMM172f8c434b96: [lib] Always include an extra item in getCandidateSidebarItemsForThreadList (authored by ashoat).
[lib] Always include an extra item in getCandidateSidebarItemsForThreadList
Fri, Dec 20, 12:52 PM

Thu, Dec 19

ashoat requested review of D14176: [keyserver] Avoid ignorePromiseRejections if isScriptViewer.
Thu, Dec 19, 6:43 AM
ashoat requested review of D14175: [lib] Always include an extra item in getCandidateSidebarItemsForThreadList.
Thu, Dec 19, 6:40 AM

Tue, Dec 17

ashoat closed D14160: [lib] Add log and continue in getPushUserInfo when thread missing from ThreadStore.
Tue, Dec 17, 8:51 PM
ashoat committed rCOMM98e1d21a043b: [lib] Add log and continue in getPushUserInfo when thread missing from… (authored by ashoat).
[lib] Add log and continue in getPushUserInfo when thread missing from…
Tue, Dec 17, 8:51 PM

Mon, Dec 16

ashoat requested review of D14160: [lib] Add log and continue in getPushUserInfo when thread missing from ThreadStore.
Mon, Dec 16, 11:09 AM
ashoat added inline comments to D14148: [native] Handler for migrating to signed device lists.
Mon, Dec 16, 6:40 AM
ashoat accepted D14159: [native] replace back button with close button on the scanning QR code screen.
Mon, Dec 16, 6:10 AM
ashoat accepted D14149: [native] implement screen after secondary device is connected.

Thanks for the videos, @kamil. I guess I'm leaning towards the existing code now... the whitespace seems less confusing in the video. Curious for @kamil and @tomek's takes, but if you guys agree we can keep it as-is.

Mon, Dec 16, 6:03 AM

Fri, Dec 13

ashoat added inline comments to D14128: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API.
Fri, Dec 13, 6:38 PM
ashoat added inline comments to D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.
Fri, Dec 13, 6:36 PM
ashoat added inline comments to D14111: [native] Move methods from Tooltip to functional compononent.
Fri, Dec 13, 6:35 PM
ashoat added a comment to D13994: [native] community list item component.

Talked about this offline – I was wrong in much of my assessment above. We paired after lunch, and afterwards Varun figured out a way forward to unblock the work

Fri, Dec 13, 6:33 PM
ashoat committed rCOMM9d08a8bc2f2a: [keyserver] Fix up get-community-ids.js script (authored by ashoat).
[keyserver] Fix up get-community-ids.js script
Fri, Dec 13, 6:19 PM
ashoat committed rCOMM7c243ccfcc62: [terraform] Bump keyserver image to 1.0.147 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.147
Fri, Dec 13, 6:19 PM
ashoat committed rCOMM319fbd03c8a1: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Fri, Dec 13, 5:31 PM
ashoat added a reverting change for rCOMM42ecbbea1546: [native] Temporary changes for staff release: rCOMM319fbd03c8a1: Revert "[native] Temporary changes for staff release".
Fri, Dec 13, 5:31 PM
ashoat committed rCOMMfe196394030f: [native] codeVersion -> 450 (authored by ashoat).
[native] codeVersion -> 450
Fri, Dec 13, 5:31 PM
ashoat committed rCOMM42ecbbea1546: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Fri, Dec 13, 5:31 PM
ashoat committed rCOMM23680c59afc2: [native] codeVersion -> 449 (authored by ashoat).
[native] codeVersion -> 449
Fri, Dec 13, 5:31 PM
ashoat committed rCOMM9ad082c5893a: [web][keyserver] codeVersion -> 147 (authored by ashoat).
[web][keyserver] codeVersion -> 147
Fri, Dec 13, 5:31 PM
ashoat committed rCOMM7ea5fde4254d: [lib] Minor optimizations to getCandidateSidebarItemsForThreadList (authored by ashoat).
[lib] Minor optimizations to getCandidateSidebarItemsForThreadList
Fri, Dec 13, 5:31 PM
ashoat closed D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars.
Fri, Dec 13, 4:37 PM
ashoat closed D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.
Fri, Dec 13, 4:37 PM
ashoat committed rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList (authored by ashoat).
[lib] Deduplicate in getCandidateSidebarItemsForThreadList
Fri, Dec 13, 4:37 PM
ashoat committed rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars (authored by ashoat).
[lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars
Fri, Dec 13, 4:37 PM
ashoat closed D14156: [lib] Fix stack overflow from lastUpdatedTime.
Fri, Dec 13, 4:36 PM
ashoat committed rCOMM730c48dec5a5: [lib] Fix stack overflow from lastUpdatedTime (authored by ashoat).
[lib] Fix stack overflow from lastUpdatedTime
Fri, Dec 13, 4:36 PM
ashoat published D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList for review.

I'll confirm relevant CI passes before landing

Fri, Dec 13, 2:58 PM
ashoat published D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars for review.

I'll confirm relevant CI passes before landing

Fri, Dec 13, 2:57 PM
ashoat added inline comments to D13996: [native] community joiner modal.
Fri, Dec 13, 1:21 PM
ashoat accepted D14155: [native] Delete console log.
Fri, Dec 13, 11:56 AM
ashoat published D14156: [lib] Fix stack overflow from lastUpdatedTime for review.

Will wait for relevant CI before landing

Fri, Dec 13, 9:09 AM
ashoat added a comment to D13994: [native] community list item component.

Also: in the screenshot you shared, the vertical padding seems uneven between top / bottom

Fri, Dec 13, 8:30 AM
ashoat requested changes to D13994: [native] community list item component.

Can you share updated videos of how this looks in both dark mode and light mode?

Fri, Dec 13, 8:29 AM
ashoat added inline comments to D14111: [native] Move methods from Tooltip to functional compononent.
Fri, Dec 13, 6:17 AM
ashoat added inline comments to D14113: [native] Enable Flow types in Reanimated worklets.
Fri, Dec 13, 5:37 AM

Thu, Dec 12

ashoat requested review of D14154: [lib] Use ChatThreadItemLoaderCache for loading sidebar.
Thu, Dec 12, 8:09 PM
ashoat updated the summary of D13828: [lib] Only show reactions to viewer's messages in MessagePreview.
Thu, Dec 12, 7:49 PM
ashoat updated the diff for D14144: [native] Stop resetting ChatThreadList on navigation.

Rebase

Thu, Dec 12, 7:36 PM
ashoat updated the diff for D14141: [lib][native] Update native to use ChatThreadItemLoaderCache.

Rebase, introduce pageSize

Thu, Dec 12, 7:35 PM
ashoat updated the diff for D14140: [lib] Introduce ChatThreadItemLoaderCache.

Remove defaultNumItemsToDisplay, as it's no longer used in this file

Thu, Dec 12, 7:34 PM
ashoat updated the diff for D14140: [lib] Introduce ChatThreadItemLoaderCache.

Fix and rename

Thu, Dec 12, 7:18 PM
ashoat added inline comments to D13996: [native] community joiner modal.
Thu, Dec 12, 2:44 PM
ashoat resigned from D14153: [native] handle waiting for secondary device response.

Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me

Thu, Dec 12, 12:27 PM
ashoat accepted D14145: [keyserver][script] get IDs for community names.
Thu, Dec 12, 12:26 PM
ashoat accepted D14152: [native] implement screen when secondary device is not responding.

Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.

Thu, Dec 12, 12:24 PM
ashoat resigned from D14151: [native] add callback to remove secondary device during QR auth.

Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me

Thu, Dec 12, 12:22 PM
ashoat accepted D14150: [native] add danger option to `PrimaryButton`.
Thu, Dec 12, 12:21 PM
ashoat requested changes to D14149: [native] implement screen after secondary device is connected.

Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.

Thu, Dec 12, 12:17 PM
ashoat accepted D13997: [native] update community drawer button to navigate to community joiner modal.
Thu, Dec 12, 12:13 PM
ashoat requested changes to D13996: [native] community joiner modal.

This is close, but requesting changes due to the volume of comments below

Thu, Dec 12, 11:21 AM
ashoat requested changes to D14145: [keyserver][script] get IDs for community names.

Passing back with some questions

Thu, Dec 12, 11:06 AM
ashoat accepted D14116: [native] navigate to proper screen after scanning QR code.
Thu, Dec 12, 11:03 AM
ashoat accepted D14115: [native] implement screen when connecting secondary device.

Would appreciate @tomek's help in reviewing the QRAuthContext part... it's hard for me to track the whole flow and where connectingInProgress should be set

Thu, Dec 12, 11:00 AM
ashoat accepted D14114: [native] implement screen when scanning QR code a non-primary device.
Thu, Dec 12, 10:58 AM
ashoat accepted D14105: [native] implement QR Auth context.

Thanks for explaining... not sure how I missed that. You'd think after 10 years of using Phabricator I'd be better at using it 😅

Thu, Dec 12, 10:54 AM
ashoat accepted D13995: [native] introduce community list component.
Thu, Dec 12, 10:49 AM
ashoat added a comment to D14098: [native] Fix reanimated cancelAnimation flow type.

Thanks for sharing!

Thu, Dec 12, 10:42 AM

Wed, Dec 11

ashoat updated the diff for D14143: [native] Add loading indicator at the bottom of ChatThreadList.

Fix

Wed, Dec 11, 8:34 PM
ashoat accepted D14135: [native] Move render function in MultimediaMessageMultimedia to functional component.
Wed, Dec 11, 8:11 PM
ashoat accepted D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.

Accepting so I don't block you, but please make sure you've considered whether there's any risks associated with this effect potentially being run on mount

Wed, Dec 11, 8:10 PM
ashoat accepted D14133: [native] Migrate opacity in MultimediaMessageMultimedia to Reanimated v2 API in functional component.
Wed, Dec 11, 8:07 PM
ashoat added inline comments to D14112: [native] Move render function from Tooltip to functional component.
Wed, Dec 11, 8:05 PM
ashoat accepted D14132: [native] Move onPress and onLayout methods in MultimediaMessageMultimedia to functional component.
Wed, Dec 11, 8:03 PM
ashoat accepted D14131: [native] Move view ref in MultimediaMessageMultimedia to functional component.
Wed, Dec 11, 8:02 PM
ashoat accepted D14130: [native] Migrate ActionResultModal component to Reanimated v2 API.
Wed, Dec 11, 8:02 PM
ashoat accepted D14129: [native] Workarounds for bugs after reanimated migration.

Thank you for a detailed and thorough explanation!! You went really deep here, love it :)

Wed, Dec 11, 8:01 PM
ashoat accepted D14128: [native] Migrate useOverlayPosition, useContentAndHeaderOpacity, useDeliveryIconOpacity hooks to Reanimated V2 API.
Wed, Dec 11, 7:58 PM
ashoat accepted D14127: [native] Remove progress prop from tooltip buttons components.
Wed, Dec 11, 7:56 PM
ashoat accepted D14126: [native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API.
Wed, Dec 11, 7:55 PM
ashoat accepted D14125: [native] Migrate MultimediaMessageTooltipButton component to Reanimated V2 API.
Wed, Dec 11, 7:55 PM
ashoat accepted D14124: [native] Migrate ReactionSelectionPopover component to Reanimated V2 API.
Wed, Dec 11, 7:55 PM
ashoat accepted D14123: [native] Migrate TooltipInlineEngagement to Reanimated V2 API.
Wed, Dec 11, 7:55 PM
ashoat accepted D14122: [native] Migrate TextMessageTooltipButton to Reanimated V2 API.
Wed, Dec 11, 7:54 PM
ashoat accepted D14121: [native] Remove progress parameter from useAnimatedMessageTooltipButton.
Wed, Dec 11, 7:53 PM
ashoat accepted D14120: [native] Migrate threadColorOverride in useAnimatedMessageTooltipButton to Reanimate V2 API.
Wed, Dec 11, 7:53 PM
ashoat accepted D14119: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to Reanimate V2 API.
Wed, Dec 11, 7:51 PM
ashoat added a comment to D14118: [native] Add progressV2 field to tooltip button types.

Thanks for separating this out!

Wed, Dec 11, 7:50 PM
ashoat accepted D14118: [native] Add progressV2 field to tooltip button types.
Wed, Dec 11, 7:50 PM
ashoat accepted D14117: [native] Migrate Tooltip component to Reanimated v2 API.
Wed, Dec 11, 7:49 PM