Page MenuHomePhorge
People ashoat

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 4:28 PM (280 w, 3 d)
Roles
Administrator

Recent Activity
View All

Yesterday

ashoat committed rCOMM48183c2721e2: [terraform] Bump keyserver image to 1.0.208.
Thu, Dec 4, 10:29 PM
ashoat committed rCOMM9f0d1368db16: Revert "[native] Temporary changes for staff release".
Thu, Dec 4, 9:15 PM
ashoat added a reverting change for rCOMM010f24e193d6: [native] Temporary changes for staff release: rCOMM9f0d1368db16: Revert "[native] Temporary changes for staff release".
Thu, Dec 4, 9:15 PM
ashoat committed rCOMMa532e08903f6: [native] codeVersion -> 560.
Thu, Dec 4, 9:15 PM
ashoat committed rCOMM010f24e193d6: [native] Temporary changes for staff release.
Thu, Dec 4, 9:15 PM
ashoat committed rCOMM7f37cd81ed01: [web][keyserver] codeVersion -> 208.
Thu, Dec 4, 9:15 PM
ashoat committed rCOMMd584faf15d5e: [native] codeVersion -> 559.
Thu, Dec 4, 9:15 PM
ashoat committed rCOMM30fbf1838062: [lib] Update NEXT_CODE_VERSION.
Thu, Dec 4, 9:15 PM
ashoat abandoned D15549: [native] implement CXX bindings to Vodozemac.
Thu, Dec 4, 5:30 PM
ashoat abandoned D15548: [lib][web][keyserver] replace Olm with Vodozemac's Olm.

This was landed, but it got squashed into another commit due to the way we handled the corresponding GitHub PRs (Phabricator was down at the time, so we used GitHub)

Thu, Dec 4, 5:30 PM
ashoat added a comment to D15549: [native] implement CXX bindings to Vodozemac.

This was landed, but it got squashed into another commit due to the way we handled the corresponding GitHub PRs (Phabricator was down at the time, so we used GitHub)

Thu, Dec 4, 5:29 PM
ashoat commandeered D15548: [lib][web][keyserver] replace Olm with Vodozemac's Olm.
Thu, Dec 4, 5:29 PM
ashoat commandeered D15549: [native] implement CXX bindings to Vodozemac.
Thu, Dec 4, 5:29 PM

Mon, Nov 17

ashoat accepted D15544: [native][lib] remove feature flag service client code.
Mon, Nov 17, 12:54 PM
ashoat accepted D15545: [terraform] optimize Fargate resource usage v2.
Mon, Nov 17, 12:50 PM

Thu, Nov 13

ashoat committed rCOMMe3c418883e1d: [terraform] Bump keyserver image to 1.0.207.
Thu, Nov 13, 7:27 PM
ashoat added a reverting change for rCOMMb376fef9a52e: [native] Temporary changes for staff release: rCOMMcfbe7a93eaf3: Revert "[native] Temporary changes for staff release".
Thu, Nov 13, 6:28 PM
ashoat committed rCOMMcfbe7a93eaf3: Revert "[native] Temporary changes for staff release".
Thu, Nov 13, 6:28 PM
ashoat committed rCOMMf75fea88b299: [native] codeVersion -> 558.
Thu, Nov 13, 6:28 PM
ashoat committed rCOMMb376fef9a52e: [native] Temporary changes for staff release.
Thu, Nov 13, 6:28 PM
ashoat committed rCOMM0af296883ccc: [web][keyserver] codeVersion -> 207.
Thu, Nov 13, 6:28 PM
ashoat committed rCOMM3da74aba262d: [native] codeVersion -> 557.
Thu, Nov 13, 6:28 PM

Wed, Nov 12

ashoat accepted D15542: [native] add vodozemac to native build on iOS and Android.

Discussed in 1:1; @kamil will follow-up with responses to my comments later

Wed, Nov 12, 3:42 PM
ashoat added inline comments to D15542: [native] add vodozemac to native build on iOS and Android.
Wed, Nov 12, 3:28 PM

Nov 4 2025

ashoat accepted D15541: [terraform] optimize Fargate resource usage.
Nov 4 2025, 3:57 PM

Nov 3 2025

ashoat accepted D15540: [terraform] lower Fargate resource usage on prod.
Nov 3 2025, 1:56 PM

Oct 31 2025

ashoat added inline comments to D15539: [terraform] remove EC2 capacity provider from the cluster.
Oct 31 2025, 5:51 PM
ashoat accepted D15536: [terraform] remove EC2-based infrastructure.
Oct 31 2025, 5:50 PM
ashoat accepted D15539: [terraform] remove EC2 capacity provider from the cluster.
Oct 31 2025, 5:50 PM
ashoat accepted D15538: [terraform] remove EC2-based resources.
Oct 31 2025, 5:50 PM
ashoat accepted D15537: [terraform] remove EC2 targets from load balancers.
Oct 31 2025, 5:50 PM
ashoat accepted D15535: [lib] Remove a leftover feature flag.
Oct 31 2025, 12:23 PM

Oct 30 2025

ashoat accepted D15534: [lib] Upload the Farcaster thread avatars.
Oct 30 2025, 11:21 PM
ashoat accepted D15533: [lib] Call the Farcaster API to update the avatar.
Oct 30 2025, 11:21 PM
ashoat accepted D15532: [lib] Add an option to remove avatar to the API.
Oct 30 2025, 11:21 PM
ashoat accepted D15531: [lib] Introduce the API that allows setting the avatar.
Oct 30 2025, 11:21 PM
ashoat accepted D15530: [lib] Enable setting all thread avatar types except emoji for Farcaster.
Oct 30 2025, 11:21 PM
ashoat accepted D15529: [native] Add native_rust_library to NotificationService target.

This one is hard to review... I'm not really familiar with the .pbxproj format. Regarding the notification service limits, I'm not familiar with those either...

Oct 30 2025, 5:49 PM
ashoat accepted D15528: [native][web][lib] make it possible to manually reset ratchet.
Oct 30 2025, 3:39 PM

Oct 29 2025

ashoat committed rCOMMc0c81e9d3cb5: [terraform] Bump keyserver image to 1.0.206.
Oct 29 2025, 2:57 PM
ashoat added a reverting change for rCOMM604cb430fc52: [native] Temporary changes for staff release: rCOMM8af19b1e4eab: Revert "[native] Temporary changes for staff release".
Oct 29 2025, 1:50 PM
ashoat committed rCOMM8af19b1e4eab: Revert "[native] Temporary changes for staff release".
Oct 29 2025, 1:50 PM
ashoat committed rCOMMbb18b86772da: [native] codeVersion -> 556.
Oct 29 2025, 1:50 PM
ashoat committed rCOMM604cb430fc52: [native] Temporary changes for staff release.
Oct 29 2025, 1:50 PM
ashoat committed rCOMMd74a5fbaaeb8: [native] codeVersion -> 555.
Oct 29 2025, 1:50 PM
ashoat committed rCOMMd20f117880c6: [web][keyserver] codeVersion -> 206.
Oct 29 2025, 1:50 PM
ashoat committed rCOMMd85be6a99354: [landing] Remove signIn from SIWF effect dep list.
Oct 29 2025, 1:46 PM

Oct 28 2025

ashoat committed rCOMMdb74eca58aff: [terraform] Bump keyserver image to 1.0.205.
Oct 28 2025, 2:23 PM
ashoat committed rCOMM35a0026f8acb: Revert "[native] Temporary changes for staff release".
Oct 28 2025, 1:52 PM
ashoat added a reverting change for rCOMMe4ea7e652f3f: [native] Temporary changes for staff release: rCOMM35a0026f8acb: Revert "[native] Temporary changes for staff release".
Oct 28 2025, 1:52 PM
ashoat committed rCOMM471d03b11782: [native] codeVersion -> 554.
Oct 28 2025, 1:52 PM
ashoat committed rCOMMe4ea7e652f3f: [native] Temporary changes for staff release.
Oct 28 2025, 1:52 PM
ashoat committed rCOMM3b655de52293: [native] codeVersion -> 553.
Oct 28 2025, 1:51 PM
ashoat committed rCOMM3d7add3e1229: [web][keyserver] codeVersion -> 205.
Oct 28 2025, 1:51 PM

Oct 24 2025

ashoat accepted D15523: [lib] Log an error when pinning messages fails.
Oct 24 2025, 6:43 PM
ashoat added inline comments to D15522: [lib] Determine thick sidebar title.
Oct 24 2025, 6:42 PM
ashoat committed rCOMM8a8611d1eeb7: [terraform] Bump keyserver image to 1.0.204.
Oct 24 2025, 5:52 PM

Oct 23 2025

ashoat added a reverting change for rCOMMeefd246a1a21: [native] Temporary changes for staff release: rCOMM04770053ca01: Revert "[native] Temporary changes for staff release".
Oct 23 2025, 9:08 PM
ashoat committed rCOMM04770053ca01: Revert "[native] Temporary changes for staff release".
Oct 23 2025, 9:08 PM
ashoat committed rCOMM0fd1f4da8b3d: [native] codeVersion -> 552.
Oct 23 2025, 9:08 PM
ashoat committed rCOMMeefd246a1a21: [native] Temporary changes for staff release.
Oct 23 2025, 9:08 PM
ashoat committed rCOMM0292b51d9858: [native] codeVersion -> 551.
Oct 23 2025, 9:08 PM
ashoat committed rCOMM9bb3f15da06e: [web][keyserver] codeVersion -> 204.
Oct 23 2025, 9:08 PM
ashoat committed rCOMMab6ec57d1bb9: [lib] Unbreak pending threads.
Oct 23 2025, 9:08 PM
ashoat committed rCOMMd7ae0aa2dafc: [terraform] Bump keyserver image to 1.0.203.
Oct 23 2025, 7:20 PM
ashoat added a reverting change for rCOMM52a2a28c0127: [native] Temporary changes for staff release: rCOMM9c55ceed845e: Revert "[native] Temporary changes for staff release".
Oct 23 2025, 4:32 PM
ashoat committed rCOMM9c55ceed845e: Revert "[native] Temporary changes for staff release".
Oct 23 2025, 4:32 PM
ashoat committed rCOMM7e5280e72ebc: [native] codeVersion -> 550.
Oct 23 2025, 4:32 PM
ashoat committed rCOMM52a2a28c0127: [native] Temporary changes for staff release.
Oct 23 2025, 4:32 PM
ashoat committed rCOMMb62ce70b8434: [native] codeVersion -> 549.
Oct 23 2025, 4:32 PM
ashoat committed rCOMM53a804bfc5d4: [web][keyserver] codeVersion -> 203.
Oct 23 2025, 4:32 PM
ashoat closed D15516: [lib] Fix extractIDsFromPayload for tShapeInexact.
Oct 23 2025, 3:18 PM
ashoat committed rCOMM9957c5e7a2c8: [lib] Fix extractIDsFromPayload for tShapeInexact.
Oct 23 2025, 3:18 PM
ashoat added a comment to D15512: Revert "[lib] Remove unnecessary Farcaster props".

Makes sense!

Oct 23 2025, 3:08 PM
ashoat added a comment to D15512: Revert "[lib] Remove unnecessary Farcaster props".

D15516 fixes the issue I was referring to.

Oct 23 2025, 2:35 PM
ashoat published D15516: [lib] Fix extractIDsFromPayload for tShapeInexact for review.
Oct 23 2025, 2:34 PM
ashoat added a comment to D15512: Revert "[lib] Remove unnecessary Farcaster props".

Here's a failing unit test: https://linear.app/comm/issue/ENG-11509/messages-appear-as-if-from-wrong-user#comment-94575408

Oct 23 2025, 2:22 PM
ashoat requested changes to D15512: Revert "[lib] Remove unnecessary Farcaster props".

We have an object that looks like this:

Oct 23 2025, 2:14 PM
ashoat added a comment to D15504: [native][web] Improve the pin modals.

These buttons not having a loading status was a pet peeve of mine. Thanks for fixing!

Oct 23 2025, 2:12 PM
ashoat requested changes to D15512: Revert "[lib] Remove unnecessary Farcaster props".

I am skeptical of this approach. The core issue is that our FID extraction breaks when unexpected object fields are encountered. What happens if Farcaster introducing a new object field? Won’t the same issue occur? I think we need to fix the core issue instead of reverting this. Let me know if I’m missing something.

Oct 23 2025, 12:16 PM

Oct 22 2025

ashoat committed rCOMM94f8f6158d74: [terraform] Bump keyserver image to 1.0.202.
Oct 22 2025, 4:15 PM
ashoat added a reverting change for rCOMM47e1b163459f: [native] Temporary changes for staff release: rCOMMdd9a512bb045: Revert "[native] Temporary changes for staff release".
Oct 22 2025, 3:20 PM
ashoat committed rCOMMdd9a512bb045: Revert "[native] Temporary changes for staff release".
Oct 22 2025, 3:20 PM
ashoat committed rCOMM21757f813957: [native] codeVersion -> 548.
Oct 22 2025, 3:20 PM
ashoat committed rCOMM47e1b163459f: [native] Temporary changes for staff release.
Oct 22 2025, 3:20 PM
ashoat committed rCOMMa7f2cd42f40c: [native] codeVersion -> 547.
Oct 22 2025, 3:20 PM
ashoat committed rCOMM1ffeeb5df389: [web][keyserver] codeVersion -> 202.
Oct 22 2025, 3:20 PM
ashoat committed rCOMM36bee0d6222a: [native] Fix ThemeHandler overwriting theme data from client DB on app start.
Oct 22 2025, 3:16 PM
ashoat committed rCOMM4a76f3308fbb: [native] Fix TextInput positioning in Entry and focus jitter on iOS.
Oct 22 2025, 6:08 AM

Oct 21 2025

ashoat committed rCOMMf6d32a1d8dd6: [native] Fix double-tap-to-zoom in FullScreenViewModal.
Oct 21 2025, 5:19 AM
ashoat committed rCOMM503cc7c68b83: [landing][lib][native] Update Farcaster logos.
Oct 21 2025, 5:19 AM

Oct 20 2025

ashoat added a comment to D15494: [terraform] fix gRPC on web with Fargate instance.

We need this for CORS requests

Oct 20 2025, 2:42 PM
ashoat accepted D15495: [terraform] route network to Fargate services.
Oct 20 2025, 2:20 PM
ashoat accepted D15494: [terraform] fix gRPC on web with Fargate instance.
Oct 20 2025, 1:03 PM
ashoat committed rCOMM6b54aaf1e8b6: [terraform] Bump keyserver image to 1.0.201.
Oct 20 2025, 3:31 AM
ashoat committed rCOMM55650025d3b1: Revert "[native] Temporary changes for staff release".
Oct 20 2025, 2:50 AM
ashoat added a reverting change for rCOMM74474a470d43: [native] Temporary changes for staff release: rCOMM55650025d3b1: Revert "[native] Temporary changes for staff release".
Oct 20 2025, 2:50 AM
ashoat committed rCOMM957670973030: [native] codeVersion -> 546.
Oct 20 2025, 2:50 AM
ashoat committed rCOMM74474a470d43: [native] Temporary changes for staff release.
Oct 20 2025, 2:50 AM
ashoat committed rCOMM5a2f33142e34: [native] codeVersion -> 545.
Oct 20 2025, 2:50 AM