Changes in initial version broke useSearchSidebars comparison algo. Moved the sorting to getSidebarItems instead, which isn't used in useSearchSidebars and is only used in chat-selectors.js

Fix rebase mistake

Yes, exactly!

Passing to @tomek's queue

Just wondering, what do you think of this style?

I guess a way to reframe what you're saying about useUsersSupportThickThreads is that userHasDeviceList doesn't match findUserIdentities in the case of an empty device list. We end up returning the correct answer anyways, since we check findUserIdentities as a fallback. But it would be better if we were able to get the right answer without having to query the identity service.

Thanks @angelika. Some concerns:

I went through each of these on my own and I think it's safe

Back to you with question

On the web, we don't support the restoration flow, so I don't think it makes sense to introduce the link to the restore flow.

Don't love that we're artifically inserting a permission that doesn't exist. Is it truly necessary?

Looks great!

To be honest, I think it looks okay without the underline. What do you think?

Use Array.prototype.every()

Code comments

I was more concerned about users being able to notice that a link can be clickable. In the mobile app, we usually use buttons to indicate actions that can be performed. There are some usages of LinkButton, but only in the navigation header where users expect some actions to be possible.

It sounds like you're proposing a solution where on the initial screen there are two buttons: Sign in and Register. Clicking Sign in opens the QR screen, where there is a No longer have access to your primary device? text. Clicking this link would open the restore screen. Is that correct?

Rebase

Looks good to me! I'm not familiar with the NUX code (it was introduced while I was away) so would appreciate if @tomek could take a look too

1. I'm not sure the "OR" thing is necessary anymore now that we only have two buttons instead of three
2. Can we replace "Sign in" with "Sign in with password"?

I think it would be best to tuck the restore button behind the login button.