This diff allows calling any keyserver to check if a link is valid.
https://linear.app/comm/issue/ENG-5423/join-a-community-on-a-given-keyserver
Depends on D10206
Details
Details
Check if clicking an invite link opens a modal on web. Also checked if providing an explicit keyserver id works.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- linki
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
You forgot to add a hook wrapping the function. We don't want the calling code to include useKeyserverCall, we want this to be hidden away.
| lib/actions/link-actions.js | ||
|---|---|---|
| 27 ↗ | (On Diff #34474) | Wouldn't it be better if this was keyserverID?: string? What do we gain by having it be keyserverID: ?string, and then defaulting to ashoatKeyserverID inside the function, if the calling code has to provide this argument at all times? |
Comment Actions
This shouldn't work. You pass
keyserverInfos: {
[keyserverOverride.keyserverURL]: {
urlPrefix: keyserverOverride.keyserverURL,
},
},into callKeyserverEndpoint, but then the request is keyed with keyserverID. So you will be trying to call keyserverID keyserver, for which you don't have an entry in your overridden keyserverInfos.
Comment Actions
Use the correct key in overrides. Tested it by specifying keyserver override in web link
handler.
const validateLink = useVerifyInviteLink({
keyserverID: ashoatKeyserverID,
keyserverURL: 'http://localhost:3000/keyserver',
});This calls the proper endpoint, but causes some other issues - e.g. invite link
verification assumes that a user is logged in, which isn't always true when using an invite
link. Going to fix this in the next diffs.