We no longer rely on keyserver to keep the keys - this is a responsibility of Identity service.
https://linear.app/comm/issue/ENG-6521/check-serverrequesttypesmore-one-time-keys
Depends on D11176
Details
Details
Check if keyserver DB migration deletes the table.
Check if it is possible to run web and native client.
Run an older native client and check if it works with new keyserver.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- sockets
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks good, just want to make sure that this won't break any older clients? I see the following in Test Plan:
Run an older native client and check if it works with new keyserver.
so I'm assuming this table and functionality was never used?
Comment Actions
MORE_ONE_TIME_KEYS request is sent by the server - so if a new version of the server is deployed, clients will no longer need to support responding to it. But the table was used in a way - the server was writing to it, but noone asked for the keys.
getSessionPublicKeys endpoint was never used - verified that by searching git git log -S getSessionPublicKeys --source --all - it was modified in a couple of diffs where the validators were introduced. It appeared for the first time in https://phab.comm.dev/D2933, where it was renamed, but there were no usages at that point.